Owen Mansel-Chan
3e2bbd38d4
Remove "$ANYVERSION" from models
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
47d946fb1c
Make MaD package match any version without $ANYVERSION
...
Note that if the package column contains major version suffix (like
"/v2") or if it ends with "$THISVERSION" (which is removed) then we
don't do any version matching.
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
ea0db4d55e
Add predicate for package path without "/v2" etc
2024-06-26 05:01:09 +01:00
Rasmus Lerchedahl Petersen
571be8be3e
Python: model more loggers
2024-06-26 01:00:38 +02:00
Rasmus Lerchedahl Petersen
eb32cbe8a5
Python: codecs.open
2024-06-26 00:57:59 +02:00
Rasmus Lerchedahl Petersen
bdc48088e6
Python: MaD summary models
...
Two of the generated summaries have been excluded:
- ["re", "Member[split]", "Argument[0,pattern:]", "ReturnValue", "taint"]
From the documentation, it is not clear why pattern should figure in the return value, as that is the part denoting split point and thus all those instances are filtered out.
From the implementation
Spit function: https://github.com/python/cpython/blob/3.12/Lib/re/__init__.py#L199
_compile function being called by split: https://github.com/python/cpython/blob/3.12/Lib/re/__init__.py#L280
We see that in case the pattern is already a compiled `Pattern`, it is returned directly from _compile and could thus be part of the return value from split. This is probably not possible to arrange for an attacker, and so an FP in practice.
- ["urllib2", "Member[unquote]", "Argument[0,string:]", "ReturnValue", "taint"]
urllib2 seems to be only in Python2 (e.g. https://docs.python.org/2.7/library/urllib2.html ) and I cannot locate the function unquote.
2024-06-26 00:39:30 +02:00
Ian Lynagh
f9ae44ca5c
Merge pull request #16736 from igfoo/igfoo/debugLoC
...
Java/Kotlin: Tag the LoC queries 'debug'
2024-06-25 22:57:36 +01:00
Cornelius Riemenschneider
37da3e1bb3
Bump to bazel 7.2.1.
2024-06-25 21:21:39 +02:00
am0o0
656dc4e276
use abstract class for decompression sinks
2024-06-25 18:09:27 +02:00
am0o0
13f697c056
relocate the query
2024-06-25 17:31:40 +02:00
Chris Smowton
2413332553
Merge pull request #16802 from github/smowton/admin/note-java-system-requirements
...
Java: document extraction system requirements
2024-06-25 15:53:09 +01:00
Ian Lynagh
c12adbeeaa
Java/Kotlin: Tag the LoC queries 'debug'
...
This brings them into line with LinesOfCode.ql
2024-06-25 15:46:10 +01:00
Michael Nebel
d18915a1e4
C#: Update expected test output.
2024-06-25 16:02:58 +02:00
Michael Nebel
e15a47d58c
C#: Update the extractor to use the BestOrDefault extension method to choose between multiple locations.
2024-06-25 16:02:54 +02:00
Michael Nebel
dd65d960be
C#: Introduce a Location extension method to help pick a unique location.
2024-06-25 16:02:49 +02:00
Michael Nebel
8dc95ce9b0
Merge pull request #16722 from michaelnebel/csharp/modelgensourcesink
...
C#/Java: Respect manual neutrals, sources and sinks in model generation.
2024-06-25 15:55:06 +02:00
yoff
58b6b3f601
Merge pull request #16789 from yoff/python/document-models-as-data
...
python: Document MaD format
2024-06-25 15:46:28 +02:00
Arthur Baars
306e481c5d
Merge pull request #16830 from github/post-release-prep/codeql-cli-2.17.6
...
Post-release preparation for codeql-cli-2.17.6
2024-06-25 15:26:05 +02:00
Tamas Vajk
5058727980
C#: Update (some) nuget dependencies
2024-06-25 15:24:08 +02:00
Anders Schack-Mulligen
1cc49af454
Dataflow: Address review comments.
2024-06-25 15:19:55 +02:00
Rasmus Lerchedahl Petersen
bc551174f9
Python: model copy.deepcopy as a value step
2024-06-25 14:53:06 +02:00
Rasmus Lerchedahl Petersen
501cda4e8c
Python: model fnmatch.filter
2024-06-25 14:44:39 +02:00
Asger F
6b35a766a6
Migrate to shared FlowSummary library
2024-06-25 14:43:29 +02:00
Rasmus Lerchedahl Petersen
2118f233b9
Python: model optparse.OptionParser.parse_arg
2024-06-25 14:40:23 +02:00
Rasmus Lerchedahl Petersen
b80a711b27
python: undo changes to qlpack
2024-06-25 14:13:59 +02:00
Rasmus Lerchedahl Petersen
1e97600c4a
Python: move models
2024-06-25 14:13:56 +02:00
Rasmus Lerchedahl Petersen
d410136852
python: compress models
2024-06-25 14:13:52 +02:00
Rasmus Lerchedahl Petersen
c004ffaca8
python: move model to Stdlib.yml
...
There is already a model there so we add to that one.
We did observe that this existing model was blocked by the external MaD model.
This is concerning and needs to be cleared up.
2024-06-25 14:13:48 +02:00
Rasmus Lerchedahl Petersen
281ac05868
python: add modelling for urlib.parse
...
- `quote` together with `re.compile` recover regex injection alerts on haiwen/seahub
- `quote_plus` recovers the URL redirection alert on DemocracyClub/EveryElection
- `unquote` recovers path injection alerts on `cloudera/hue`
- it was tedious finding justifications for the rest..
2024-06-25 14:13:44 +02:00
Rasmus Lerchedahl Petersen
df406b4fca
python: Start modelling using MaD
...
- empty models for now
- `summaryModel` of `codeql/python-all` will be added to shortly.
2024-06-25 14:13:41 +02:00
Alvaro Muñoz
1fd7c148a5
Bump qlpack versions
2024-06-25 13:58:25 +02:00
Asger F
dd7aff555d
Instantiate shared FlowSummary library
2024-06-25 13:35:49 +02:00
Asger F
f0d7c3a7f0
Remove bindingsets
2024-06-25 13:33:06 +02:00
Asger F
6e32f27652
Rename predicates to be consistent with qlpack
...
In preparation for migrating to the FlowSummary module in the qlpack,
rename predicates to be consistent with the qlpack.
2024-06-25 13:30:33 +02:00
Alvaro Muñoz
61797e9180
Add pull_request-comment-branch head_ref as a source
2024-06-25 13:27:08 +02:00
Asger F
6a3bb4dd28
Merge pull request #16834 from asgerf/shared/capture-this-location
...
Shared: add location for 'this' CaptureContainer
2024-06-25 13:18:41 +02:00
Mathias Vorreiter Pedersen
17edfdf801
Merge pull request #16833 from MathiasVP/simplify-incorrect-allocation-error-handling
...
C++: Simplify `cpp/incorrect-allocation-error-handling`
2024-06-25 12:16:21 +01:00
Asger F
6c8fb61f60
Js: Update FlowSummaryImpl.qll to make things compile
2024-06-25 13:10:24 +02:00
Asger F
64a9598b89
JS: Update interface for isUnreachableInCall
2024-06-25 13:01:23 +02:00
Asger F
505c532af7
JS: Implement totalorder()
2024-06-25 12:58:35 +02:00
Rasmus Lerchedahl Petersen
6524b8e25d
Python: consistent double quotes in examples
2024-06-25 12:11:52 +02:00
Rasmus Lerchedahl Petersen
09905ee228
Python: double back-tics
2024-06-25 12:05:38 +02:00
Rasmus Lerchedahl Petersen
6d4e993dea
Python: remove named parameter filename
2024-06-25 12:00:53 +02:00
Rasmus Lerchedahl Petersen
aa4fd1992e
Python: compact types in type models
2024-06-25 11:59:55 +02:00
Rasmus Lerchedahl Petersen
b902dd5680
Python: add change note
2024-06-25 11:54:30 +02:00
Asger F
102ca77acf
Switch to getLocation() in DataFlowCall
2024-06-25 11:49:19 +02:00
Asger F
ecf418b8f6
Merge branch 'main' into js/shared-dataflow
2024-06-25 11:48:41 +02:00
Arthur Baars
046a5f0881
Merge branch 'rc/3.14' into post-release-prep/codeql-cli-2.17.6
2024-06-25 11:43:38 +02:00
Arthur Baars
624c574559
Merge pull request #16831 from smowton/smowton/admin/backport-maven-regex-fix
...
Backport Maven regex fix to rc/3.14
2024-06-25 11:42:54 +02:00
Jeroen Ketema
e0e5bdec8a
Merge pull request #16818 from jketema/predef
...
C++: Update expected test results
2024-06-25 11:06:53 +02:00