Tony Torralba
30aa9b230c
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2022-12-20 14:14:05 +01:00
erik-krogh
57f429ec5d
change this = this to any()
2022-12-20 13:56:25 +01:00
Erik Krogh Kristensen
0cc3232c10
fix typo
...
Co-authored-by: Arthur Baars <aibaars@github.com >
2022-12-20 13:56:25 +01:00
erik-krogh
0a828f7b31
fix the left()/right() predicates such that they return an Either
2022-12-20 13:56:25 +01:00
erik-krogh
b1001d1a10
make TypeWithToString private inside the shared pack
2022-12-20 13:56:25 +01:00
erik-krogh
0e426090f2
update expected output
2022-12-20 13:56:23 +01:00
Jami
dc0bad3dc5
update change note
...
Co-authored-by: yo-h <55373593+yo-h@users.noreply.github.com >
2022-12-20 07:55:58 -05:00
erik-krogh
605bfd6e93
move the "I don't care about parent relation on mocks" hack into the predicate, so the tests dont fail
2022-12-20 13:55:49 +01:00
erik-krogh
54072d29f1
add explicit this
2022-12-20 13:55:49 +01:00
erik-krogh
49277f553f
model the last parts of the EquivalenceRelation module
2022-12-20 13:55:49 +01:00
erik-krogh
a11e618cfc
mock parameters
2022-12-20 13:55:49 +01:00
erik-krogh
4feb48ce5f
classless predicate, used to model the edgeSig predicate
2022-12-20 13:55:49 +01:00
erik-krogh
4dc52379ad
add a mock TypeExpr, and use it
2022-12-20 13:55:49 +01:00
erik-krogh
5db2f0aba0
mock classes, and add a Mock T class to QlBuiltins
2022-12-20 13:55:49 +01:00
erik-krogh
b7e0d1f8b3
don't include mock Ast nodes in PrintAst.ql
2022-12-20 13:55:49 +01:00
erik-krogh
51d5e881de
add an Ast mocking library, and use it to create mocks of the QlBuiltins and EquivalenceRelation modules
2022-12-20 13:55:48 +01:00
erik-krogh
0ca38faa4d
add test of buildins
2022-12-20 13:54:38 +01:00
erik-krogh
236e6db996
fix typos
2022-12-20 13:54:02 +01:00
erik-krogh
50a91b5017
shared: add a shared Either type
2022-12-20 13:54:02 +01:00
Erik Krogh Kristensen
073e9bc52f
Merge pull request #11173 from erik-krogh/notDead
...
QL: improve the dead-code query
2022-12-20 13:36:58 +01:00
Erik Krogh Kristensen
b1e6a86a4b
Merge pull request #11757 from erik-krogh/treesitter-qldoc
...
QL/RB: make top TreeSitter.qll comment into a qldoc
2022-12-20 13:36:31 +01:00
Rasmus Lerchedahl Petersen
f5e33ac00a
Merge remote-tracking branch 'origin/main' into python/support-grouped-exceptions
2022-12-20 13:31:50 +01:00
Erik Krogh Kristensen
b5b0a64081
Merge pull request #11751 from jacola/main
...
Fix javascript syntax
2022-12-20 13:02:23 +01:00
Rasmus Lerchedahl Petersen
ad6ed2f629
python: update expectations
...
extra tests
2022-12-20 13:01:27 +01:00
Erik Krogh Kristensen
6be223ad6d
Merge pull request #11756 from aibaars/fix-ql-module-parameter
...
QL: fix visibility of module parameters
2022-12-20 12:59:07 +01:00
erik-krogh
2ff23a6fc0
make top TreeSitter.qll comment into a qldoc
2022-12-20 11:39:06 +01:00
Arthur Baars
c8255770bc
QL: fix visibility of module parameters
2022-12-20 11:22:20 +01:00
Tony Torralba
149cae9603
Merge pull request #10971 from joefarebrother/android-certificate-pinning
...
Java: Add Android missing certificate pinning query (CWE-295)
2022-12-20 11:03:16 +01:00
Arthur Baars
bad5c65144
Add test
2022-12-20 10:37:57 +01:00
Mathias Vorreiter Pedersen
cbe330eb7b
Merge pull request #11693 from jketema/argv-param-flowsource
...
C++: Define the `argv` flow source in terms the input parameter
2022-12-20 09:30:19 +00:00
Tony Torralba
3e7a819fe7
Simplification
2022-12-20 09:42:25 +01:00
Jeroen Ketema
edc768b43b
Merge pull request #11707 from smowton/smowton/fix/java-empty-multiline-comment
...
Java: handle printing an empty comment (/**/); add relevant tests
2022-12-20 08:07:42 +01:00
Jacques
b99c500435
Fix associated test
2022-12-20 12:51:13 +09:00
Jacques
97b8126385
Fix javascript
2022-12-20 12:45:59 +09:00
Sid Shankar
52cafdf25f
Merge pull request #11745 from github/sidshank/remove-lgtm-for-go
2022-12-19 21:49:02 -05:00
Aditya Sharad
bcd711a708
Tutorial: Add separate QLDoc for Person class
...
By moving the existing doc comment to the top level,
that comment is shown when a user hovers over the module name
in `import tutorial`.
2022-12-19 15:54:12 -08:00
Aditya Sharad
ed29b3e4d6
Shared packs: Depend on codeql/tutorial from all language libraries
...
This allows `import tutorial` from queries targeting
any language, just like before, while removing the
duplicate copies of `tutorial.qll`.
2022-12-19 15:52:11 -08:00
Aditya Sharad
d772998bc7
Shared packs: Create codeql/tutorial library pack
...
This contains the QL detective tutorial library
in `tutorial.qll`, so that it can be shared by
all language libraries and referenced on its own.
2022-12-19 15:52:11 -08:00
Nora Dimitrijević
1c64bf4bbc
Swift: remove superfluous newline
2022-12-19 18:00:20 -05:00
Nora Dimitrijević
55c6e565f7
Swift: PrintAst.qll nodes() ordering fix not needed
...
No-double-parents should be sufficient for a stable top-level ordering.
2022-12-19 17:52:20 -05:00
Nora Dimitrijević
8b0da01e0d
Swift: allow self./super. sinks in StaticInitializationVector
...
Assumption: the extra path is not an issue in practice as the body of
the cryptographic library's init methods are not normally extracted,
only the stubs in this test are.
2022-12-19 17:39:44 -05:00
Nora Dimitrijević
3da54ebc61
Swift: give a clearer name to {Self,Super}RefExpr.getMethodDecl
2022-12-19 17:33:13 -05:00
Nora Dimitrijević
56a72d7c37
Swift: silence QL-for-QL "Redundant override" FP
2022-12-19 16:45:31 -05:00
Sid Shankar
ae3e25786f
Remove LGTM references from README.md + cleanup
2022-12-19 20:51:01 +00:00
Sid Shankar
35000e5d7e
Remove LGTM reference from CONTRIBUTING.md
2022-12-19 20:12:23 +00:00
Jami Cogswell
19deb59d07
Java: sort neutral models alphabetically
2022-12-19 14:22:17 -05:00
Calum Grant
cfd79e2006
Py: Put in commented-out test and update expected
2022-12-19 17:29:48 +00:00
Calum Grant
e982e144a4
JS: Update qltest output
2022-12-19 17:22:51 +00:00
Tony Torralba
a47ef17a0d
Update java/ql/src/Security/CWE/CWE-295/AndroidMissingCertificatePinning1.java
...
Co-authored-by: Edward Minnix III <egregius313@github.com >
2022-12-19 18:11:54 +01:00
Chris Smowton
ebc0b0c4d6
Merge pull request #11665 from smowton/smowton/admin/revert-kotlin-default-method-type-erasure
...
Kotlin: Revert type erasure within $default functions
2022-12-19 16:33:20 +00:00
