Ahmed Farid
23bd53a325
Update zipslip_good.py
2022-03-08 23:55:17 +01:00
Dave Bartolomeo
09a5fded1c
Clean up SemanticCFG
2022-03-08 17:36:13 -05:00
Dave Bartolomeo
04fae43734
Minimize language-specific code for sign analysis
2022-03-08 17:13:06 -05:00
Tom Hvitved
f5fbf50d7d
Ruby: Fix incorrect parsing of ranges
2022-03-08 19:53:17 +01:00
Tom Hvitved
89c3d0535a
Ruby: Add regex test that outputs all RegExpTerms
2022-03-08 19:53:17 +01:00
Tom Hvitved
073302f196
Ruby: Add another regex consistency test
2022-03-08 19:53:17 +01:00
Tom Hvitved
a70ed71c01
Merge pull request #8370 from hvitved/ruby/regex-group-name-off-by-one
...
Ruby: Fix off-by-one error in `getGroupName`
2022-03-08 19:52:32 +01:00
jorgectf
3f43e6ef54
Fix FlaskMail's getTo
2022-03-08 18:45:53 +01:00
jorgectf
bbba1a21c4
Explicitly call this in SendGridMail
2022-03-08 18:40:20 +01:00
jorgectf
930fbf777c
Move getFlaskMailArgument inside FlaskMail and refactor
2022-03-08 18:38:32 +01:00
jorgectf
6b04344655
Refactor sendgridContent and sendgridWrite
...
Move the predicates inside `SendGridMail`.
See https://github.com/github/codeql/pull/7127#discussion_r821574462
2022-03-08 18:26:20 +01:00
jorgectf
6722671541
Refactor sendgridApiClient and sendgridApiSendCall
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2022-03-08 18:24:38 +01:00
Chris Smowton
e8084233b8
Treat path.Clean and filepath.Clean alike re: tainted path sanitization
2022-03-08 16:42:59 +00:00
Geoffrey White
9ebdb2ac1d
C++: QLDoc.
2022-03-08 16:12:58 +00:00
Tom Hvitved
5f48cc06bb
Ruby: Fix off-by-one error in getGroupName
2022-03-08 15:59:47 +01:00
Tom Hvitved
6dd126b6e3
Ruby: Add regex group tests
2022-03-08 15:59:28 +01:00
Mathias Vorreiter Pedersen
d8bad778ed
C++: Fix QLDoc
2022-03-08 14:38:39 +00:00
Tom Hvitved
86121164c5
Merge pull request #8364 from hvitved/ruby/fix-regex-parse
...
Ruby: Fix regex parsing of `/[|]/`
2022-03-08 15:26:29 +01:00
Taus
063a8bbc43
Python: Apply suggestions from code review
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2022-03-08 15:20:35 +01:00
Michael Nebel
ec75bbc748
Merge pull request #8203 from michaelnebel/csharp/extractor-option-buildless
...
C#: Refactoring - Move some of the standalone extractor code to the Standalone project.
2022-03-08 14:32:59 +01:00
Mathias Vorreiter Pedersen
69417e150a
C++: Address review comments.
2022-03-08 13:15:02 +00:00
Mathias Vorreiter Pedersen
1bf430529b
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/MustFlow.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2022-03-08 13:07:17 +00:00
Mathias Vorreiter Pedersen
edf629f5aa
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/MustFlow.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2022-03-08 13:07:09 +00:00
Mathias Vorreiter Pedersen
bfa0714577
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/MustFlow.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2022-03-08 13:06:53 +00:00
Mathias Vorreiter Pedersen
9e7b0925c6
Merge pull request #8366 from jketema/code-duplication-deprecated
...
C++: Mark everything in CodeDuplication.qll as deprecated
2022-03-08 12:47:50 +00:00
Jeroen Ketema
3877598c12
C++: Remove cpp/duplicated-lines-in-files which was deprecated over a year ago
2022-03-08 12:58:19 +01:00
Mathias Vorreiter Pedersen
7106fe35aa
C++: Accept test changes. This is just a change in the names of the path nodes. These names are actually better as they don't refer to the name of IR instructions.
2022-03-08 11:40:56 +00:00
Mathias Vorreiter Pedersen
8c5b3368e1
C++: Make the two must-flow queries use the new must-flow library
2022-03-08 11:40:56 +00:00
Mathias Vorreiter Pedersen
ee9c0dcb83
C++: Add library for must-flow.
2022-03-08 11:40:56 +00:00
Jeroen Ketema
b039b91fd8
C++: Add change note
2022-03-08 12:36:11 +01:00
Jeroen Ketema
df1e810f13
C++: Remove duplicate code queries that were deprecated over a year ago
2022-03-08 12:28:41 +01:00
Jeroen Ketema
d2e2866276
C++: Also deprecate TDuplicationOrSimilarity
2022-03-08 12:26:07 +01:00
Arthur Baars
6aacc75a49
CI: add QLdoc test
2022-03-08 12:07:20 +01:00
Jeroen Ketema
55351ce835
Update cpp/ql/src/external/CodeDuplication.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2022-03-08 11:57:05 +01:00
Jeroen Ketema
2e73e35747
Update cpp/ql/src/external/CodeDuplication.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2022-03-08 11:56:55 +01:00
Jeroen Ketema
81783e828e
C++: Mark everything in CodeDuplication.qll as deprecated
...
Although we earlier added a comment to the classes in noting that
they are deprecated, we did not properly mark the classes as actually
being deprecated.
All predicates - except for 3 - depend on the classes being functional,
which they no longer are, so mark those a deprecated as well. The three
remaining predicates (`FunctionDeclarationEntry`, `numberOfSourceMethods`,
and `whitelistedLineForDuplication`) seem to be helpers, and are likely
not used when the library is not used, so mark those as deprecated as
well.
2022-03-08 11:38:01 +01:00
Erik Krogh Kristensen
4734f1916e
Merge pull request #7598 from erik-krogh/fieldOnlyUsedInCharPred
...
QL: field only used in charPred
2022-03-08 11:25:57 +01:00
Rasmus Wriedt Larsen
6b14c1d6b9
Merge branch 'main' into jorgectf/python/deserialization
2022-03-08 11:15:03 +01:00
Rasmus Wriedt Larsen
cbe3964a87
Merge pull request #8275 from haby0/py/add-ssrf-sinks
...
Python: Add Server-side Request Forgery sinks
2022-03-08 11:06:52 +01:00
Tom Hvitved
3bc8d0878f
Ruby: Add regex consistency queries
2022-03-08 10:10:14 +01:00
Tom Hvitved
6d4eecff14
Ruby: Fix regex parsing of /[|]/
2022-03-08 09:52:06 +01:00
Tom Hvitved
a7442b7a2b
Ruby: Add regex test case for /[|]/
2022-03-08 09:51:39 +01:00
ihsinme
8335778e20
Update ImproperCheckReturnValueScanf.qhelp
2022-03-08 07:45:07 +03:00
ihsinme
c0c7748c5e
Apply suggestions from code review
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2022-03-08 07:42:35 +03:00
Jonathan Leitschuh
2e8b5f743b
[Java] Add CompileTimeConstantExpr.getStringified method
...
Removes CharacterLiteral from CompileTimeConstantExpr.getStringValue
Resolves:
- https://github.com/github/codeql/pull/8325#issuecomment-1060470279
- https://github.com/github/codeql/pull/8325#issuecomment-1060587205
2022-03-07 20:11:38 -05:00
Jonathan Leitschuh
a21992ade9
Minor refactoring to improve tests and documentation
2022-03-07 18:40:53 -05:00
Jonathan Leitschuh
5b651f29d8
Fix insufficient tests and add documentation
2022-03-07 16:39:40 -05:00
Taus
5a8ba6a7af
Python: Fix use of singleton set
2022-03-07 18:59:49 +00:00
Taus
d2603884ca
Python: Fix a bunch of class QLDoc
2022-03-07 18:59:49 +00:00
Taus
af7f532212
Python: Fix up a bunch of function QLDoc
2022-03-07 18:59:49 +00:00