tiferet
4580b55673
Oops -- forgot to stage one file in the previous commit :)
2022-11-28 11:34:34 -08:00
tiferet
210644e87d
Delete StandardEndpointFilters.
...
All remaining functionality in `StandardEndpointFilters` is only being used in `EndpointCharacteristics`, so it can be moved there as a small set of helper predicates.
2022-11-28 11:34:34 -08:00
tiferet
15121931b4
Delete CoreKnowledge.
...
All remaining functionality in `CoreKnowledge` is only being used in `EndpointCharacteristics`, so it can be moved there as a small set of helper predicates.
2022-11-28 11:34:34 -08:00
tiferet
1c679378e7
FilteringReason is no longer being used and can be deleted
2022-11-28 11:34:33 -08:00
tiferet
99de397a5f
Remove redundant code
...
`isOtherModeledArgument` and `isArgumentToBuiltinFunction` contained the old logic for selecting negative endpoints for training.
These can now be deleted, and replaced by a single base class that collects all EndpointCharacteristics that are currently used to indicate negative training samples: `OtherModeledArgumentCharacteristic`.
This in turn lets us delete code from `StandardEndpointFilters` that effectively said that endpoints that are high-confidence non-sinks shouldn't be scored at inference time, either.
2022-11-28 11:34:33 -08:00
tiferet
7b0269c999
Fix British spelling that code scanning didn't like.
...
I've been working with Brits for too long :)
2022-11-28 11:28:08 -08:00
tiferet
963407de4c
Update the documentation
2022-11-28 11:16:06 -08:00
Asger F
76afc2dcc3
JS: Fix formatting and rephrase comment
2022-11-28 14:00:43 +01:00
Erik Krogh Kristensen
7a3898168f
Update README.md
2022-11-28 12:12:36 +01:00
Asger F
e99571baae
Update javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll
...
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com >
2022-11-28 11:45:08 +01:00
Henry Mercer
56e5f01ce0
Merge branch 'main' into codeql-ci/atm/release-0.4.2
2022-11-24 14:41:49 +00:00
github-actions[bot]
78d49e44b1
JS: Bump version of ML-powered library and query packs to 0.4.3
2022-11-24 14:22:14 +00:00
github-actions[bot]
8d96bfe973
JS: Bump patch version of ML-powered library and query packs
2022-11-24 14:18:13 +00:00
Erik Krogh Kristensen
1eec067474
Merge pull request #11294 from erik-krogh/fileDoc
...
QL: improve the "this block-comment should have been a QLDoc"-query
2022-11-23 22:23:36 +01:00
Erik Krogh Kristensen
efdfc361be
Merge pull request #11396 from erik-krogh/jsTypo
...
JS: fix two typos
2022-11-23 22:18:43 +01:00
tiferet
03b8e649f1
Filter endpoints by confidence
...
Select endpoints to score at inference time base purely on their confidence level, and not on whether they fit the historical definition of endpoint filters.
2022-11-23 10:46:27 -08:00
Asger F
5a51d718c6
Update some comments referring to the package column
2022-11-23 14:44:03 +01:00
erik-krogh
2eb6b1adb3
JS: fix two typos
2022-11-23 14:38:12 +01:00
Henry Mercer
3b69821630
ATM: Add descriptions to ML-powered packs
2022-11-23 10:46:23 +00:00
Asger F
2e3413c9b8
JS: Merge package/type columns
2022-11-23 11:17:42 +01:00
Erik Krogh Kristensen
f67219965e
Merge pull request #11082 from erik-krogh/shellArr
...
JS: treat arrays that gets executed with shell:true as a sink for `js/shell-command-constructed-from-input`
2022-11-22 13:03:50 +01:00
Erik Krogh Kristensen
b2267c0e49
Merge pull request #11343 from erik-krogh/redundantAssignment
...
QL: add redundant-assignment query
2022-11-22 13:03:14 +01:00
Erik Krogh Kristensen
06386b2cdd
Merge pull request #11072 from erik-krogh/slicing
...
JS: poly-redos: don't sanitize calls through substring calls that just remove the start
2022-11-22 13:02:09 +01:00
erik-krogh
6b5cd9abc3
use RegExpTreeView insteaed of RegexTreeView in JS
2022-11-22 12:55:48 +01:00
erik-krogh
f9b775e4b8
do private imports of the deprecated Dep modules
2022-11-22 12:39:56 +01:00
Edoardo Pirovano
6c33ddcd47
Merge pull request #11349 from github/edoardo/2.11.4-mergeback
...
Merge `rc/3.8` into `main`
2022-11-21 18:08:27 +00:00
erik-krogh
64707f4f7b
remove redundant assignments
2022-11-21 17:45:05 +01:00
tiferet
1c9545e49a
Address comment from code review:
...
Make `SyntacticHeuristics` an explicit import
2022-11-21 08:00:31 -08:00
tiferet
8d22fd25f1
Suggestions from code review
2022-11-18 15:57:46 -08:00
github-actions[bot]
5b14ebf22a
Post-release preparation for codeql-cli-2.11.4
2022-11-18 11:26:00 +00:00
erik-krogh
ba2734909f
JS: don't use deprecated files in tests
2022-11-17 22:12:50 +01:00
erik-krogh
3635db8244
JS: delete the deprecated [queryName].qll files
2022-11-17 22:12:50 +01:00
erik-krogh
635b8772d7
JS: delete old deprecations
2022-11-17 22:12:50 +01:00
Chris Smowton
0219c2b02b
Copyedit Javascript changelog
2022-11-17 17:02:01 +00:00
Chris Smowton
80b2f0d3cd
Coopyedit Javascript changelog
2022-11-17 17:01:43 +00:00
github-actions[bot]
e105c13e77
Release preparation for version 2.11.4
2022-11-17 16:40:45 +00:00
Mauro Baluda
a7dc29bad4
Merge branch 'main' into main
2022-11-16 23:53:16 +01:00
Mauro Baluda
49f476d3b4
Update javascript/ql/lib/semmle/javascript/frameworks/Hapi.qll
...
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com >
2022-11-16 23:53:07 +01:00
tiferet
4a1382925e
Remove some imports that are no longer used
2022-11-16 14:01:16 -08:00
tiferet
ccbf1ca2a9
Add a comment
2022-11-16 13:05:06 -08:00
tiferet
38c40a7192
isEffectiveSink can't be final because ExtractMisclassifiedEndpointFeatures overrides it.
2022-11-16 12:12:50 -08:00
tiferet
8fee9cb0d5
Fix CodeQL warnings
2022-11-16 12:06:52 -08:00
tiferet
c2035e85d2
Be explicit in requiring that each ATM config set its endpoint type.
2022-11-16 11:55:23 -08:00
tiferet
0fd013f9fd
Update the reason names in FilteredTruePositives.expected.
...
This is needed because we changed the names of three endpoint filters that were all called "not a direct argument to a likely external library call or a heuristic sink" in order to disambiguate them (fc56c5a022 ).
2022-11-16 11:54:10 -08:00
tiferet
eab270eb84
Move the definitions of isEffectiveSink and getAReasonSinkExcluded to the base class.
...
They can now be implemented generically for all sink types.
2022-11-16 11:47:24 -08:00
tiferet
fc56c5a022
Implement the type-specific endpoint filters as EndpointCharacteristics.
...
Also disambiguate three filters from three different sink types that all have the same name, "not a direct argument to a likely external library call or a heuristic sink".
2022-11-16 11:14:25 -08:00
erik-krogh
76c6943159
add stats for @satisfies_expr
2022-11-16 13:48:41 +01:00
erik-krogh
fe49e41d7b
JS: convert some block-comments that could be QLDoc to QLDoc
2022-11-16 13:45:35 +01:00
erik-krogh
9eaeaf7322
ATM: convert some block-comments that could be QLDoc to QLDoc
2022-11-16 13:41:52 +01:00
Mauro Baluda
8bf0bbb715
code generalization
...
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com >
2022-11-16 12:06:23 +01:00