Jami Cogswell
d07babe3c5
add initial framework for service and receiver test cases
2022-10-04 12:33:23 +02:00
Jami Cogswell
6cf3898101
add experimental global flow config, and clean-up some code
2022-10-04 12:33:23 +02:00
Jami Cogswell
9947b32446
resolve merge conflict
2022-10-04 12:33:23 +02:00
Jami Cogswell
11ce910c38
resolved merge conflict in FlowSources
2022-10-04 12:33:23 +02:00
Jami Cogswell
7576047214
create simple query and initial experimentation
2022-10-04 12:33:23 +02:00
Tony Torralba
9db65eae7f
Address review comments
2022-10-04 12:27:01 +02:00
Tony Torralba
b8fa9433be
Fix duplicated test
2022-10-04 12:27:01 +02:00
Tony Torralba
264d6db9d7
Rename AllowListGuard to AllowedPrefixGuard
2022-10-04 12:27:01 +02:00
Tony Torralba
90020b6aab
Make block lists work with substring matching too
...
A block list approach doesn't need to restrict itself to prefix matching
2022-10-04 12:27:01 +02:00
Tony Torralba
69d1895175
Update java/ql/lib/semmle/code/java/security/PathSanitizer.qll
2022-10-04 12:27:01 +02:00
Tony Torralba
6fcaae20e7
Add tests and fix bugs highlighted by them
2022-10-04 12:27:01 +02:00
Tony Torralba
f19eb783be
Generalize file/path taint steps
...
This is needed by PathSanitizer but also helps simplify ZipSlip.ql
2022-10-04 12:27:01 +02:00
Tony Torralba
4e29c39c78
Merge ZipSlip sanitization logic into PathSanitizer.qll
...
Apply code review suggestions regarding weak sanitizers
2022-10-04 12:27:01 +02:00
Tony Torralba
89d905cc03
Add change note
2022-10-04 12:27:01 +02:00
Tony Torralba
08c67fb174
Use PathInjectionSanitizer in relevant queries
2022-10-04 12:27:01 +02:00
Tony Torralba
dff878e531
Apply TaintedPath recent changes to TaintedPathLocal
2022-10-04 12:26:59 +02:00
Tony Torralba
5706e8b377
Improve PathSanitizer
...
Rename PathTraversalSanitizer to PathInjectionSanitizer
2022-10-04 12:26:17 +02:00
Tony Torralba
50ad234694
Move PathSanitizer to the main library
2022-10-04 12:26:17 +02:00
Tony Torralba
d5478a01ab
Merge pull request #10671 from github/revert-10640-atorralba/fix-cartesian-product
...
Java: Revert #10489 and #10640
2022-10-04 12:25:46 +02:00
Chris Smowton
e29be411ef
Merge pull request #9811 from smowton/smowton/feature/kotlin-jvmoverloads-annotation
...
Kotlin: Implement JvmOverloads annotation
2022-10-04 11:21:44 +01:00
Tony Torralba
2deb3e5625
Reapply "Java: Fix cartesian product"
...
This reverts commit c1654ce7cc
2022-10-04 11:11:44 +02:00
Tony Torralba
281e49daf7
Revert "Java: Add CompilationUnit.getATypeAvailableBySimpleName()"
...
This reverts commit 431aa2cb79
2022-10-04 10:59:45 +02:00
Tony Torralba
01b950f68b
Revert "Java: Rename predicate to getATypeInScope"
...
This reverts commit fd99ae78b3
2022-10-04 10:59:43 +02:00
Tony Torralba
df29e05b9f
Revert "Java: Adjust ImpossibleJavadocThrows.ql"
...
This reverts commit c40b6285a2
2022-10-04 10:59:39 +02:00
Tony Torralba
c1654ce7cc
Revert "Java: Fix cartesian product"
2022-10-04 10:56:32 +02:00
Tamas Vajk
2c467376ea
Revert "Only log once the missing java-kotlin method mapping warnings"
...
This reverts commit 7524f3372d
2022-10-04 08:54:07 +02:00
Dilan Bhalla
bff2633f8d
java guidance: experimental version of exectainted
2022-10-03 11:18:17 -07:00
Ed Minnix
c6f91500f0
Update query description to better describe issue
2022-10-03 13:12:53 -04:00
Ed Minnix
52d519765a
Merge ContentProvider tests into one manifest
...
Merge the read-only, write-only, read-write, and full test cases into
one AndroidManifest.xml file.
Also added the not-exported test case.
2022-10-03 12:16:45 -04:00
Ed Minnix
09077935b1
Added query change note
2022-10-03 11:30:43 -04:00
Edward Minnix III
071f082b64
Add mention of content provider in query description
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2022-10-03 11:21:33 -04:00
Edward Minnix III
2970e8c76a
Remove redundant documentation
...
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com >
2022-10-03 11:21:02 -04:00
Edward Minnix III
cfc0bb595f
Documentation fix for hasIncompletePermissions
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2022-10-03 11:20:15 -04:00
Ian Lynagh
01fe465bdf
Kotlin: Make MiniStdLib more closely match the real stdlib
2022-10-03 16:16:11 +01:00
Ed Minnix
28e7049722
Add exported requirement to ContentProvider permissions test
2022-10-03 10:52:42 -04:00
Chris Smowton
5e2c607650
PrintAst: reliably sort function overloads
2022-10-03 15:28:55 +01:00
Chris Smowton
d3d3ce843a
Kotlin: Implement JvmOverloads annotation
...
This generates functions that omit parameters with default values, rightmost first, such that Java can achieve a similar experience to Kotlin (which represents calls internally as if the default was supplied explicitly, and/or uses a $default method that supplies the needed arguments).
A complication: combining JvmOverloads with JvmStatic means that both the companion object and the surrounding class get overloads.
2022-10-03 15:28:55 +01:00
Tony Torralba
ba9eb8c73c
Fix stub generator
...
Add line break after all stubbed annotations to avoid malformed code
See https://github.com/github/codeql/pull/8695\#discussion_r985674245
2022-10-03 14:43:58 +02:00
Tamas Vajk
90b28f04d8
Accept integration test changes
2022-10-03 12:10:08 +02:00
Tamas Vajk
7524f3372d
Only log once the missing java-kotlin method mapping warnings
2022-10-03 11:55:39 +02:00
Tony Torralba
f860ae8c82
Apply review suggestions
2022-10-03 10:38:35 +02:00
Tony Torralba
2036453176
Add stub generation tests
2022-10-03 10:31:14 +02:00
Tony Torralba
0645f62a0d
Use monotonicAggregates to avoid non-monotonic recursions
2022-10-03 10:31:14 +02:00
Tony Torralba
66e6f4d25e
Use empty string as default value for string annotation values
2022-10-03 10:31:14 +02:00
Tony Torralba
8a3ed6bdcf
Apply code review suggestions
2022-10-03 10:31:14 +02:00
Tony Torralba
6f7b7c9efe
If an annotation value is an array, order its elements by index
2022-10-03 10:31:14 +02:00
Tony Torralba
6f1124d7e7
Handle more annotation element value types
2022-10-03 10:31:13 +02:00
Tony Torralba
1ece12efd7
Add annotation element names
2022-10-03 10:31:13 +02:00
Tony Torralba
d4499a10d2
Fix typo
2022-10-03 10:31:13 +02:00
Tony Torralba
ee7507386c
Fix annotation vs interface keyword stubbing
2022-10-03 10:31:13 +02:00
