Owen Mansel-Chan
5ec3934ac8
Merge branch 'main' into go/extractor/no-intermediate-string-values
2024-04-10 14:51:22 +01:00
Owen Mansel-Chan
b4829addf7
Add comments with link to online doc
2024-04-10 10:48:23 +01:00
Owen Mansel-Chan
32ea94e625
Merge pull request #16123 from owen-mc/go/misc-trivial-fixes
...
Go: miscellaneous trivial fixes
2024-04-04 21:09:15 +01:00
Owen Mansel-Chan
7fc5265168
Misc small tidy-ups mostly suggested by linter
2024-04-04 10:51:22 +01:00
Owen Mansel-Chan
68321dd9ec
Use nil for optional argument to packages.Visit
2024-04-04 10:51:13 +01:00
Owen Mansel-Chan
d9fe39d5ae
Extractor: add comment about tw.Package.TypesInfo.Defs
2024-04-04 10:37:31 +01:00
Owen Mansel-Chan
698debfa20
Extractor: explicitly deal with extracting x.(type) in type switches
2024-04-03 13:58:58 +01:00
Michael B. Gale
06134467e9
Go: Make CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO true by default
2024-03-20 12:01:49 +00:00
Owen Mansel-Chan
da8cc13506
go extractor: avoid long string concatenations
...
When we see "a" + "b" + "c" + "d", do not add a
row to the constvalues table for the intermiediate
strings "ab" and "abc". We still have entries for
the string literals ("a", "b", "c", and "d") and
the whole string concatenation ("abcd").
2024-03-11 10:53:26 +00:00
Michael B. Gale
be521508c2
Go: Do not add dummy files to CompilationCompilingFilesTable
2024-02-13 14:21:07 +00:00
Michael B. Gale
5e08bf0dbf
Go: Add missing call to extractFileInfo
2024-02-13 14:20:45 +00:00
Michael B. Gale
3b708993c7
Go: Add diagnostic for 1.21 toolchain error
2023-09-07 11:51:20 +01:00
Owen Mansel-Chan
a7469ce4f1
Use Origin()
2023-07-17 16:11:25 +01:00
Owen Mansel-Chan
a2a2e93cfd
Fix printing when one obj is nil
2023-07-15 07:06:16 +01:00
Owen Mansel-Chan
cff09d28b8
Test if Origin() works (for Var and Func)
2023-07-14 13:52:50 +01:00
Owen Mansel-Chan
5e87111a8b
Stop using deprecate io/ioutil package
2023-05-02 14:15:02 +01:00
Owen Mansel-Chan
820de5d36f
Remove fatal/panic exits from diagnostic code
2023-03-08 22:00:34 +00:00
Owen Mansel-Chan
05a4fdf6d8
Put all package-not-found errors into one diagnostic
2023-03-07 16:38:52 +00:00
Owen Mansel-Chan
a7a10de9ea
Emit diagnostic to pass fourth integration tests
2023-03-07 16:38:51 +00:00
Owen Mansel-Chan
2a41e6ae66
Emit diagnostic to pass third inegration tests
2023-03-07 16:38:49 +00:00
Owen Mansel-Chan
cbb2fb9968
Emit diagnostic to pass first integration test
2023-03-07 16:38:47 +00:00
Gustav Munkby
b4382855fa
Fallback to package dir for discovering go.mod
...
This reverts to the old behavior of reusing the package directory when looking for go.mod. It seems unlikely that this is the right thing to do since we failed to find the module directory, but this behavior should be consistent with what we had before.
2022-12-01 15:43:51 +01:00
Gustav Munkby
a293239bd5
Accelerating go-extractor by using 'go list -deps'
...
Resurrect https://github.com/github/codeql-go/pull/554 , but behind an environment variable as to avoid the broken builds noted in https://github.com/github/codeql/issues/9304 , but still allowing some people to opt in to the much faster approach.
2022-11-15 10:30:56 +01:00
Gustav Munkby
279ba60eb1
Refactor package path extraction
...
In preparation for pulling all package information at once.
2022-11-15 10:10:39 +01:00
Chuan-kai Lin
aa514fff32
codeql-go merge prep: move into go/ directory
2022-05-20 10:07:19 -07:00