Asger Feldthaus
d55d5cc4ed
JS: Address comments from doc review
2020-01-07 10:27:46 +00:00
Asger Feldthaus
9f6e04887b
JS: Fix FP from word boundaries
2020-01-07 10:09:17 +00:00
Asger F
b604be5cfb
Apply suggestions from code review
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2020-01-06 14:44:02 +00:00
Asger F
9928762769
JS: Add RegExpAlwaysMatches query
2020-01-06 13:48:02 +00:00
semmle-qlci
48deb30756
Merge pull request #2573 from max-schaefer/js/generalise-alert-suppression
...
Approved by asgerf
2020-01-06 10:43:17 +00:00
semmle-qlci
5dcc5b3b1e
Merge pull request #2581 from erik-krogh/FlowUselessExpr
...
Approved by max-schaefer
2020-01-06 08:33:36 +00:00
semmle-qlci
06d812a6ff
Merge pull request #2556 from erik-krogh/RegexpVoidCxt
...
Approved by max-schaefer
2020-01-03 08:38:56 +00:00
Max Schaefer
8d1ad5c5f3
JavaScript: Alert suppression through single-line /* */ style comments.
2020-01-02 10:45:20 +00:00
Erik Krogh Kristensen
d1a77d6993
refactor isInterpretedAsRegExp to directly work on a DataFlow node
2020-01-02 11:18:14 +01:00
semmle-qlci
f921cf7d01
Merge pull request #2512 from erik-krogh/moarExceptions
...
Approved by esbena, max-schaefer
2019-12-20 20:31:50 +00:00
Erik Krogh Kristensen
a0b5aa5ae4
more precise heuristic to identify allowed call targets
2019-12-20 10:51:39 +01:00
Erik Krogh Kristensen
15d74b7d03
remove FP from js/regexpinjection where no regexp was constructed
2019-12-19 10:47:03 +01:00
Tom Hvitved
29cd6a9e30
Sync XML.qll
2019-12-19 10:29:30 +01:00
Erik Krogh Kristensen
f140820511
fix FP related to block-level flow type annotations
2019-12-17 16:10:20 +01:00
Erik Krogh Kristensen
9dd7d1c6d7
changes based on review feedback
2019-12-17 13:19:53 +01:00
Erik Krogh Kristensen
f9ddd5891a
minor documentation fixes
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2019-12-17 13:05:20 +01:00
Max Schaefer
09ee106333
Java/JavaScript: Add two deprecated predicates to XML.qll.
...
This makes XML.qll identical across C++, Java, JavaScript and Python.
2019-12-17 10:15:43 +00:00
Max Schaefer
923e36ba4f
C++/Java/JavaScript/Python: Make qldoc consistent.
2019-12-17 10:15:43 +00:00
Max Schaefer
a2fe678464
C++/Java/JavaScript/Python: Unify imports in XML.qll.
2019-12-17 10:15:43 +00:00
Erik Krogh Kristensen
8f17db6670
changes based on review feedback
2019-12-16 14:43:29 +01:00
Erik Krogh Kristensen
7c931452d9
autoformat
2019-12-16 13:45:42 +01:00
Erik Krogh Kristensen
3ca3fa7e9e
add quotes on code in documentation
...
Co-Authored-By: Esben Sparre Andreasen <esbena@github.com >
2019-12-16 13:32:01 +01:00
Erik Krogh Kristensen
8c0b6f26da
Merge remote-tracking branch 'upstream/master' into moarExceptions
2019-12-16 08:35:45 +01:00
Erik Krogh Kristensen
1efe2ba167
inline ifStmt field
2019-12-13 19:00:54 +01:00
Erik Krogh Kristensen
3b2cc4674e
autoformat
2019-12-13 11:44:52 +01:00
Erik Krogh Kristensen
e164f46330
changes based on review feedback
2019-12-13 11:44:31 +01:00
Erik Krogh Kristensen
f35dc5d274
Merge remote-tracking branch 'upstream/master' into moarExceptions
2019-12-12 16:13:52 +01:00
Erik Krogh Kristensen
17358606cb
change callback to rely on an behavior heuristic rather than a naming heuristic
2019-12-12 16:12:37 +01:00
Erik Krogh Kristensen
08d0cb795b
revert the introduction of getEnclosingCall
2019-12-12 15:14:02 +01:00
Max Schaefer
dfeca63677
JavaScript: Fix characteristic predicate of XMLParent.
...
The database type `@xmlparent` is defined a bit too loosely in that it includes all of `@file`, not just XML files. Fixing that would involve fiddling with the extractor/dbscheme, so I have opted to fix it at the QL level instead.
2019-12-12 12:38:29 +00:00
Erik Krogh Kristensen
f537e28389
add pragma to internalBlocks predicate to fix performance
2019-12-11 15:19:30 +01:00
Erik Krogh Kristensen
62512dd3e9
expand the js/exception-xss to handle more types of exceptional flow
2019-12-11 10:43:50 +01:00
Asger F
abec4badb5
Apply suggestions from code review
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2019-12-06 11:53:09 +00:00
Asger F
344f0b4995
Fix typo in qldoc
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2019-12-06 11:53:09 +00:00
Asger F
c1da83bf6c
Fix typo in qldoc
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2019-12-06 11:53:09 +00:00
Asger F
2acd616e6f
JS: Review comments
2019-12-06 11:53:06 +00:00
Asger F
a6e75259d6
JS: More fine-grained regexp-based sanitizer guards
2019-12-06 11:49:59 +00:00
Asger F
ad6e949bad
JS: Introduce RegExpCreationNode
2019-12-06 11:49:59 +00:00
Asger F
4354945c26
JS: Factor out recognition of RegExp flags
2019-12-06 11:49:59 +00:00
semmle-qlci
cfcd18b411
Merge pull request #2429 from erik-krogh/typeAheadSink
...
Approved by esbena
2019-12-03 08:07:25 +00:00
Asger F
f162749044
Merge pull request #2418 from max-schaefer/js/file-locatable
...
JavaScript: Make `File` not extend `Locatable` anymore.
2019-12-02 16:15:14 +00:00
Max Schaefer
ec2ba735de
JavaScript: Update Dependencies library to not rely on Files being Locatable.
...
Previously, we would consider an HTML file to be a dependent of all scripts embedded in it. Now we instead consider each JavaScript toplevel inside the HTML file to be a dependent, which is more sensible anyway.
2019-12-02 12:40:49 +00:00
Nick Rolfe
d293418672
Merge pull request #2478 from jbj/mergeback-20191202
...
Mergeback from rc/1.23 to master
2019-12-02 12:28:20 +00:00
semmle-qlci
ceb9fff70c
Merge pull request #2479 from max-schaefer/localTaintStep
...
Approved by asgerf
2019-12-02 11:35:43 +00:00
Max Schaefer
aeda2d68f8
JavaScript: Introduce localTaintStep predicate.
...
It's sometimes useful for exploratory queries, and the other languages have it as well.
2019-12-02 09:43:08 +00:00
Jonas Jensen
5b24b1efc3
Merge remote-tracking branch 'upstream/rc/1.23' into mergeback-20191202
...
Conflicts solved:
javascript/extractor/src/com/semmle/js/extractor/Main.java
javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/tst.js
2019-12-02 09:57:34 +01:00
Erik Krogh Kristensen
c6c1ebe81a
Merge remote-tracking branch 'upstream/master' into typeAheadSink
2019-12-02 08:41:49 +01:00
Max Schaefer
f958916c76
Merge pull request #2330 from erik-krogh/exceptionXss
...
JS: Added query for detecting XSS that happens through an exception
2019-11-29 09:04:45 +00:00
semmle-qlci
73e08eba43
Merge pull request #2468 from max-schaefer/js/regexp-predecessor
...
Approved by asgerf
2019-11-28 16:57:31 +00:00
Max Schaefer
7487c79271
JavaScript: Add missing qldoc.
2019-11-28 15:54:52 +00:00