Chris Smowton
d37a10e4f1
Accept test changes: methods no longer appearing to be final
...
This is actually a bug, which we should follow up on subsequently.
2022-12-06 18:38:31 +00:00
Chris Smowton
59eb81b50a
Accept test changes: a raw class getting extracted solely for use in a signature
...
We could revert this by allowing useType to avoid triggering class-instance extraction when used just for its signature result
2022-12-06 18:35:04 +00:00
Chris Smowton
f5579d59f8
Accept test changes: classes no longer getting multiple locations
2022-12-06 18:35:04 +00:00
Chris Smowton
9f722a7e12
Disable java_and_kotlin inconsistency test; accept changes
...
This was testing that a signature inconsistency occurs, but this now manifests as a db inconsistency which can't be used as a test expectation because specific tuple numbers are liable to change with the environment.
2022-12-06 18:35:04 +00:00
Chris Smowton
f2fded6486
Accept jvmstatic-annotation changes
...
These occur because the Companion field is odd, being extracted from source but not having an associated FieldDeclaration, leading to PrintAst enumerating the node differently depending on whether it has a source-file location or not but in either case choosing not to show it.
2022-12-06 18:35:04 +00:00
Chris Smowton
5e023bf619
Remove no-longer-applicable diagnostic matches
...
These resulted from the Java compiler exploring NotNull and other Kotlin-emitted annotations, which it no longer does because it finds a .class trap file already present and truncates its class-graph walk
2022-12-06 18:35:04 +00:00
Chris Smowton
82f3c2f6d5
Mark the Companion field as static
2022-12-06 18:35:04 +00:00
Chris Smowton
d9dc8e38f9
Fix binary names for classes declared from source
...
Only top-level non-class declarations need the IrFile's expected class name inserting
2022-12-06 18:35:04 +00:00
Chris Smowton
910a1f872d
Adjust opt-in required to use string-manipulation functions in Kotlin <= 1.5
2022-12-06 18:35:04 +00:00
Chris Smowton
540a2a623e
Don't create stub trap files for anonymous or local classes, or unexpected kinds of top-level declaration
2022-12-06 18:35:04 +00:00
Chris Smowton
08e3431107
Also stub class files relating to file classes and top-level declarations
2022-12-06 18:35:04 +00:00
Chris Smowton
748637c2d8
Tidy and use version 0 for classes extracted from source
2022-12-06 18:35:03 +00:00
Chris Smowton
e34d72aee9
Kotlin: stub trap .class files when extracting a class from Kotlin source
2022-12-06 18:35:03 +00:00
Michael Nebel
8e4190d84a
Merge pull request #11516 from michaelnebel/java/externalflowcleanup
...
Java: Cleanup imports of `ExternalFlow`
2022-12-06 14:26:39 +01:00
Anders Schack-Mulligen
b579e2e7ed
Merge pull request #11493 from aschackmull/java/scc-equivrel
...
Java: Replace ad-hoc SCC reduction with union-find.
2022-12-06 14:02:46 +01:00
Chris Smowton
3b5b121aeb
Merge pull request #11553 from smowton/smowton/fix/kotlin-synthetic-noarg-constructor
...
Kotlin: Extract a no-arg constuctor whenever a Kotlin class has default values for all parameters
2022-12-06 10:07:31 +00:00
Tom Hvitved
b5e2e1e469
Merge pull request #11564 from hvitved/dataflow/parameter-position-consistency-checks
...
Data flow: Add consistency checks for parameter positions
2022-12-06 09:33:36 +01:00
Michael Nebel
cd5c0bec33
Merge pull request #11527 from michaelnebel/java/regeneratemodels
...
Java/C#: Delete old model generator scripts and update Java model re-generator script.
2022-12-06 09:24:13 +01:00
Chris Smowton
407e4cdd07
Don't create a default constructor for annotations, or classes that explicitly declare a no-arg constructor.
2022-12-05 16:17:51 +00:00
Chris Smowton
8897f5bccc
Merge pull request #11552 from smowton/smowton/fix/kotlin-toplevel-internal-names
...
Kotlin: Don't add name mangling to top-level internal functions
2022-12-05 15:36:52 +00:00
Michael Nebel
fca249a62e
Java: Address review comments.
2022-12-05 14:44:52 +01:00
Tom Hvitved
52f3a48638
Data flow: Sync files
2022-12-05 12:57:27 +01:00
Tom Hvitved
faca4b5b56
Merge pull request #11461 from hvitved/ruby/unique-hash-splat-param
...
Ruby: At most one hash-splat `ParameterNode` per callable
2022-12-05 11:53:28 +01:00
Michael Nebel
a9ba964be4
Java: Update the Java model re-generate script.
2022-12-05 11:39:44 +01:00
Michael Nebel
243b94b54a
Java/C#: Delete old model generator scripts and rename the new ones.
2022-12-05 11:39:44 +01:00
Michael Nebel
6e486d4347
Re-arrange imports.
2022-12-05 09:49:38 +01:00
Michael Nebel
5c8ef15d6f
Java: Add bi-directional imports of some abstract class extensions.
2022-12-05 09:49:38 +01:00
Michael Nebel
65f242cabe
Java: Delete import of framework related files in ExternalFlow.
2022-12-05 09:49:38 +01:00
Michael Nebel
4c7cdc6245
Java: Remove unneeded imports of ExternalFlow.qll.
2022-12-05 09:49:38 +01:00
Chris Smowton
ff4baf096f
Don't add name mangling to top-level internal functions
...
Turns out kotlinc only adds this sort of name mangling to class member functions
2022-12-02 20:16:19 +00:00
Chris Smowton
1c0494ec53
Extract a no-arg constuctor whenever a Kotlin class has default values for all parameters
2022-12-02 20:07:43 +00:00
Jami
edfcc0cd6d
Merge pull request #11487 from jcogs33/jcogs33/supportedexternalapis-telemetry-query
...
Java/C#: add SupportedExternalApis telemetry query
2022-12-02 13:27:51 -05:00
Michael Nebel
bb716ddb80
Merge pull request #11499 from michaelnebel/java/kotlinstd
...
Kotlin: Migrate standard library models to data extensions.
2022-12-02 14:44:50 +01:00
Chris Smowton
fef03a0806
Merge pull request #11540 from github/smowton/fix/path-injection-example-syntax-error
...
Java: fix syntax error in path-injection example fix
2022-12-02 11:47:53 +00:00
Michael Nebel
309807796c
Java: Deprecate ModelCsv classes.
2022-12-02 12:20:22 +01:00
Michael Nebel
b80829a3a0
Java/Kotlin: Cleanup files needed for inline models.
2022-12-02 12:20:22 +01:00
Michael Nebel
f5069ffc1f
Kotlin: Remove the inlined models.
2022-12-02 12:20:22 +01:00
Michael Nebel
42411fd455
Java/Kotlin: Allow dashes in callable names (the Kotlin standard library contains methods with dashes).
2022-12-02 12:20:22 +01:00
Michael Nebel
d9e4aafe3a
Kotlin: Add Kotlin standard library models as Data extensions.
2022-12-02 12:20:22 +01:00
Michael Nebel
fb670325d8
Java/C#: Add query for aiding the conversion of existing negative models.
2022-12-02 12:18:50 +01:00
Michael Nebel
95e65347ca
Merge pull request #11455 from michaelnebel/java/flowtestcaseextensions
...
Java: Update the flow test case generator to produce data extensions.
2022-12-02 12:15:16 +01:00
Chris Smowton
6e98c67869
Java: fix syntax error in path-injection example fix
2022-12-02 10:04:53 +00:00
Michael Nebel
73b171eb2b
Update java/ql/src/utils/flowtestcasegenerator/GenerateFlowTestCase.qll
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2022-12-02 09:47:28 +01:00
Michael Nebel
01307e1255
Update java/ql/src/utils/flowtestcasegenerator/FlowTestCase.qll
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2022-12-02 09:47:14 +01:00
Michael Nebel
c145678323
Java: Address review comments.
2022-12-02 09:46:39 +01:00
Jami Cogswell
0e3e849ead
add negative summary test for java
2022-12-01 15:49:12 -05:00
Jami Cogswell
aa633412f4
add change notes
2022-12-01 15:25:45 -05:00
Michael Nebel
cd0d09d806
Java: Refactor to avoid using SummaryModelCsv.
2022-12-01 13:07:31 +01:00
Ian Lynagh
ef8e52a4b0
Merge pull request #11437 from igfoo/igfoo/NonSerializableField
...
Kotlin: Enable java/non-serializable-field for Kotlin
2022-12-01 11:01:15 +00:00
Jami Cogswell
94c5d53192
add a couple more tests
2022-11-30 18:51:05 -05:00
