Anders Schack-Mulligen
159d8e978c
Dataflow: one more autoformat post rebase
2023-03-10 10:04:35 +01:00
Anders Schack-Mulligen
08c658e66b
Go: Autoformat
2023-03-10 09:41:20 +01:00
Owen Mansel-Chan
250a0a71e1
Merge pull request #12466 from owen-mc/update-go-diagnostics
...
The source name of a diagnostic should not change
2023-03-09 15:51:32 +00:00
Mathias Vorreiter Pedersen
59402eb754
Merge pull request #12462 from MathiasVP/disable-std-order-in-fwd-flow-stage-1
...
DataFlow: Disable standard order in `Stage1::fwdFlow`
2023-03-09 15:30:05 +00:00
Asger F
6e744093e2
Merge pull request #12398 from github/post-release-prep/codeql-cli-2.12.4
...
Post-release preparation for codeql-cli-2.12.4
2023-03-09 15:38:21 +01:00
Owen Mansel-Chan
f87b307ddb
The source name of a diagnostic should not change
2023-03-09 14:00:52 +00:00
Mathias Vorreiter Pedersen
1f77f77153
DataFlow: Sync identical files.
2023-03-09 10:41:15 +00:00
Owen Mansel-Chan
55003300fe
Merge pull request #12341 from owen-mc/go-tools-status
...
Go: tools status page support
2023-03-09 09:59:01 +00:00
Chris Smowton
db5bd98781
Return on failure to create file
2023-03-08 22:48:57 +00:00
Owen Mansel-Chan
820de5d36f
Remove fatal/panic exits from diagnostic code
2023-03-08 22:00:34 +00:00
Owen Mansel-Chan
9fc119cc55
Rearrange diagnostic error message
...
The context should come in the middle and the call to action should come
last.
2023-03-08 17:09:52 +00:00
Owen Mansel-Chan
63d3b3ff2a
Fix diagnostic-limit-reached visibility and location
2023-03-08 16:34:29 +00:00
Owen Mansel-Chan
0d6f17ec90
Do not use field internal, which is deprecated
2023-03-08 16:34:01 +00:00
Owen Mansel-Chan
17c550bc88
Address review comments
2023-03-08 15:51:45 +00:00
Chris Smowton
a63a4c29e2
Go: fix incorrect-integer-conversion sanitizer
...
This was amended as part of https://github.com/github/codeql/pull/12186 , but the conversion was inadequate because the new implementation didn't work when a sink (type conversion) led directly to a non-`localTaintStep` step, such as a store step or an interprocedural step. Here I move the sink back one step to the argument of the type
conversion and sanitize the result of the conversion instead, to ensure there is always a unique local successor to a sink.
This should eliminate unexpected extra results that resulted from https://github.com/github/codeql/pull/12186 . Independently there are also *lost* results that stem from needing a higher `fieldFlowBranchLimit` that are not addressed in this PR, but raising that limit is a performance risk and so I will address this separately.
2023-03-08 09:48:35 +00:00
Owen Mansel-Chan
07098bf8bf
Minor refactor in diagnostics.go
2023-03-07 16:38:53 +00:00
Owen Mansel-Chan
2edccec693
Do not link to GitHub AE version of documentation
2023-03-07 16:38:53 +00:00
Owen Mansel-Chan
c28f51f820
Remove diagnostics-limit-exceeded test
...
There is no way to trigger this any more.
2023-03-07 16:38:52 +00:00
Owen Mansel-Chan
05a4fdf6d8
Put all package-not-found errors into one diagnostic
2023-03-07 16:38:52 +00:00
Owen Mansel-Chan
a4c9120a9a
Update one of the diagnostic messages
2023-03-07 16:38:52 +00:00
Owen Mansel-Chan
2c5239ff7b
Use full stops at the end of diagnostics messages
2023-03-07 16:38:51 +00:00
Owen Mansel-Chan
a7a10de9ea
Emit diagnostic to pass fourth integration tests
2023-03-07 16:38:51 +00:00
Owen Mansel-Chan
8d28253175
Add tests for fourth diagnostic (Go files found but not processed)
2023-03-07 16:38:51 +00:00
Owen Mansel-Chan
01a2e74df7
Add test for diagnostic-limit-hit diagnostic
2023-03-07 16:38:50 +00:00
Owen Mansel-Chan
b6a9f87238
Use "go/autobuilder/" as prefix for all diagnostics
2023-03-07 16:38:50 +00:00
Owen Mansel-Chan
4907e5754f
Address review comments
2023-03-07 16:38:49 +00:00
Owen Mansel-Chan
2a41e6ae66
Emit diagnostic to pass third inegration tests
2023-03-07 16:38:49 +00:00
Owen Mansel-Chan
4fe4dfbf83
Add tests for third diagnostic (package not found)
2023-03-07 16:38:49 +00:00
Owen Mansel-Chan
c0cc1c3fd5
Emit diagnostic to pass second integration test
2023-03-07 16:38:48 +00:00
Owen Mansel-Chan
3f805d3456
Remove unused param from function
2023-03-07 16:38:48 +00:00
Owen Mansel-Chan
137b2c9ef9
Add test for second diagnostic (newer go version)
2023-03-07 16:38:47 +00:00
Owen Mansel-Chan
cbb2fb9968
Emit diagnostic to pass first integration test
2023-03-07 16:38:47 +00:00
Owen Mansel-Chan
4d3b05e041
Add test for first diagnostic (different OS/arch)
2023-03-07 16:38:46 +00:00
Mathias Vorreiter Pedersen
92ad099c1b
DataFlow: Remove bindingsets, remove the call column, and swap parameter and argument columns.
2023-03-06 13:47:59 +00:00
Mathias Vorreiter Pedersen
3bf28cc752
DataFlow: Sync identical files.
2023-03-06 13:46:21 +00:00
Mathias Vorreiter Pedersen
067abacbb8
Go: Add stub.
2023-03-06 13:44:23 +00:00
Anders Schack-Mulligen
5c7f2ac7f7
Merge pull request #12186 from aschackmull/dataflow/refactor-configuration
...
Data flow: Refactor configuration
2023-03-06 13:38:59 +01:00
Anders Schack-Mulligen
557cb17f4d
Dataflow: Minor perf fix for single config wrapper.
2023-03-06 10:24:33 +01:00
github-actions[bot]
af61b45785
Post-release preparation for codeql-cli-2.12.4
2023-03-04 14:16:55 +00:00
Jeroen Ketema
549fb0324b
Apply suggestions from code review
2023-03-03 15:26:38 +01:00
github-actions[bot]
462da63970
Release preparation for version 2.12.4
2023-03-03 14:11:51 +00:00
Anders Schack-Mulligen
0addcfa7c5
Dataflow: Fix some perf issues.
2023-03-03 11:45:32 +01:00
Anders Schack-Mulligen
b34f99f716
Dataflow: Add change notes.
2023-03-02 16:01:29 +01:00
Anders Schack-Mulligen
a498ab241b
Go: Fix query.
2023-03-02 13:53:37 +01:00
Tony Torralba
59bd1e5ab1
Merge pull request #12228 from github/java/mad-decls-triage-request-2276
...
Java: Update MaD sink decls after triage
2023-03-01 17:08:38 +01:00
Anders Schack-Mulligen
5469a82efb
Go,Java,Python: Fix some tests.
2023-02-28 14:31:00 +01:00
Anders Schack-Mulligen
64c60d59b1
Go: Fix compilation.
2023-02-28 09:57:22 +01:00
Anders Schack-Mulligen
bf650c755c
Dataflow: Sync changes to all languages.
2023-02-27 14:30:05 +01:00
Michael Nebel
813ffa440c
Java: Consider ai-generated flow summaries to as generated summaries in dataflow.
2023-02-20 12:11:48 +01:00
Tom Hvitved
879eff41ea
Merge branch 'main' into util/inline-expect-test-use-end-line
2023-02-20 10:03:38 +01:00