hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-12 05:01:06 +01:00
Code Issues Packages Projects Releases Wiki Activity
85,333 Commits 1,690 Branches 160 Tags
767acb8ff433fda17d2eded6b79c10a891de8543
Commit Graph

3418 Commits

Author SHA1 Message Date
Tom Hvitved
767acb8ff4 Rust: Fix bad join 
Before
```
Evaluated relational algebra for predicate TypeMention::RefTypeReprMention.resolveRootType/0#dispred#091b949a#fb@4bd8a49g with tuple counts:
            124419   ~0%    {1} r1 = RefTypeRepr::Generated::RefTypeRepr#422893fa AND NOT `RefTypeRepr::Generated::RefTypeRepr.isMut/0#dispred#e2b9988f`(FIRST 1)
        6621454761   ~1%    {3}    | JOIN WITH `Type::DataType.getTypeItem/0#dispred#83467854` CARTESIAN PRODUCT OUTPUT Rhs.0, Lhs.0, Rhs.1
         915101745   ~0%    {4}    | JOIN WITH `project#Type::DataType.getPositionalTypeParameter/1#dispred#3bf49cbe` ON FIRST 1 OUTPUT Lhs.2, _, Lhs.1, Lhs.0
         915101745   ~3%    {4}    | REWRITE WITH Out.1 := "Ref"
            124419   ~0%    {2}    | JOIN WITH `Builtins::BuiltinType.getName/0#dispred#8f62ab0a` ON FIRST 2 OUTPUT Lhs.2, Lhs.3

             76728   ~0%    {1} r2 = JOIN RefTypeRepr::Generated::RefTypeRepr#422893fa WITH `RefTypeRepr::Generated::RefTypeRepr.isMut/0#dispred#e2b9988f` ON FIRST 1 OUTPUT Lhs.0
        4083387432   ~1%    {3}    | JOIN WITH `Type::DataType.getTypeItem/0#dispred#83467854` CARTESIAN PRODUCT OUTPUT Rhs.0, Lhs.0, Rhs.1
         564334440   ~3%    {4}    | JOIN WITH `project#Type::DataType.getPositionalTypeParameter/1#dispred#3bf49cbe` ON FIRST 1 OUTPUT Lhs.2, _, Lhs.1, Lhs.0
         564334440   ~0%    {4}    | REWRITE WITH Out.1 := "RefMut"
             76728   ~2%    {2}    | JOIN WITH `Builtins::BuiltinType.getName/0#dispred#8f62ab0a` ON FIRST 2 OUTPUT Lhs.2, Lhs.3

            201147   ~1%    {2} r3 = r1 UNION r2
                            return r3
```

After
```
Evaluated relational algebra for predicate TypeMention::RefTypeReprMention.resolveRootType/0#dispred#091b949a#fb@8f12aa2a with tuple counts:
        124419   ~0%    {1} r1 = RefTypeRepr::Generated::RefTypeRepr#422893fa AND NOT `RefTypeRepr::Generated::RefTypeRepr.isMut/0#dispred#e2b9988f`(FIRST 1)
        124419   ~0%    {2}    | JOIN WITH Type::RefSharedType#090df68e CARTESIAN PRODUCT OUTPUT Rhs.0, Lhs.0
        124419   ~0%    {2}    | JOIN WITH `project#Type::DataType.getPositionalTypeParameter/1#dispred#3bf49cbe` ON FIRST 1 OUTPUT Lhs.1, Lhs.0

         76728   ~0%    {1} r2 = JOIN RefTypeRepr::Generated::RefTypeRepr#422893fa WITH `RefTypeRepr::Generated::RefTypeRepr.isMut/0#dispred#e2b9988f` ON FIRST 1 OUTPUT Lhs.0
         76728   ~0%    {2}    | JOIN WITH Type::RefMutType#c67a1837 CARTESIAN PRODUCT OUTPUT Rhs.0, Lhs.0
         76728   ~2%    {2}    | JOIN WITH `project#Type::DataType.getPositionalTypeParameter/1#dispred#3bf49cbe` ON FIRST 1 OUTPUT Lhs.1, Lhs.0

        201147   ~1%    {2} r3 = r1 UNION r2
                        return r3
```
 2026-01-16 13:11:45 +01:00
Simon Friis Vindum
d8061c17cc Merge pull request #21165 from paldepind/rust/associated-types 
Rust: Associated types are inherited as type parameters by traits and dyn traits
 2026-01-15 11:50:00 +01:00
Simon Friis Vindum
15f3c38041 Rust: QLDoc fixes 2026-01-15 11:34:58 +01:00
Simon Friis Vindum
8cbe17a62b Rust: Fix bad join on name column 2026-01-15 07:23:34 +01:00
Simon Friis Vindum
ca3e2db217 Rust: Accept changes to expected files 2026-01-14 16:00:59 +01:00
Simon Friis Vindum
465400115f Rust: Adapt type inference consistency query exceptions 2026-01-14 15:36:35 +01:00
Simon Friis Vindum
a19ad5e557 Rust: Associated types are inherited as type parameters by traits and dyn traits 2026-01-14 14:44:31 +01:00
Simon Friis Vindum
62193540f7 Rust: Add additional tests for associated types 2026-01-14 14:44:30 +01:00
Simon Friis Vindum
fd5658dfe8 Rust: Tweak tests for associated types 2026-01-14 14:44:23 +01:00
Simon Friis Vindum
e0c36c758d Rust: Move associated types tests into separate file 2026-01-14 14:39:59 +01:00
Tom Hvitved
991d30f7aa Merge pull request #21161 from hvitved/rust/restrict-implicit-deref-borrow-nodes 
Rust: Restrict `ImplicitDerefBorrowNode` to nodes with enclosing CFG scope
 2026-01-14 14:37:40 +01:00
Tom Hvitved
cc4926ad37 Merge pull request #21148 from hvitved/rust/remove-macro-block-expr 
Rust: Remove `MacroBlockExpr` class
 2026-01-14 10:11:22 +01:00
Tom Hvitved
55d4902751 Rust: Restrict ImplicitDerefBorrowNode to nodes with enclosing CFG scope 2026-01-13 20:23:28 +01:00
Simon Friis Vindum
76a1e22ddc Rust: Remove manual models that are now generated 2026-01-13 16:11:18 +01:00
Simon Friis Vindum
da43e8cad8 Rust: Regenerate models 2026-01-13 16:02:32 +01:00
Simon Friis Vindum
d78491294a Rust: Exclude reqwest response timeout field as a taint step 2026-01-13 15:58:27 +01:00
Simon Friis Vindum
862adec081 Rust: Disable dynamic dispatch when generating models 2026-01-13 15:58:25 +01:00
Simon Friis Vindum
1fbf0387f5 Rust: Skip model generation for Rocket due to performance issue 2026-01-13 15:58:24 +01:00
Simon Friis Vindum
8bfce6b284 Shared, rust: Add option to disable reads steps as taint steps in model generator 2026-01-13 15:58:23 +01:00
Simon Friis Vindum
9cdf63e175 Rust: Skip model generation for functions with a ; in their canonical path 2026-01-13 15:58:22 +01:00
Ian Lynagh
63f78e7609 Merge pull request #21156 from igfoo/igfoo/mb 
Merge rc/3.20 into main
 2026-01-13 12:11:37 +00:00
Geoffrey White
69de17ecf2 Merge pull request #21153 from geoffw0/splitoff 
Rust: Add barrier for split_off
 2026-01-13 10:44:31 +00:00
Tom Hvitved
4cc4717381 Rust: Add DB upgrade script 2026-01-13 10:24:39 +01:00
Tom Hvitved
5d5bad6cd4 Rust: Update expected test output 2026-01-13 10:24:10 +01:00
Tom Hvitved
5fb425fd67 Rust: Update extractor and QL code after removing MacroBlockExpr 2026-01-13 10:24:04 +01:00
Tom Hvitved
3eafca0550 Rust: Run codegen 2026-01-13 10:22:16 +01:00
Geoffrey White
b2d19b610e Rust: US spelling. 2026-01-13 09:01:12 +00:00
Simon Friis Vindum
e7791120fa Rust: Address review comments 2026-01-13 07:53:39 +01:00
Ian Lynagh
dcd0a69759 Merge remote-tracking branch 'upstream/main' into igfoo/mb 2026-01-13 01:01:35 +00:00
Simon Friis Vindum
9e74a7869a Rust: Move everything type inference related into the typeinference directory 2026-01-12 16:31:34 +01:00
Geoffrey White
a78756ff8b Merge branch 'main' into splitoff 2026-01-12 14:21:01 +00:00
Geoffrey White
479c58bef5 Rust: Add a barrier. 2026-01-12 13:52:54 +00:00
Geoffrey White
7658ebb449 Rust: Add spurious test case for rust/uncontrolled-allocation-size. 2026-01-12 13:52:53 +00:00
Tom Hvitved
17441a5462 Rust: Add missing .Reference in various models 2026-01-12 14:21:45 +01:00
Tom Hvitved
6b34d0d250 Merge pull request #21123 from hvitved/rust/fix-path-models 
Rust: Improve/add various models
 2026-01-12 12:20:56 +01:00
Simon Friis Vindum
41921a85bb Rust: Make function trait syntax without return type default to unit 2026-01-09 16:08:01 +01:00
Simon Friis Vindum
d45269609a Rust: Add test with fn trait syntax without return type 2026-01-09 15:38:12 +01:00
Tom Hvitved
f3d78a4e0b Rust: Update expected test output 2026-01-09 14:40:04 +01:00
Tom Hvitved
609eb17e30 Rust: Add more models 2026-01-09 14:40:03 +01:00
Tom Hvitved
0d0029f5a3 Rust: Update expected test output 2026-01-09 14:40:01 +01:00
Tom Hvitved
792908586a Rust: Add some ffi models 2026-01-09 14:40:00 +01:00
Tom Hvitved
31b0d3eb1d Rust: Fix some models in fs.model.yml 2026-01-09 14:39:59 +01:00
Tom Hvitved
636bbe30f9 Merge pull request #21122 from hvitved/rust/summary-read-taint-step 
Rust: Also lift read steps in summaries as taint steps
 2026-01-09 14:39:39 +01:00
Simon Friis Vindum
ac62a9fe57 Merge pull request #21133 from paldepind/rust/type-item-path-resolution 
Rust: Use `TypeItem` in path resolution
 2026-01-09 14:35:12 +01:00
Tom Hvitved
209ee9236b Rust: Also lift read steps in summaries as taint steps 2026-01-09 12:13:46 +01:00
Tom Hvitved
1a29b32af9 Merge pull request #20987 from hvitved/rust/type-inference-deref-trait 
Rust: Handle `Deref` trait in type inference and data flow
 2026-01-09 12:10:46 +01:00
Simon Friis Vindum
11bd334370 Rust: Use TypeItem in path resolution 2026-01-09 11:40:16 +01:00
Tom Hvitved
e2eaf80202 Rust: Fix QL4QL finding 2026-01-09 11:28:37 +01:00
Tom Hvitved
6028cd6636 Address review comments 2026-01-09 11:14:23 +01:00
Simon Friis Vindum
56f5328530 Rust: Use getAssocItem consistently in stdlib classes 2026-01-08 11:59:10 +01:00