hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 17:23:36 +01:00
Code Issues Packages Projects Releases Wiki Activity
5,999 Commits 1,671 Branches 157 Tags
49adba0b51a9c981eb75b980393d42865324d3d2
Commit Graph

657 Commits

Author SHA1 Message Date
Anders Schack-Mulligen
cd8d16183c Java/CPP/C#: Sync dataflow. 2019-07-22 15:41:37 +02:00
Felicity Chapman
cb48af7395 Update Python and C# help for commented-out code to use common qhelp 2019-07-15 09:26:17 +01:00
semmle-qlci
0290c79c54 Merge pull request #1486 from hvitved/csharp/inherited-completions 
Approved by calumgrant
 2019-07-04 19:45:25 +01:00
Tom Hvitved
349e0e8e62 C#: Address more review comments 2019-07-04 16:46:01 +02:00
Tom Hvitved
421e75d4c1 C#: Address review comments 2019-07-04 11:57:48 +02:00
Tom Hvitved
16b6791914 C#: Minor performance rewrite 2019-07-02 13:11:27 +02:00
Tom Hvitved
9a24d3a69c C#: Remove libraries and queries related to version history 
The VCS relations are no longer populated, so there is no reason to keep them,
and the queries/libraries that use the relations.
 2019-07-02 10:43:38 +02:00
semmle-qlci
4f3cbe0029 Merge pull request #1521 from hvitved/csharp/constant-condition-fp 
Approved by calumgrant
 2019-07-01 10:52:14 +01:00
Tom Hvitved
e6e606232d C#: Address review comments 2019-07-01 09:37:15 +02:00
semmle-qlci
ae3a48db58 Merge pull request #1510 from hvitved/csharp/date-queries-remove-precision 
Approved by calumgrant
 2019-07-01 08:28:08 +01:00
yh-semmle
a0dc84010a Merge pull request #1518 from Semmle/rc/1.21 
Merge rc/1.21 into master
 2019-06-28 13:52:18 -04:00
Arthur Baars
af68fd4904 Merge pull request #1408 from calumgrant/cs/suppress-null-expr 
C#: C#8 Nullable expressions and type annotations
 2019-06-28 19:21:46 +02:00
Tom Hvitved
f91e460869 C#: Introduce inherited CFG completions 
When completions are inherited by elements inside `finally` blocks, we previously
threw away the underlying completion. For example, in

```
try
{
    if (b)
        throw new Exception();
}
finally
{
    if (b)
        ...
}
```

the completions for `b` inside the `finally` block are `true` and `throw(Exception)`,
where the latter is inherited from the `try` block, with an underlying `false`
completion. Throwing away the `false` completion meant that we were unable to prune
the `false` edge (Boolean CFG splitting).
 2019-06-28 15:41:49 +02:00
Tom Hvitved
8d7ea2f49f C#: Add CFG test that mixes Boolean/finally/catch splitting 2019-06-28 15:41:49 +02:00
Calum Grant
4d383001ac C#: Address review comment 2019-06-28 14:17:16 +01:00
Calum Grant
a5543699b2 Merge pull request #1460 from hvitved/csharp/cfg-last 
C#: Refactor `last` predicate
 2019-06-28 14:13:43 +01:00
Tom Hvitved
3d4316da1c C#: Address review comments 2019-06-28 13:00:18 +02:00
Tom Hvitved
db565c5a88 C#: Remove false positives in cs/constant-condition 2019-06-28 11:50:53 +02:00
Tom Hvitved
4da7a17f4b C#: Add more tests for cs/constant-condition 2019-06-28 11:25:18 +02:00
Calum Grant
2504754e8e C#: Remove use of deprecated predicates. 2019-06-27 15:35:37 +01:00
Tom Hvitved
481bf77d5f CIL: Speedup consistency tests 
- Make `InstructionViolation` abstract to avoid computing `getInstructionsUpTo()`
  for all instructions in the database.
- Enable `consistency.ql`, which reports all consistency violations, and remove
  all other specialized tests.
 2019-06-27 13:40:07 +02:00
Tom Hvitved
04279531e7 C#: Remove @precision for new date queries 
Removing the `@precision` annotation until we know how precise these queries
actually are for projects on LGTM.com.
 2019-06-27 10:33:27 +02:00
Tom Hvitved
b6cf13510c C#: Update @name for two queries 2019-06-27 10:22:56 +02:00
semmle-qlci
1c25e17812 Merge pull request #1505 from hvitved/csharp/autoformat 
Approved by calumgrant
 2019-06-27 08:03:58 +01:00
semmle-qlci
f58c7cc79c Merge pull request #1446 from hvitved/csharp/cached-stages 
Approved by calumgrant
 2019-06-27 08:03:24 +01:00
Calum Grant
76454ed68a C#: Fix formatting of arrays and NullableTypes 2019-06-26 20:24:56 +01:00
Calum Grant
abf43dabe5 C#: Address review comments. Fix up toStringWithTypes(), and deprecate predicates in TypeParameterConstraints. 2019-06-26 20:24:56 +01:00
Calum Grant
620ecc8128 C#: Address review comments part 1. 2019-06-26 20:24:56 +01:00
Calum Grant
35ecb948fc C#: Fix qltests. 2019-06-26 20:24:55 +01:00
Calum Grant
abe961f094 C#: Remove disabled and not-applicable nullability annotations since they can be deduced. 2019-06-26 20:24:55 +01:00
Calum Grant
d46848ed10 C#: Make Annotations module private. Update comments. 2019-06-26 20:24:55 +01:00
Calum Grant
f9099653a6 C#: Do not extract type annotations that can be deduced. Put specific_type_parameter_annotation on the side of specific_type_parameter_constraints. 2019-06-26 20:24:55 +01:00
Calum Grant
31655c22f1 C#: Stats update 2019-06-26 20:24:55 +01:00
Calum Grant
4aa1947a23 C#: Implement type annotations for nullability, parameter kinds and method returns. 2019-06-26 20:24:55 +01:00
Tom Hvitved
bd03e7a590 C#: Auto format 2019-06-26 19:32:08 +02:00
Tom Hvitved
51d093add0 C#: Address review comments 2019-06-25 17:01:48 +02:00
Calum Grant
a3d5d2c8e4 Merge pull request #1345 from denislevin/denisl/cs/MishandlingJapaneseDatesAndLeapYear 
C#: Japanese Era and Leap Year checks (Likely Bugs)
 2019-06-20 10:21:26 +01:00
Calum Grant
3c9c0e943b Merge pull request #1459 from hvitved/csharp/remove-deprecated 
C#: Remove deprecated predicates
 2019-06-19 17:56:20 +01:00
Calum Grant
07eb0ec5b2 Merge pull request #1462 from hvitved/csharp/controlflowgraph-depr 
C#: Remove uses of deprecated `ControlFlowGraph` module
 2019-06-19 17:55:04 +01:00
Calum Grant
df2a46eb80 Merge pull request #1468 from hvitved/csharp/extractor-error 
C#: Include extractor message in diagnostic queries
 2019-06-19 17:47:11 +01:00
Denis Levin
aab4351efb A few more changes from code review 2019-06-18 17:49:48 -07:00
Tom Hvitved
5443f74660 C#: Reintroduce deprecated ControlFlowGraph module 2019-06-18 11:44:12 +02:00
Tom Hvitved
70c5e39c5d C#: Include extractor message in diagnostic queries 2019-06-18 11:01:26 +02:00
Tom Hvitved
a1d7382a67 C#: Update expected test output 2019-06-17 20:07:54 +02:00
Tom Hvitved
f408a6ddfc Merge pull request #1404 from calumgrant/cs/dispose-not-called-on-throw 
C#: Improvement to cs/dispose-not-called-on-throw
 2019-06-17 11:25:16 +02:00
Tom Hvitved
e70f17f260 C#: Remove uses of deprecated ControlFlowGraph module 2019-06-17 10:23:23 +02:00
semmle-qlci
03cf8ef94f Merge pull request #1422 from hvitved/csharp/switch-expr-completion 
Approved by calumgrant
 2019-06-17 08:33:43 +01:00
Tom Hvitved
97d2813666 C#: Refactor last predicate 
- Split up the `last` predicate into a non-recursive part `lastNonRec` and a recursive
  part `last`.
- Almost all syntactic constructs have a very simple `last` definition; a set of
  disjuncts with exactly one recursive call -- those are defined in `lastNonRec`.
- `try` statements and (last) `catch` clauses require multiple recursive calls in
  the same disjunct, and are therefore handled in the `last` predicate (as before).
- The benefit is that we only need to take care of the join order in the recursive
  call (for non-`try`/`catch` statements) in one place (the predicate `lastRec`),
  so we can get rid of many `nomagic`'ed `last`-specialisations.
 2019-06-17 09:28:56 +02:00
Denis Levin
da2422cb17 Addressed code review comments 2019-06-14 18:25:17 -07:00
Calum Grant
1e7ce8cd31 Merge pull request #1451 from hvitved/csharp/element-preds 
C#: Move two predicates from `csharp/Element.qll` to `dotnet/Element.qll`
 2019-06-14 16:21:28 +01:00