yoff
746e9948b0
Merge pull request #5075 from RasmusWL/crypto
...
Python: Port py/weak-crypto-key to use type-tracking
2021-03-18 20:53:28 +01:00
Rasmus Wriedt Larsen
fbbec5d2b9
Merge pull request #5118 from yoff/python-port-stacktrace-exosure
...
Python: Port stack trace exposure
2021-03-16 14:52:44 +01:00
Rasmus Wriedt Larsen
50978364a6
Merge pull request #5246 from yoff/python-port-insecure-default-protocol
...
Python: Port insecure default protocol
2021-03-16 14:30:19 +01:00
Taus
dfc0e9b906
Merge pull request #5243 from RasmusWL/port-bind-to-all-interfaces
...
Python: Port py/bind-socket-all-network-interfaces query
2021-03-12 16:04:19 +01:00
Taus
c6d6d07720
Apply suggestions from code review
2021-03-12 14:28:59 +01:00
Taus
ffe5d30c2b
Apply suggestions from code review
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2021-03-12 14:27:07 +01:00
Rasmus Lerchedahl Petersen
fe975f25f9
Merge branch 'python-port-insecure-default-protocol' of github.com:yoff/codeql into python-port-insecure-default-protocol
2021-03-10 15:59:13 +01:00
Rasmus Lerchedahl Petersen
e726ff425c
Python: simplify query code as suggested by review
2021-03-10 15:58:44 +01:00
yoff
dfdf0344de
Update python/ql/src/Security/CWE-327/InsecureDefaultProtocol.qhelp
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2021-03-09 16:44:08 +01:00
Rasmus Lerchedahl Petersen
8b25806a2c
Python: Attempt to clarify help
2021-03-09 13:29:33 +01:00
Rasmus Lerchedahl Petersen
a16de26799
Python: add linebreak to qhelp file
...
hopefully this will generate better markdown
2021-03-09 13:27:44 +01:00
yoff
fd5ac13828
Update python/ql/src/Security/CWE-327/InsecureDefaultProtocol.ql
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2021-03-09 13:23:44 +01:00
yoff
88784fbd31
Update python/ql/src/Security/CWE-327/InsecureDefaultProtocol.qhelp
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2021-03-09 13:23:35 +01:00
yoff
b6257edc9e
Update python/ql/src/Security/CWE-327/InsecureDefaultProtocol.qhelp
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2021-03-09 13:20:19 +01:00
Rasmus Wriedt Larsen
99c1b2039c
Pyhton: Extract vulnerable hostnames into own predicate
...
Which makes the code a bit cleaner (and made testing out back-tracking easier).
2021-03-05 17:14:32 +01:00
Rasmus Wriedt Larsen
4804a0a9f8
Python: Minor refactor addressArg
2021-03-05 17:12:45 +01:00
Rasmus Wriedt Larsen
66c9cfad85
Python: Apply suggestions from code review
...
Co-authored-by: Taus <tausbn@github.com >
2021-03-05 17:08:37 +01:00
Rasmus Wriedt Larsen
83539928e6
Python: Fix grammar
...
Co-authored-by: Taus <tausbn@github.com >
2021-03-05 17:08:20 +01:00
yoff
d17246ce2b
Merge pull request #5255 from RasmusWL/port-flask-debug
...
Python: port py/flask-debug query
2021-03-05 09:39:14 +01:00
Rasmus Lerchedahl Petersen
3dd34c9ba9
Python: rewrite comment
2021-03-03 17:41:20 +01:00
Rasmus Lerchedahl Petersen
dcf8c881ff
Python: correct mistake in example
2021-03-03 16:54:36 +01:00
yoff
078fbccc9a
Apply suggestions from code review
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2021-03-02 22:32:45 +01:00
Rasmus Lerchedahl Petersen
38748f9e23
Python: restrict attention to ss.wrap_socket
2021-03-01 16:35:21 +01:00
Rasmus Lerchedahl Petersen
8b68912c40
Python: Update help and add example
2021-02-26 20:19:31 +01:00
Rasmus Lerchedahl Petersen
9533c92fcc
Python: Clean up tests and add comment
2021-02-26 19:28:44 +01:00
yoff
7f7320ae4c
Update python/ql/src/Security/CWE-327/InsecureDefaultProtocol.ql
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2021-02-26 10:56:48 +01:00
Rasmus Lerchedahl Petersen
311149ab4f
Python: fix spelling
2021-02-26 09:44:24 +01:00
Rasmus Wriedt Larsen
27987717dc
Merge branch 'main' into crypto
2021-02-25 11:30:32 +01:00
Rasmus Lerchedahl Petersen
24b51e8851
Merge branch 'main' of github.com:github/codeql into python-port-stacktrace-exosure
2021-02-25 07:24:41 +01:00
Rasmus Lerchedahl Petersen
192988077e
Python: Move <ul> outside of <p>
2021-02-24 23:28:13 +01:00
Rasmus Lerchedahl Petersen
10657160bc
Python: Improve qlhelp according to review
2021-02-24 22:02:16 +01:00
Rasmus Wriedt Larsen
a6e5ec2e09
Python: Port py/flask-debug
2021-02-24 11:37:25 +01:00
Rasmus Wriedt Larsen
5bb4a1a45a
Python: Use explicit argument specification instead of getAnArg
...
I've seen quite a few places where `getAnArg` leads to wrong behavior, and I
generally just don't like it.
2021-02-24 10:19:34 +01:00
yoff
c3d2001e85
Merge pull request #5251 from tausbn/python-port-missing-host-key-validation-query
...
Python: Port missing host key validation query
2021-02-24 08:43:52 +01:00
Taus Brock-Nannestad
f241dbabab
Python: Clean up query a bit
2021-02-23 22:33:18 +01:00
Taus Brock-Nannestad
002d0fe565
Python: Port missing host key query
2021-02-23 22:26:03 +01:00
Rasmus Wriedt Larsen
358ade67e5
Merge pull request #5248 from tausbn/python-port-insecure-temporary-file
...
Python: Port `py/insecure-temporary-file`
2021-02-23 21:37:59 +01:00
Taus Brock-Nannestad
b8ce5e969e
Python: Port py/insecure-temporary-file
2021-02-23 20:02:22 +01:00
yoff
9eed17f647
Merge pull request #5152 from RasmusWL/improve-pyyaml-support
...
Python: Improve pyyaml support
2021-02-23 19:58:04 +01:00
Rasmus Lerchedahl Petersen
b28544da9c
Python: Port insecure default protocol
...
- use API graphs
- update .qlhelp-file
- limit to versions below 3.4
- move tests to its own directory to only test on old version
2021-02-23 19:41:36 +01:00
Rasmus Wriedt Larsen
a09f8c4b4a
Python: Port bind-to-all-interfaces to type-tracking
2021-02-23 16:01:24 +01:00
Rasmus Wriedt Larsen
d084261a79
Python: Ignore weak key-sizes from test-code in weak-crypto-key
...
From looking at old results on LGTM.com, this was quite common (and those alerts
doesn't really provide value).
2021-02-19 15:04:41 +01:00
Rasmus Wriedt Larsen
0e9a54e9a9
Python: Rename WeakCrypto to WeakCryptoKey
...
Since WeakCrypto always makes me think that it's about all weak crypto (like
using MD5, or completely broken ciphers such as ARC4 ro DES) and not just about
weak key generation.
2021-02-19 15:03:44 +01:00
Rasmus Wriedt Larsen
46ad611d57
Python: Port py/weak-crypto-key to use type-tracking
...
instead of points-to.
Looking at query results also made me realize I didn't supply a very good
"origin" for ECC in cryptography package, so I improved that 👍 -- maybe that
sohuld have been split into multiple commits... too late :(
2021-02-19 15:03:43 +01:00
Rasmus Wriedt Larsen
4880350420
Python: Add a single missing QLDoc
2021-02-17 16:33:12 +01:00
Rasmus Wriedt Larsen
7afe3972d8
Revert "Merge pull request #5171 from RasmusWL/restructure-queries"
...
This reverts commit 8caafb3710 , reversing
changes made to ec79094957 .
2021-02-17 16:32:53 +01:00
Rasmus Wriedt Larsen
cf9ad0cdc5
Python: Move ExternalAPI queries back under Security
...
This was raised as a question at review, and I don't really have a good enough
argument for moving it under POI. At the end of the day, they are _security_
related enough I guess :)
2021-02-17 11:29:33 +01:00
Rasmus Wriedt Larsen
3a18881660
Python: Restructure query file location
...
Since I can never remember the CWE numbers
2021-02-16 11:36:10 +01:00
Rasmus Wriedt Larsen
f328e84bd2
Python: Mention yaml.safe_load in the qhelp
2021-02-12 12:29:55 +01:00
Rasmus Lerchedahl Petersen
6a45f6e7e0
Python: Port StackTraceExposure query
...
using empty concept implementation
2021-02-09 11:12:44 +01:00