Max Schaefer
7a1410e0d5
JavaScript: Update and expand tests.
2020-07-09 09:25:52 +01:00
Max Schaefer
1c47260bde
JavaScript: Add support for global variables to portals.
2020-07-09 09:12:56 +01:00
Max Schaefer
c40ef0556a
JavaScript: Broaden scope of imports considered relevant to portals.
...
Previously, we only considered an import relevant to portals if the path it imported was declared as a dependency. This falls down for deep imports where a specific module inside the package is imported rather than the default entry point, for imports of built-in modules like `fs`, and in cases where a developer simply forgets to declare a dependency.
So instead we now consider all imports relevant whose path does not start with a dot or a slash.
2020-07-09 09:09:44 +01:00
Max Schaefer
8b4b5781e6
JavaScript: Add utility predicate getBasePortal(i).
...
This iterates the existing `getBasePortal()` predicate `i` times.
2020-07-09 09:08:18 +01:00
Erik Krogh Kristensen
022cafebd3
make sure the consisntecy-checking library does not mix configurations
2020-07-08 10:28:41 +02:00
Erik Krogh Kristensen
ec38df69b3
update consistency comments for CWE-918
2020-07-08 10:24:55 +02:00
Erik Krogh Kristensen
c5285f7418
update inconsistency comment for CWE-843
2020-07-08 10:16:43 +02:00
Erik Krogh Kristensen
45b6906a0d
move comments to match alert location for CWE-834
2020-07-08 10:16:04 +02:00
Erik Krogh Kristensen
71a3d49d2b
update comments to match alert location for CWE-807
2020-07-08 10:15:26 +02:00
Erik Krogh Kristensen
d814e73023
update comment position to match alert location for CWE-798
2020-07-08 10:12:12 +02:00
Erik Krogh Kristensen
bcffc97de7
update comment position to match alert location for CWE-776
2020-07-08 10:10:31 +02:00
Erik Krogh Kristensen
2235634347
update consistency comments for CWE-754
2020-07-08 10:08:51 +02:00
Erik Krogh Kristensen
0d64a0f2c8
update consistency comment for CWE-730
2020-07-08 10:07:34 +02:00
Erik Krogh Kristensen
5a87628478
update consistency comments for CWE-611
2020-07-08 10:03:03 +02:00
Erik Krogh Kristensen
1f1c09af02
update consistency comments for CWE-601
2020-07-08 10:02:29 +02:00
Erik Krogh Kristensen
ce6a211340
update inconsistency comment for CWE-506
2020-07-08 10:01:40 +02:00
Erik Krogh Kristensen
bf36137834
update inconsistency comment for CWE-346
2020-07-08 10:01:04 +02:00
Erik Krogh Kristensen
16b0427dc4
update inconsistency comment for CWE-338
2020-07-08 10:00:19 +02:00
Erik Krogh Kristensen
9bcbedde46
update consistency comment in passwords.js
2020-07-08 09:55:00 +02:00
Erik Krogh Kristensen
664c5e64b4
add [INCONSISTENCY] comment in CodeInjection test
2020-07-08 09:48:12 +02:00
Erik Krogh Kristensen
00e900f1b1
only include named topmost package.json files for js/shell-command-constructed-from-input
2020-07-08 09:25:08 +02:00
Raz0r
3487ec17d0
add tests
2020-07-07 16:26:14 +03:00
Erik Krogh Kristensen
d85d9b9b5b
autoformat
2020-07-07 16:21:03 +03:00
Arseny Reutov
b46b49586a
Apply suggestions from code review
...
`interpretsValueAsJavaScript` -> `interpretsValueAsJavaScriptUrl`
Co-authored-by: Asger F <asgerf@github.com >
2020-07-07 16:21:03 +03:00
Raz0r
54db6c4a39
[js/client-side-unvalidated-url-redirection] add interpretsValueAsJavaScript predicate
2020-07-07 16:21:03 +03:00
Anders Schack-Mulligen
67db1df00c
C++/C#/JavaScript/Python: Port Location qldoc update.
2020-07-07 11:39:27 +02:00
Erik Krogh Kristensen
442ee8d1cc
add consistency-checking for CWE-089
2020-07-06 19:02:50 +02:00
semmle-qlci
fe0c5a9ea6
Merge pull request #3892 from asger-semmle/js/redirect-starts-with-sanitizer
...
Approved by esbena
2020-07-06 17:04:30 +01:00
semmle-qlci
6d80445f24
Merge pull request #3851 from erik-krogh/queryStuff
...
Approved by esbena
2020-07-06 14:40:41 +01:00
Erik Krogh Kristensen
9a944625d1
autoformat
2020-07-06 15:17:15 +02:00
Erik Krogh Kristensen
2a8b37e004
update consistency comments in unsafe-jquery-plugin.js
...
Co-authored-by: Esben Sparre Andreasen <esbena@github.com >
2020-07-06 14:15:23 +02:00
Erik Krogh Kristensen
c986f3bb7c
add consistency checking for CWE-079
2020-07-06 13:42:35 +02:00
Erik Krogh Kristensen
dc8042adeb
introduce conistency-checking for CWE-078
2020-07-06 12:47:56 +02:00
semmle-qlci
13c3513d76
Merge pull request #3905 from erik-krogh/unsafeShellTypo
...
Approved by esbena
2020-07-06 11:41:56 +01:00
semmle-qlci
73d606d2c3
Merge pull request #3844 from github/esbena-patch-3
...
Approved by erik-krogh
2020-07-06 09:47:59 +01:00
Erik Krogh Kristensen
8585312271
fix typo in js/shell-command-constructed-from-input
2020-07-06 10:33:49 +02:00
Asger Feldthaus
b5104ae42d
JS: Add StartsWith sanitizer
2020-07-03 14:46:07 +01:00
Asger Feldthaus
4c06eb8bfe
JS: Add test showing FPs
2020-07-03 14:45:42 +01:00
Erik Krogh Kristensen
078b6a8df2
autoformat
2020-07-03 00:21:55 +02:00
Erik Krogh Kristensen
261821b32c
Merge remote-tracking branch 'upstream/master' into queryStuff
2020-07-02 16:08:05 +02:00
semmle-qlci
b5c8f2238b
Merge pull request #3805 from esbena/js/seal-freeze-flow
...
Approved by asgerf
2020-07-02 13:54:54 +01:00
Erik Krogh Kristensen
ceb19292cb
autoformat
2020-07-02 14:47:08 +02:00
Erik Krogh Kristensen
2b0a091921
split out type-tracking into two predicates, to avoid catastrophic join-order
2020-07-02 14:28:28 +02:00
semmle-qlci
97128b1475
Merge pull request #3829 from asger-semmle/js/xss-substr
...
Approved by erik-krogh
2020-07-02 11:58:32 +01:00
Erik Krogh Kristensen
f60a7489b5
ignore parents that doesn't have all constant roots when deciding which roots to compute getStringValue for
2020-07-02 10:39:41 +02:00
Erik Krogh Kristensen
bbdeca367b
use getUnderlyingValue() to find leafs of a string-concat
2020-07-02 10:38:02 +02:00
Erik Krogh Kristensen
226e066db8
use strictconcat instead of concat
2020-07-02 10:12:43 +02:00
semmle-qlci
bfb734e1d7
Merge pull request #3832 from asger-semmle/js/typescript-in-html-files3
...
Approved by erik-krogh
2020-07-02 08:30:45 +01:00
semmle-qlci
45ef3ec4a8
Merge pull request #3619 from erik-krogh/CWE022-Correctness
...
Approved by asgerf
2020-07-01 20:07:58 +01:00
Erik Krogh Kristensen
6f54bb1613
only calculate getStringValue for concatenation roots
2020-07-01 20:48:20 +02:00