Jonas Jensen
b98daae077
C++: Remove deprecated from hasQualifiedName/1
...
The predicate is still deprecated, but we can't mark it as such until
the queries in our internal repo have migrated away from it.
2019-05-03 13:22:23 +02:00
Jonas Jensen
6d954fe53e
C++: Deprecate hasQualifiedName/1
...
This predicate handles templates differently from the other overloads
with the same name, so it's likely to cause confusion.
2019-05-03 10:37:48 +02:00
Jonas Jensen
5e789901df
C++: Remove all uses of hasQualifiedName/1
2019-05-03 10:37:48 +02:00
Jonas Jensen
64a87a863c
C++: Remove uses of getQualifiedName
...
This removes all uses of `Declaration.getQualifiedName` that I think can
be removed without changing any behaviour. The following uses in the
LGTM default suite remain:
* `cpp/ql/src/Security/CWE/CWE-121/UnterminatedVarargsCall.ql` (in `select`).
* `cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll` (needs template args).
* `cpp/ql/src/semmle/code/cpp/security/FunctionWithWrappers.qll` (used for alert messages).
2019-05-03 10:37:48 +02:00
Jonas Jensen
0a2e28858a
C++: Rework how qualified names are computed
2019-05-03 10:37:48 +02:00
Jonas Jensen
b51ce87ae8
C++: Autoformat QualifiedName.qll
2019-05-03 10:37:47 +02:00
Jonas Jensen
b97ff1a72f
C++: Take QualifiedName.qll from Ian's branch
...
This imports `QualifiedName.qll` from
2f74a456290b9e0850b7308582e07f5d68de3a36 and makes minimal changes so it
compiles.
Original author: Ian Lynagh <ian@semmle.com >
2019-05-03 10:37:12 +02:00
Tom Hvitved
b6206d7370
Data flow: Introduce ReturnKind
2019-05-02 20:30:50 +02:00
Dave Bartolomeo
7071692373
C++: Clarify comment based on PR feedback
2019-05-02 11:18:10 -07:00
Dave Bartolomeo
fef58ec1ee
C++: Add "~" prefix to inexact uses
2019-05-02 11:18:09 -07:00
Dave Bartolomeo
5dcd314908
C++: Update to conform to new API naming
2019-05-02 11:18:09 -07:00
Dave Bartolomeo
65535449d6
C++: Fix merge conflicts
2019-05-02 11:18:09 -07:00
Dave Bartolomeo
0cde86d3c1
C++: Fix PR feedback
2019-05-02 11:18:09 -07:00
Dave Bartolomeo
9869fd32d0
C++: Add implementation documentation for SSA
2019-05-02 11:18:08 -07:00
Dave Bartolomeo
e0f7344676
C++: Imprecise definitions in SSA
2019-05-02 11:18:08 -07:00
Dave Bartolomeo
eed0894029
C++: Add operand labels for more operand tags
...
I kept forgetting which operand on a Chi instruction was which, so I added dump labels. I added labels for the function target of a `Call`, for positional arguments, and for address operands as well.
2019-05-02 11:18:08 -07:00
Jonas Jensen
e68dda8ce8
Merge pull request #1299 from felicity-semmle/cpp-qldoc/fix-typo
...
Fix typo in C/C++ QL library docs
2019-05-02 17:10:25 +02:00
Felicity Chapman
46177dd378
Fix typo in C/C++ QL library docs
2019-05-02 13:36:39 +01:00
Nick Rolfe
50c901d6d9
C++: remove pointless predicate
2019-05-02 11:16:21 +01:00
Nick Rolfe
8da2f0b8dc
C++: clarify folds only appear in uninstantiated templates
2019-05-02 11:16:21 +01:00
Nick Rolfe
4e39862dd5
C++: update stats for @foldexpr
2019-05-02 11:16:21 +01:00
Nick Rolfe
4352a20be0
C++: add support for C++17 fold expressions
2019-05-02 11:16:21 +01:00
Jonas Jensen
3905cf70f4
Merge pull request #1255 from geoffw0/wrongtypeformatmore
...
CPP: WrongTypeFormatArguments.ql Improvements
2019-05-02 09:17:21 +02:00
Jonas Jensen
dcbf70f616
Merge pull request #1279 from geoffw0/large-parameter
...
CPP: Tests and changes for LargeParameter.ql
2019-05-02 09:15:57 +02:00
Geoffrey White
a5b9df204b
CPP: Autoformat.
2019-05-01 13:59:28 +01:00
Jonas Jensen
9d15e67f3c
C++: Use variableAccessedAsValue in LargeParameter
...
Using `variableAccessedAsValue` fixes a FP because we can now
distinguish modifications to the parameter from modifications to data
_reachable from_ the parameter.
2019-05-01 13:58:55 +01:00
Geoffrey White
2ef3cc30c0
CPP: Fix for functions with no definition.
2019-05-01 13:17:11 +01:00
Geoffrey White
32b6e9bd3c
CPP: Exclude cases where the parameter is written to.
2019-05-01 13:17:10 +01:00
Geoffrey White
88a0e60a2a
CPP: Un-autoformat to ease merge.
2019-05-01 13:16:46 +01:00
Jonas Jensen
490dd0e8c0
Merge pull request #1245 from geoffw0/classesmanyfields
...
CPP: Fix performance issues in ClassesWithManyFields.ql
2019-05-01 13:58:28 +02:00
Geoffrey White
d4e1bae5d5
Merge pull request #1173 from jbj/alloca-enable
...
C++: Enable cpp/alloca-in-loop on LGTM
2019-05-01 12:48:59 +01:00
Geoffrey White
a749b5b6d1
CPP: Improve WrongTypeFormatArguments logic when there is more than one possible expected argument type.
2019-05-01 11:12:06 +01:00
Geoffrey White
ac277ad7ad
CPP: Fix %I length specifier.
2019-05-01 11:12:06 +01:00
Geoffrey White
707c9965af
CPP: Autoformat.
2019-05-01 10:36:15 +01:00
Dave Bartolomeo
de5c77c4e2
Update cpp/ql/src/Architecture/Refactoring Opportunities/ClassesWithManyFields.ql
...
Co-Authored-By: geoffw0 <40627776+geoffw0@users.noreply.github.com >
2019-05-01 10:36:00 +01:00
Geoffrey White
89c26ca394
CPP: Rewrite the VDE grouping in ClassesWithManyField.ql to be more performant (and modern).
2019-05-01 10:35:59 +01:00
Geoffrey White
0cc4b23484
CPP: QLDoc some predicates.
2019-05-01 10:35:57 +01:00
Geoffrey White
ab0505ea65
CPP: Undo autoformat so that things can merge.
2019-05-01 10:35:30 +01:00
Jonas Jensen
1203c7305a
Merge pull request #1261 from geoffw0/autoformat
...
CPP: Autoformat the Critical queries directory
2019-05-01 11:19:21 +02:00
Geoffrey White
09ce95575a
CPP: Fix merge.
2019-05-01 09:08:44 +01:00
Jonas Jensen
40aea2f76d
C++: Shorten alert message
...
We don't write the reason for the alert in the alert message.
2019-05-01 08:33:36 +02:00
Jonas Jensen
e38ac9f88a
C++: suppress alerts in tightly bounded loops
2019-05-01 08:33:35 +02:00
Jonas Jensen
399b64b9a6
C++: Enable cpp/alloca-in-loop on LGTM
...
Now that the query has both tests and qhelp, we can use it on LGTM. This
commit also adds a change note.
I renamed the query to reduce confusion from the lower-case unquoted
word "alloca".
2019-05-01 08:33:32 +02:00
Jonas Jensen
54091e87fa
Merge pull request #1136 from zlaski-semmle/cpp340a
...
[CPP-340] Refinements to FutileParams.ql etc.
2019-05-01 08:21:35 +02:00
Robert Marsh
514d405630
C++: Use CallInstruction as DataFlowCall
2019-04-29 14:18:09 -07:00
Tom Hvitved
5f6e9121b3
C++: Generalize FunctionCall to Call in data-flow library
2019-04-29 20:42:07 +02:00
Tom Hvitved
29e59e6d1e
Address review comments
2019-04-29 20:19:31 +02:00
semmle-qlci
2ede941097
Merge pull request #1291 from jbj/backEdgeSuccessor-perf
...
Approved by dave-bartolomeo
2019-04-29 18:18:27 +01:00
semmle-qlci
0ffba8b4eb
Merge pull request #1289 from jbj/dominanceFrontier-iterated-ir
...
Approved by dave-bartolomeo
2019-04-29 18:14:20 +01:00
semmle-qlci
d53f5aac13
Merge pull request #1228 from jbj/ir-result-type-docs
...
Approved by dave-bartolomeo
2019-04-29 18:07:22 +01:00