Commit Graph

78658 Commits

Author SHA1 Message Date
Asger F
287753187e JS: Remove invalid syntax from test
TS decorators may not appear on functions and enums
2025-02-28 13:27:56 +01:00
Asger F
426a871405 JS: Remove incorrect Alert marker
This is expected, based on a comment earlier in the file about the 'y' variable
2025-02-28 13:27:54 +01:00
Asger F
2c46e10678 JS: Mark an alert as missing 2025-02-28 13:27:53 +01:00
Asger F
e026b9e048 JS: Mark regressions due to lack of local field steps 2025-02-28 13:27:52 +01:00
Asger F
e5bee19b19 JS: Accept a double-flagged line
This is flagged by two queries but for two separate issues. Seems valid to flag it twice.
2025-02-28 13:27:51 +01:00
Asger F
68fae9ded8 JS: Accept alerts about newline replacement 2025-02-28 13:27:49 +01:00
Asger F
1f3c49638b JS: Accept some less obvious alerts
These are listed in a function called 'good' but it's difficult to say in isolation whether they should be flagged or not. Accepting the changes as they seem reasonable.
2025-02-28 13:27:48 +01:00
Asger F
f395651807 JS: Mark alert as MISSING
See https://github.com/github/codeql-javascript-team/issues/447
2025-02-28 13:27:47 +01:00
Asger F
07a876b4e9 JS: Accept some alerts at the SystemCommandExecution location 2025-02-28 13:27:46 +01:00
Asger F
10a7294327 JS: Accept trivial test changes
This adds Alert annotations for alerts that seem intentional by the test
but has not been annotated with 'NOT OK', or the comment was in the wrong
place.

In a few cases I included 'Source' expectations to make it easier to see
what happened. Other 'Source' expectations will be added in bulk a later
commit.
2025-02-28 13:27:43 +01:00
Asger F
0453ded338 JS: Add query ID to some alerts 2025-02-28 13:27:41 +01:00
Asger F
86932c51bc JS: Move some alerts to their correct location
One of the diffs look confusing but:
Previously parameter {2,3} where flagged, now parameter {1,2} are flagged.

Note that for command injection, the SystemCommandExecution is flagged
despite the test file claiming otherwise.
2025-02-28 13:27:40 +01:00
Asger F
f5911c9e5a JS: Accept raw test output 2025-02-28 13:27:38 +01:00
Asger F
795c1100fc JS: Disable for SyntaxError
The presence of a syntax error sometimes prevents us from parsing the inline comment correctly.
2025-02-28 13:27:37 +01:00
Asger F
789a7bdb48 JS: Disable for test with alerts in a JSON file
JSON does not support comments so we can't use inline expectations
2025-02-28 13:27:36 +01:00
Asger F
ac6547fd01 JS: Disable for comment-related alerts 2025-02-28 13:27:35 +01:00
Asger F
d0ce53ed82 JS: Enable post-processing for all .qlref files 2025-02-28 13:27:33 +01:00
Asger F
426edd55f2 JS: Update output after line number change
Some OK-style comments had to be moved to the following line, shifting line numbers.

In selected range also included the comments themselves.

Lastly, the result sets were reordered by the CLI in some cases.
2025-02-28 13:27:31 +01:00
Asger F
9be041e27d JS: Update OK-style comments to $-style 2025-02-28 13:27:28 +01:00
Asger F
7e5c24a8ec JS: Remove uses of old inline expectation test library 2025-02-28 13:27:26 +01:00
Asger F
79e2a758d7 JS: Allow more kinds of expectation comments 2025-02-28 13:27:25 +01:00
Geoffrey White
2f2c9f8943 Merge pull request #18895 from geoffw0/docimplicit
Data flow: Improve doc for defaultImplicitTaintRead.
2025-02-28 12:18:11 +00:00
Paolo Tranquilli
945bf80803 Merge branch 'main' into redsun82/cargo-upgrade 2025-02-28 13:15:43 +01:00
Chris Smowton
4f810df53c Merge pull request #18861 from smowton/smowton/admin/jdk24-upgrade-test-expectations
Java: Update test expectations for JDK24 upgrade
2025-02-28 11:56:49 +00:00
Paolo Tranquilli
0445d886c7 QL for QL: update toolchain 2025-02-28 12:39:37 +01:00
Paolo Tranquilli
c5eeaba2ec Merge branch 'main' into redsun82/cargo-upgrade 2025-02-28 12:26:26 +01:00
Paolo Tranquilli
6b34d3f480 Rust: add missing empty expected file 2025-02-28 12:26:03 +01:00
Chris Smowton
ad732a8f57 Docs: note JDK 24 support 2025-02-28 11:23:11 +00:00
Chris Smowton
79e581f555 Change note 2025-02-28 11:23:10 +00:00
Chris Smowton
1577b40b45 Accept test changes 2025-02-28 11:23:07 +00:00
Chris Smowton
178e90c2f1 Update test expectations for JDK24 upgrade 2025-02-28 11:23:06 +00:00
Owen Mansel-Chan
94505af49e Merge pull request #18891 from github/workflow/coverage/update
Update CSV framework coverage reports
2025-02-28 11:14:06 +00:00
Paolo Tranquilli
ee61fdcb6f Merge branch 'main' into redsun82/rust-turn-off-ra-resolution 2025-02-28 12:03:14 +01:00
Chris Smowton
ec2982f3df Merge branch 'main' into workflow/coverage/update 2025-02-28 10:48:08 +00:00
Simon Friis Vindum
c4773c42c4 Rust: Model pointer read and write functions 2025-02-28 11:44:11 +01:00
Simon Friis Vindum
bc651af319 Merge branch 'main' into rust-ref-mut 2025-02-28 11:42:06 +01:00
Paolo Tranquilli
e0d4e5ea7f Rust: remove missing flow in test 2025-02-28 11:36:27 +01:00
Simon Friis Vindum
5b657035d2 Rust: Add test for models of pointer read and write 2025-02-28 11:19:41 +01:00
Michael Nebel
7015a0af38 Merge pull request #18893 from michaelnebel/csharp/pindotnetfornugetconfigerror
C#: Pin .NET for the integration test standalone_dependencies_nuget_c…
2025-02-28 10:56:10 +01:00
Simon Friis Vindum
518f164c61 Rust: Address PR comments 2025-02-28 10:49:27 +01:00
Geoffrey White
1b35c0b7c9 Data flow: Improve doc for defaultImplicitTaintRead. 2025-02-28 09:43:57 +00:00
Paolo Tranquilli
bb90b678a4 Rust: update rust-specific toolchain 2025-02-28 10:43:48 +01:00
Paolo Tranquilli
d11bbdb5a7 Merge branch 'main' into redsun82/cargo-upgrade 2025-02-28 10:41:37 +01:00
Paolo Tranquilli
3c7fe264d1 Merge pull request #18881 from github/redsun82/rust-fix-test
Rust: fix dataflow test failure by pinning the toolchain version
2025-02-28 10:17:04 +01:00
Michael Nebel
5af7630841 C#: Pin .NET for the integration test standalone_dependencies_nuget_config_error. 2025-02-28 10:07:11 +01:00
Paolo Tranquilli
b73e8dc74b Merge branch 'main' into redsun82/rust-fix-test 2025-02-28 09:31:25 +01:00
github-actions[bot]
ce82cb6424 Add changed framework coverage reports 2025-02-28 00:21:17 +00:00
Geoffrey White
998bec1efb C++: Fix the bug. 2025-02-27 21:24:07 +00:00
Geoffrey White
51d916263d C++: Another test. 2025-02-27 21:19:05 +00:00
Dave Bartolomeo
ac555ff0a3 Set the executable bit on the scripts in the Actions extractor 2025-02-27 20:06:14 +00:00