Koen Vlaswinkel
6812389fc8
C#: Fix external API name for nested types
...
This fixes the name of reported external APIs for nested types. The
`getDeclaringType().getUnboundDeclaration()`'s `toString()` method
reports the name of the type, but not the name of the declaring type.
This results in missing information in the
`UnsupportedExternalAPIs.ql` query.
For example, previously it would report:
```
GitHub.Nested#NestedClass.Test()
```
However, the `NestedClass` class does not exist in the namespace and is
only a nested type within `MyFirstClass`. The correct name should be:
```
GitHub.Nested#MyFirstClass+NestedClass.Test()
```
This name also matches the format of MaD.
2023-06-27 16:31:06 +02:00
Tom Hvitved
df61eaf59f
Merge pull request #13565 from hvitved/csharp/gvn-blowup
...
C#: Avoid combinatorial explosions in GVN construction for types
2023-06-27 13:31:36 +02:00
Kasper Svendsen
6869f03cca
C#: Enable implicit this warnings for remaining packs
2023-06-27 11:27:16 +02:00
Tom Hvitved
160771e673
C#: Avoid combinatorial explosions in GVN construction for types
2023-06-27 10:08:53 +02:00
Joe Farebrother
c419e8d24a
Fix test
2023-06-26 18:05:11 +01:00
Joe Farebrother
1d64d1297c
Update tests to use stubs
2023-06-26 16:51:07 +01:00
Joe Farebrother
938a996322
Add test case for Authorize attribute
2023-06-26 15:57:57 +01:00
Joe Farebrother
b2d54842a6
Apply review suggestion
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2023-06-23 17:00:52 +01:00
Tom Hvitved
0cb27e7511
C#: Add toString functionality consistency queries
2023-06-23 13:28:11 +02:00
Mathew Payne
0fcc1cb588
Merge branch 'main' into csharp-ext
2023-06-22 13:30:08 +01:00
Joe Farebrother
52841e9005
Apply review suggestions - minor fixes
2023-06-22 11:30:58 +01:00
Joe Farebrother
bdaeeeadee
Add good/bad indicators to tests
2023-06-22 11:21:30 +01:00
Joe Farebrother
270bcc3740
fix qhelp and remove commented out code
2023-06-22 11:20:58 +01:00
Henry Mercer
5afdaf8fe1
Merge pull request #13525 from github/rc/3.10
...
Merge `rc/3.10` back to `main`
2023-06-21 17:13:36 +01:00
Michael Nebel
3a81d21c1c
Merge pull request #13520 from michaelnebel/csharp/usestubs3
...
C#: Use stubs for query test cases.
2023-06-21 11:41:26 +02:00
Michael Nebel
27ee4241e8
C#: Remove unused test assemblies.
2023-06-21 10:45:08 +02:00
Michael Nebel
34e50de76d
C#: Only use the dll's that are strictly needed in the API Abuse/NoDisposeCallOnLocalIDisposable test case.
2023-06-21 10:39:52 +02:00
Michael Nebel
82bf27c7b2
C#: Base the remaining API Abuse query test cases on stubs.
2023-06-21 09:52:35 +02:00
Michael Nebel
52323d3990
C#: Base API Abuse/IncorrectCompareToSignature test case on stubs and update expected test output.
2023-06-21 09:40:37 +02:00
Michael Nebel
0e263fb744
C#: Base API Abuse/DisposeNotCalledOnException test case on stubs. Since the stubs requires C# 11 the language version has been removed from the options (also it doesn't affect the output).
2023-06-21 09:40:37 +02:00
Michael Nebel
4546d8f0bf
C#: Base API Abuse/UncheckedReturnValue test case on stubs, clean up test and update expected output.
2023-06-21 09:40:37 +02:00
Michael Nebel
ada49dbb2c
C#: Specific language version not needed in options file for API Abuse/NoDisposeCallOnLocalIDisposable.
2023-06-21 09:40:19 +02:00
Michael Nebel
d1184f0b3c
C#: Base the AlertSupression test on stubs.
2023-06-21 07:59:56 +02:00
Joe Farebrother
8fdec4f116
Add documentation
2023-06-20 17:18:04 +01:00
Jami
5259a6ecfc
Merge pull request #13324 from jcogs33/jcogs33/shared-sink-kind-validation
...
Shared: share MaD kind validation across languages
2023-06-20 11:56:12 -04:00
Mathew Payne
62b3d5ea19
Merge branch 'main' into csharp-ext
2023-06-20 16:17:35 +01:00
Owen Mansel-Chan
cdc1c2c1aa
Merge pull request #13454 from owen-mc/go/add-mad-content-for-pointer-content
...
Go: Add models-as-data content for pointer content
2023-06-20 14:26:07 +01:00
Owen Mansel-Chan
d7c97f8759
Merge pull request #13455 from owen-mc/dataflow/add-flowCheckNodeSpecific
...
Dataflow: add language-specific hook for breaking up big step relation
2023-06-20 13:24:26 +01:00
github-actions[bot]
18b678e69e
Post-release preparation for codeql-cli-2.13.4
2023-06-20 10:20:05 +00:00
Owen Mansel-Chan
04ff89e1fe
Update access path documentation
2023-06-20 11:05:05 +01:00
Jeroen Ketema
9c774ac97f
Merge pull request #13426 from jketema/inline-3
...
Update inline flow tests to use parameterized module
2023-06-19 17:39:29 +02:00
Tony Torralba
5cb451b040
Merge pull request #13475 from atorralba/atorralba/many/zipslip-docs-update
...
C#/Go/Java/JS/Python/Ruby: Update the description and qhelp of the Zipslip query
2023-06-19 14:33:44 +02:00
Mathew Payne
8347a410b7
Merge branch 'main' into csharp-ext
2023-06-19 13:25:07 +01:00
Mathew Payne
a6a86acd9a
Fix formatting for ExternalFlow
2023-06-19 12:44:01 +01:00
Mathew Payne
4597210519
Update csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll
...
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com >
2023-06-19 12:03:46 +01:00
Mathew Payne
861ac177b8
Update csharp/ql/lib/semmle/code/csharp/security/dataflow/CommandInjectionQuery.qll
...
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com >
2023-06-19 12:03:38 +01:00
Jeroen Ketema
b420455e2b
C#: Update InlineFlowTests to use the merged path graph
2023-06-19 10:28:54 +02:00
Jeroen Ketema
6a84e6cbfd
Add the merged PathGraph to all copies of the InlineFlowTest library
2023-06-19 10:28:10 +02:00
Tony Torralba
8f6d2ed2f9
Adjust ZipSlip query description according to review suggestions.
2023-06-19 10:27:41 +02:00
Tony Torralba
3c4d938cf1
Apply code review suggestions.
...
Co-authored-by: Asger F <asgerf@github.com >
2023-06-19 10:20:19 +02:00
Tony Torralba
433fc680ec
Apply suggestions from code review
...
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com >
2023-06-19 10:17:40 +02:00
Michael Nebel
f4f195c837
C#: Base tests for CWE-807 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
52c4a47a61
C#: Base tests for CWE-798 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
6058cfc037
C#: Base tests for CWE-730 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
5483756f17
C#: Base tests for CWE-643 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
2857145bba
C#: Base tests for CWE-614 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
58d469b932
C#: Make path relative to testdir explicit in CWE-601 testcase.
2023-06-16 10:08:40 +02:00
Michael Nebel
d414ce046f
C#: Base tests for CWE-548 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
7766aaeb1e
C#: Base tests for CWE-539 on stubs.
2023-06-16 10:08:40 +02:00
Michael Nebel
5e4d31c10d
C#: Base tests for CWE-502 on stubs.
2023-06-16 10:08:40 +02:00