Geoffrey White
047494dc95
Swift: Bank account numbers are a credential now, I guess they don't need to be private data as well.
2023-05-15 18:22:55 +01:00
Geoffrey White
252b72b573
Swift: Add some special cases to preserve (for now) result quality.
2023-05-15 18:22:50 +01:00
Geoffrey White
245e8fbc92
Swift: Use SensitiveDataHeuristics.qll in SensitiveCredential.
2023-05-15 18:14:52 +01:00
Geoffrey White
a91c45049e
Swift: Add some special cases to preserve (for now) result quality.
2023-05-15 18:06:33 +01:00
Geoffrey White
e2080c5d00
Swift: SensitiveDataHeuristics.qll expects function names without an (argument:list:).
2023-05-15 17:45:56 +01:00
Geoffrey White
35e2e5d785
Swift: Use SensitiveDataHeuristics.qll in regexpProbablySafe.
2023-05-15 17:44:54 +01:00
Geoffrey White
cc72bfbbbb
Swift: Add the shared SensitiveDataHeuristics.qll to Swift.
2023-05-15 17:38:14 +01:00
Geoffrey White
4781881a6a
Swift: Improve mobile/phone number regexp.
2023-05-15 15:30:30 +01:00
Geoffrey White
a0cba8cb6b
Swift: Address boolean value FPs.
2023-05-15 14:24:18 +01:00
Geoffrey White
27c8eb301e
Swift: Fix URL-related FPs.
2023-05-15 14:08:43 +01:00
Geoffrey White
e59d7e0345
Swift: Remove assumption that 'username' is not sensitive (in the tests).
2023-05-15 13:58:44 +01:00
Geoffrey White
dba951111a
Swift: Add more sensitive data test cases.
2023-05-15 13:58:44 +01:00
Paolo Tranquilli
10d084fbbf
Swift: update comment
2023-05-15 13:48:24 +02:00
Paolo Tranquilli
cfcd26cf0d
Swift: support markdown TSP diagnostics
2023-05-15 13:48:24 +02:00
Geoffrey White
2a4d7cb642
Swift: Make the result message consistent as well.
2023-05-15 11:53:58 +01:00
Geoffrey White
3193b3b171
Swift: Make the CleartextLogging.ql query ID consistent with the other swift/cleartext-* queries.
2023-05-15 10:51:21 +01:00
Paolo Tranquilli
dbff3e4fa4
Swift: remove unneeded SwiftDiagnosticLogWrapper
2023-05-15 10:08:43 +02:00
Paolo Tranquilli
a2cb331ebe
Swift: remove hacky binlog interception
2023-05-15 10:02:24 +02:00
Paolo Tranquilli
9a555aea5f
Merge branch 'main' into redsun82/swift-diagnostics-locations
2023-05-15 10:01:45 +02:00
Paolo Tranquilli
95cd948f09
Swift: order help links in integration test checks
...
They are currently a set within the codeql cli.
2023-05-14 22:33:48 +02:00
Paolo Tranquilli
d7cc506080
Merge branch 'main' into sashabu/tsp-incompatible-os
2023-05-12 09:58:36 +02:00
Paolo Tranquilli
9ffada31a8
Swift: make internal error telemetry only for the moment
2023-05-12 09:19:44 +02:00
Paolo Tranquilli
cce9352272
Swift: add visibility customization to diagnostics
2023-05-12 09:05:45 +02:00
Paolo Tranquilli
dedbd9ab63
Swift: remove unneeded SwiftDiagnosticsDumper
2023-05-12 08:30:43 +02:00
Paolo Tranquilli
86777fa4c2
Swift: remove obsolete comment
2023-05-12 08:23:14 +02:00
Paolo Tranquilli
03f4625b5f
Swift: go back to explicit DIAGNOSE_ERROR macros
2023-05-12 06:30:58 +02:00
Paolo Tranquilli
3f2a059b3b
Swift: add location support to TSP diagnostics
...
This required a bit of an overhaul of the original integration of
JSON diagnostics into binlog.
The problem is that it is quite hard to add a kind of metadata to
binlog entries without changing its code. Another problem is that when
wanting to avoid double evaluation of logging macro arguments one
cannot really add a separate "diagnose" step easily.
The proposed solution consists in two things:
* hook into a binlog plumbing function by providing a better overload
resolution match, which happens after logging macro expansion,
bypassing the problem of double evaluation
* in that hook, produce the diagnostic directly, without waiting to
reconstruct the diagnostics entry from the binlog serialized entry.
This allows to forgo the weird category to diagnostic mapping, and now a
diagnostics emission simply happens when a diagnostic source is given
as the first argument after the log format string. A flavour of
diganostics sources with locations is then added with the same
mechanism, allowing to write something like
```cpp
LOG_ERROR("[{}] ouch!", internalError.withLocation("foo.swift", 32));
```
2023-05-11 17:52:02 +02:00
Alexandre Boulgakov
0915d2ad77
Swift: Emit a diagnostic when attempting to use the autobuilder on Linux.
2023-05-11 14:43:13 +01:00
Geoffrey White
e402c225f4
Merge pull request #13115 from geoffw0/swift-csv-labels
...
Swift: Accept standardized CSV sink labels
2023-05-11 13:34:48 +01:00
Geoffrey White
15a7fdd297
Swift: Update existing CSV sinks to new labels.
2023-05-11 12:48:48 +01:00
Geoffrey White
8fac01e84f
Swift: Remove the old sinks.
2023-05-11 11:29:44 +01:00
Geoffrey White
7251e90633
Merge pull request #12941 from geoffw0/textsource
...
Swift: Add taint sources for UITextField
2023-05-11 11:11:45 +01:00
Geoffrey White
f1893dae85
Swift: Repair UIKit framework after merge.
2023-05-11 09:14:52 +01:00
Geoffrey White
68501b0082
Merge branch 'main' into textsource
2023-05-11 09:14:38 +01:00
Paolo Tranquilli
e925365e2d
Merge pull request #13087 from github/redsun82/swift-autobuilder-no-swift
...
Swift: surface errors about no viable swift targets found
2023-05-11 10:14:06 +02:00
Paolo Tranquilli
5fcc5e1d4a
Swift: initialize char buffer
2023-05-11 08:57:41 +02:00
Kasper Svendsen
1f0cb9eeb8
Swift: Enable implicit this receiver warnings
2023-05-11 08:35:59 +02:00
Kasper Svendsen
082e6a1245
Merge pull request #13108 from kaspersv/kaspersv/swift-explicit-this-receivers1
...
Swift: Make implicit this receivers explicit
2023-05-11 08:34:14 +02:00
Kasper Svendsen
1ee823b0f0
Merge pull request #13111 from kaspersv/kaspersv/swift-explicit-this-receivers3
...
Swift: Make implicit this receivers explicit
2023-05-11 08:33:57 +02:00
Paolo Tranquilli
92a4a798a0
Swift: apply review suggestions
2023-05-11 06:35:38 +02:00
Geoffrey White
100d960ca9
Merge pull request #12940 from geoffw0/swiftdoc
...
Swift: Initial language guides documentation for Swift
2023-05-10 19:00:35 +01:00
Geoffrey White
a3c8515629
Swift: Accept cross-language standardized CSV sink label.
2023-05-10 18:24:59 +01:00
Mathias Vorreiter Pedersen
87325dbfd1
Merge pull request #13112 from geoffw0/swifttodos2
...
Swift: Delete some more TODO comments.
2023-05-10 16:39:37 +01:00
Geoffrey White
81c29799c5
Merge branch 'main' into swiftdoc
2023-05-10 15:47:30 +01:00
Geoffrey White
1820d36a4e
Swift: Autoformat.
2023-05-10 15:36:16 +01:00
Kasper Svendsen
d346d1733e
Swift: Make implicit this receivers explicit
2023-05-10 16:12:52 +02:00
Geoffrey White
49da113b10
Swift: Delete unwanted TODO comment.
2023-05-10 15:06:39 +01:00
Geoffrey White
e120e84933
Swift: Delete TODOs (move to issues).
2023-05-10 14:59:23 +01:00
Geoffrey White
bbe5f5e0f0
Swift: HACK -> TODO.
2023-05-10 14:49:22 +01:00
Geoffrey White
4dcd3bec11
Swift: Delete TODOs (move to issues).
2023-05-10 14:47:44 +01:00
