Commit Graph

1713 Commits

Author SHA1 Message Date
Max Schaefer
dca808126f Merge pull request #2032 from erik-krogh/lessSpaces
JS: remove false positive in js/missing-space-in-concatenation
2019-10-14 14:25:40 +01:00
Henning Makholm
29167bbff8 Add qlpack.json files
Eventually these files will subsume the current `queries.xml` files
at the top of query-containing and library directories. For now they're
just here to support internal testing of the tooling support for them
we're writing on.

Format and contents is a work in progress. If you're not in Semmle,
don't depend on anything here making sense (or staying stable) until
you see the version tags increase to something nonzero.
2019-10-12 17:38:01 +02:00
Esben Sparre Andreasen
0e79d3db46 Merge pull request #2065 from erik-krogh/noReturn
JS: use of returnless function
2019-10-09 13:44:39 +02:00
Asger F
cf24fa22c8 JS: Dont use deprecated class 2019-10-09 12:16:12 +01:00
Asger F
ddf0d5379d JS: Angular: replace getAnInitialUse with parameterNode 2019-10-09 12:16:11 +01:00
Asger F
07df479b94 JS: IllegalInvocation: be more convservative 2019-10-09 12:16:11 +01:00
Asger F
d3f587c12a JS: Restrict class values flowing through globals 2019-10-09 12:16:11 +01:00
Asger F
bdc409ccb6 JS: Move getACallee into CallGraphs module 2019-10-09 12:16:11 +01:00
Asger F
4a0e54a69f JS: Add library doc comment 2019-10-09 12:16:11 +01:00
Asger F
8404522c08 JS: Performance tweaks 2019-10-09 12:16:11 +01:00
Asger F
34497f6d19 JS: Use getABoundFunctionValue in PostMessageEventHandler 2019-10-09 12:16:11 +01:00
Asger F
d6d89a0703 JS: Move call graph computation into CallGraphs.qll 2019-10-09 12:16:10 +01:00
Asger F
96a13ff5d6 JS: Add goog.bind and angular.bind as partial invokes 2019-10-09 12:16:10 +01:00
Asger F
3bf86ee468 JS: Rename AdditionalPartialInvoke -> PartialInvoke::Range 2019-10-09 12:16:10 +01:00
Asger F
d6ba966c4e JS: Add getBoundFunction() 2019-10-09 12:16:10 +01:00
Asger F
6534219831 JS: Move AdditionalPartialInvokeNode to Nodes.qll 2019-10-09 12:16:10 +01:00
Asger F
15f0e85853 JS: Restructure call graph computation 2019-10-09 12:16:10 +01:00
Asger F
c5f29e0a1d JS: Simplify call graph metric 2019-10-09 12:16:10 +01:00
Esben Sparre Andreasen
ea63414e97 Merge pull request #2016 from asger-semmle/jquery
Add type tracking and type info to jQuery model
2019-10-09 10:55:57 +02:00
Asger F
c09e748bca JS: Migrate JQueryMethodCall to new API 2019-10-08 14:05:10 +01:00
Erik Krogh Kristensen
0933235132 whitelist calls to functions that always throw an exception 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
a2993f1849 massively improve performance for detecting one-shot closures 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
0b8ea3c504 remove redundant check in returnsVoid 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
5ce356f509 two small doc fixes from docteam
Co-Authored-By: shati-patel <42641846+shati-patel@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
c6918ef38e changes to documentation and small change in returnsVoid based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
8c7f316a57 add qldoc to benignContext predicate
Co-Authored-By: Esben Sparre Andreasen <42067045+esben-semmle@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
63b3005217 remove punctuation in query name 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
b0b2d02855 small doc update
Co-Authored-By: mc <42146119+mchammer01@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
55f2f62c7a changes based on code review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
49bd553916 change query severity to warning 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
ea3c2fb2fa add fix suggestion to qhelp of js/use-of-returnless-function 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
64bcc10af3 remove redundancy in qhelp 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
666e11a506 apply suggestions from code review
Co-Authored-By: Esben Sparre Andreasen <42067045+esben-semmle@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
1c424310ae revert the last small change to ExprHasNoEffect.qll 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
34d0f72706 small refactor and added docstring based on code review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
92623a3e32 cleanup and refactor of promise case based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
0b48999718 refactored the attribute checks based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
1bbe1ecdba the js/use-of-returnless-function query now support multiple callees 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
7025ba36c0 refactor of js/use-of-returnless-function 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
00bf82d3c7 small changes to benignContext predicate based on code review 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
dedae5ba1d refactor isExplicitConditional into a library file, and use it from js/use-of-returnless-function 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
bda37b6d6f refactor of benignContext predicate based on code review 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
cdde8aea58 revert changes to js/useless-expression 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
bed14244ae add query for detecting uses return-values from functions that does not return a value 2019-10-08 11:53:14 +02:00
Asger F
755f76a308 JS: Mention the ::Range classes 2019-10-07 08:29:42 +01:00
Asger F
34b4eb69db JS: Cache JSDocTypeExpr.resolvedName() 2019-10-07 08:29:42 +01:00
Asger F
c1e9eec267 JS: Modernize jQuery attribute defs 2019-10-07 08:29:42 +01:00
Asger F
a224186fab JS: Migrate AngularJS.JQLiteObject 2019-10-07 08:29:42 +01:00
Asger F
afdcb1e075 JS: Handle jQuery objects from Parameter.getAnInitialUse() 2019-10-07 08:29:42 +01:00
Asger F
fb181c2d14 JS: Use type info and type tracking in jQuery 2019-10-07 08:29:42 +01:00