Owen Mansel-Chan
c170002fb1
Update test output
2026-06-04 13:52:05 +01:00
Owen Mansel-Chan
14e3ee2fb0
Add change note
2026-06-04 13:39:42 +01:00
Owen Mansel-Chan
50e0354911
Tidy up comments in isSink
2026-06-04 13:39:36 +01:00
Owen Mansel-Chan
101812310c
Inline isCloseCall into isSink
2026-06-04 13:39:24 +01:00
Owen Mansel-Chan
c87bfd5f28
Remove redundant call to isCloseSink
2026-06-04 13:09:10 +01:00
Owen Mansel-Chan
05e21adc53
Accept test changes
2026-06-04 13:09:07 +01:00
Owen Mansel-Chan
f67d0ea961
Go: Account for deferred Close in writable-file-close query
...
A deferred Close runs at function exit, but the CFG splices it in at the exit node where it can be reached along paths that never execute Sync. The previous dominance check therefore produced a false positive when a statement followed the if-block that registered the defer (e.g. deferredCloseWithSync2). For deferred closes, require instead that a handled Sync post-dominates the point where the defer is registered, which guarantees Sync runs before Close on every path on which Close is registered. Non-deferred closes keep the existing dominance check.
2026-06-04 13:09:05 +01:00
Owen Mansel-Chan
5217ede621
Go: Tidy up comments in writable-file-close query
...
Correct the doc for unhandledCall (it also matches expression statements where the result is discarded) and remove a stale commented-out line in isWritableFileHandle.
2026-06-04 13:09:03 +01:00
Owen Mansel-Chan
59908124c1
Add test showing limits of DeferStmt in CFG
...
There are paths to the exit of the function which go through the defer
statement and paths which don't, so we add an optional call to the
deferred function. This causes FPs in the query as it stands.
2026-06-04 12:21:38 +01:00
Owen Mansel-Chan
d55ff83568
Merge pull request #21269 from owen-mc/go/improve-tests-for-varargs-flow
...
Go: improve tests for varargs flow
2026-06-03 12:39:46 +01:00
Owen Mansel-Chan
9dbe9adb00
Update tests
2026-06-02 09:34:03 +01:00
Owen Mansel-Chan
703cea2b65
Model panicking log functions better
2026-06-02 01:32:00 +01:00
Owen Mansel-Chan
e6e8e3d005
Taint doesn't flow through panicking functions
2026-06-02 01:31:44 +01:00
Owen Mansel-Chan
adc9b7714b
Accept changed test output
2026-06-02 00:57:06 +01:00
Owen Mansel-Chan
e706c5f444
Improve test for non-returning fns
2026-06-02 00:56:12 +01:00
Owen Mansel-Chan
8a1e6d4f64
Add missing QLDocs
2026-06-02 00:41:48 +01:00
Owen Mansel-Chan
1a747dd8be
(Trivial) Fix QLDoc grammar
2026-06-02 00:39:25 +01:00
Owen Mansel-Chan
28bb1a6870
Add change note
2026-06-02 00:16:23 +01:00
Owen Mansel-Chan
45b1253b23
Improve glog and klog tests
2026-06-02 00:16:21 +01:00
Owen Mansel-Chan
c99dab1d71
Improve glog (and klog) modelling
2026-06-02 00:16:19 +01:00
Owen Mansel-Chan
f3e3647209
Improve noretFunctions test
2026-06-02 00:16:17 +01:00
Owen Mansel-Chan
8d099cbe38
Recognize more non-returning logging functions
2026-06-02 00:15:58 +01:00
github-actions[bot]
cfb18c2477
Post-release preparation for codeql-cli-2.25.6
2026-05-29 12:04:35 +00:00
github-actions[bot]
8b6f969cdb
Release preparation for version 2.25.6
2026-05-29 11:27:54 +00:00
Henry Mercer
9bc0c1b1ab
Revert "Release preparation for version 2.25.6"
2026-05-29 12:13:50 +01:00
github-actions[bot]
44a914e40f
Release preparation for version 2.25.6
2026-05-25 10:23:26 +00:00
github-actions[bot]
9f64000962
Post-release preparation for codeql-cli-2.25.5
2026-05-18 15:20:31 +00:00
github-actions[bot]
e38616a2ef
Release preparation for version 2.25.5
2026-05-18 12:05:32 +00:00
Owen Mansel-Chan
0aaa7d0631
Update expected test output
2026-05-11 16:15:50 +01:00
Arieh Schneier
b94ab8d186
Add integration test for root internal test extraction
...
This test verifies that root internal test files (package foo, not
foo_test) are correctly extracted when the repository has both:
1. Root-level internal tests (main_test.go with package main)
2. Nested packages with tests (nested/nested_test.go)
This scenario reproduces the bug that was fixed: the old extractor
would select the wrong package variant and miss root internal test
files.
The test ensures:
- main_test.go (root internal test) is extracted
- nested/nested_test.go (nested test) is extracted
- All test functions from both files are present in the database
This prevents regression of the bug fix.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com >
2026-05-11 15:18:15 +10:00
github-actions[bot]
7610277199
Post-release preparation for codeql-cli-2.25.4
2026-05-05 10:10:06 +00:00
github-actions[bot]
88e1d86c27
Release preparation for version 2.25.4
2026-05-05 09:34:30 +00:00
Owen Mansel-Chan
b07d2fb7d7
Merge pull request #21740 from owen-mc/go/overlay-correctness
...
Go: improve accuracy of overlay annotations
2026-04-28 11:35:14 +01:00
Tom Hvitved
2e94b09e6f
Address review comments
2026-04-27 14:18:41 +02:00
Owen Mansel-Chan
710c1ba050
Make getACallee overlay[global]
...
Co-authored-by: Copilot <copilot@github.com >
2026-04-24 12:35:11 +01:00
Tom Hvitved
8e26fa1c81
Go: Avoid combinatorial explosion in mostRecentSideEffect when there are multiple entry points
2026-04-24 13:24:58 +02:00
Owen Mansel-Chan
57eaed4dcc
Refactor: remove fields from EncryptionOperation
...
Co-authored-by: Copilot <copilot@github.com >
2026-04-22 13:37:35 +01:00
Owen Mansel-Chan
6efb21314a
Merge pull request #21523 from owen-mc/docs/mad/barriers
...
Document models-as-data barriers and barrier guards and add change notes
2026-04-21 13:49:19 +01:00
github-actions[bot]
a0bab539bb
Post-release preparation for codeql-cli-2.25.3
2026-04-20 12:40:34 +00:00
github-actions[bot]
c861d99802
Release preparation for version 2.25.3
2026-04-20 09:27:23 +00:00
Owen Mansel-Chan
bc28e1726c
Refactor to get rid of duplication
2026-04-17 13:24:16 +01:00
Owen Mansel-Chan
9f4fd7fab0
Remove a data flow consistency exclusion
...
This is no longer needed.
2026-04-17 11:27:36 +01:00
Owen Mansel-Chan
f6135b70ea
Remove global function step from local flow
2026-04-16 11:15:01 +01:00
Owen Mansel-Chan
8f17b73796
Fix link formatting in change notes
2026-04-14 15:27:37 +01:00
Owen Mansel-Chan
c86ba38a4e
Add change notes
2026-04-14 15:27:31 +01:00
Henry Mercer
43c9b95e6f
Merge branch 'main' into post-release-prep/codeql-cli-2.25.2
2026-04-14 13:56:52 +01:00
Owen Mansel-Chan
7458674470
Merge pull request #21584 from owen-mc/shared/update-mad-comments
...
Shared: update code comments explaining models-as-data format to include barriers and barrier guards
2026-04-14 09:30:28 +01:00
github-actions[bot]
242090e0ac
Post-release preparation for codeql-cli-2.25.2
2026-04-06 13:49:20 +00:00
github-actions[bot]
4fe2f6d2b4
Release preparation for version 2.25.2
2026-04-06 10:30:38 +00:00
Óscar San José
59eec7ffa2
Merge branch 'main' of https://github.com/github/codeql into post-release-prep/codeql-cli-2.25.1
2026-03-30 10:51:12 +02:00