Tamas Vajk
05dd3fa0e7
Adjust review findings
2021-09-16 09:42:38 +02:00
Anders Schack-Mulligen
c0fd44c909
Dataflow: Sync.
2021-09-15 16:10:54 +02:00
Tom Hvitved
2730423ab2
C#: Upgrade script
2021-09-13 09:49:10 +02:00
Tom Hvitved
5d048a9518
C#: Drop redundant columns from files and folders relations
2021-09-13 09:49:09 +02:00
Tom Hvitved
0abfb00032
Merge pull request #6660 from hvitved/csharp/dotnet-exec-tracing-windows
...
C#: Handle `dotnet exec csc.dll` compiler calls on Windows
2021-09-13 09:07:50 +02:00
Andrew Eisenberg
9c0f18b88d
Remove incorrect directive
...
This directive should only be in the
pack.
2021-09-10 08:57:37 -07:00
Tom Hvitved
649c2ce188
Merge pull request #6586 from hvitved/dataflow/stage2-precise-call-ctx-take2
...
Data flow: Add precise call contexts to stage 2
2021-09-10 11:34:35 +02:00
Tom Hvitved
af0b9abab7
C#: Handle dotnet exec csc.dll compiler calls on Windows
2021-09-10 11:26:43 +02:00
Tom Hvitved
296d10fe2a
Data flow: Adjust callMayFlowThroughFwd pragmas
2021-09-10 09:21:24 +02:00
Tamás Vajk
ad04099ac2
Merge pull request #6630 from tamasvajk/feature/interface-runtimecallable
...
C# Extend runtime callables to cover interface members with default implementation
2021-09-09 17:24:55 +02:00
Tamas Vajk
abe6c90829
Update change note
2021-09-09 13:04:47 +02:00
Tamas Vajk
0a17ab9325
Merge branch 'main' into feature/service-stack
2021-09-09 13:01:43 +02:00
Tamas Vajk
9ab6c29cd3
Extend runtime callables to cover interface members with default implementation
2021-09-08 15:07:49 +02:00
Anders Schack-Mulligen
1af39f0776
Dataflow: Sync.
2021-09-08 13:02:07 +02:00
Anders Schack-Mulligen
2b7882e6e5
Merge pull request #5032 from aschackmull/dataflow/subpaths
...
Dataflow: Add subpaths query predicate.
2021-09-08 11:52:41 +02:00
Tamás Vajk
f90d1fd70e
Merge pull request #6636 from tamasvajk/fix/stubbing-2
...
C#: Fix member order (yet again) in stubbing
2021-09-07 17:37:29 +02:00
Rasmus Wriedt Larsen
995a8192a9
Merge pull request #6635 from github/RasmusWL/fix-csharp-cwe-tag
...
C#: Fix CWE tag for `cs/insufficient-key-size`
2021-09-07 15:54:42 +02:00
Tamas Vajk
469993f6d3
C#: Fix member order (yet again) in stubbing
...
With explicit interface implementation, the same member name can show up multiple times in a type declaration. This commit defines an explicit order
for these members.
2021-09-07 15:26:03 +02:00
Tamás Vajk
d7934865c9
Merge pull request #6628 from tamasvajk/feature/fix-stub-escaping
...
C#: improve stubbing to escape more member names (not just fields)
2021-09-07 14:29:44 +02:00
Tom Hvitved
bef05f885c
C#: Update CIL data flow tests
2021-09-07 13:02:20 +02:00
Anders Schack-Mulligen
f30dad7705
Dataflow: Update test expected outputs.
2021-09-07 13:02:20 +02:00
Rasmus Wriedt Larsen
8f52089475
C#: Fix CWE tag for cs/insufficient-key-size
...
Since this targets
CWE-326 Inadequate Encryption Strength
> The software stores or transmits sensitive data using an encryption scheme that is theoretically sound, but is not strong enough for the level of protection required.
> \- https://cwe.mitre.org/data/definitions/326.html
and not
CWE-327: Use of a Broken or Risky Cryptographic Algorithm
> The use of a broken or risky cryptographic algorithm is an unnecessary risk that may result in the exposure of sensitive information.
> \- https://cwe.mitre.org/data/definitions/327.html
This matches what we do for similar query in Python: https://github.com/github/codeql/blob/main/python/ql/src/Security/CWE-326/WeakCryptoKey.ql
2021-09-07 12:59:10 +02:00
Anders Schack-Mulligen
7ec1fa2ebe
Dataflow: Sync.
2021-09-07 12:51:42 +02:00
Anders Schack-Mulligen
3c3d71d4a0
Dataflow: Sync
2021-09-07 12:51:42 +02:00
Tamás Vajk
1dc712f54d
Merge pull request #6629 from tamasvajk/feature/dispatch-fix
...
C#: Fix dispatch library to handle summarized callables with no runti…
2021-09-07 12:35:45 +02:00
Tamas Vajk
203ca3f91b
C#: improve stubbing to escape more member names (not just fields)
2021-09-07 12:34:23 +02:00
Tamás Vajk
7befdc9c5c
Merge pull request #6627 from tamasvajk/feature/stub-readme
...
C#: Add readme to stub folder
2021-09-07 12:09:52 +02:00
Tamás Vajk
c63fd4a254
Merge pull request #6260 from tamasvajk/feature/method-name
...
C#: Change generic method names to include <> and type args/params
2021-09-07 12:09:27 +02:00
Tamas Vajk
3a9cf639bd
Change ServiceStack redis sinks to code injection instead of SQL injection
2021-09-06 16:59:31 +02:00
Tamas Vajk
5fa9f16c01
Adjust ServiceStack CSV rows with generic method names
2021-09-06 16:45:21 +02:00
Tamas Vajk
f6366e1e1f
Merge branch 'feature/method-name' into feature/service-stack
2021-09-06 15:52:08 +02:00
Tamas Vajk
207d8f6030
Merge branch 'main' into feature/service-stack
2021-09-06 15:46:43 +02:00
Tamas Vajk
5014ef2337
C#: Add ServiceStack support with CSV data model
2021-09-06 14:06:37 +02:00
Tamas Vajk
43ccc14162
Add ServiceStack stubs and empty test referencing it
2021-09-06 14:05:41 +02:00
Tamas Vajk
e3a49f8213
C#: improve stubbing to escape more member names (not just fields)
2021-09-06 14:02:42 +02:00
Tamas Vajk
270b56af1b
Extend runtime callables to interface members with default implementation
2021-09-06 14:02:42 +02:00
Tamas Vajk
39a88d2e43
Fix dispatch library to handle summarized callables with no runtime target
2021-09-06 14:02:42 +02:00
Tamas Vajk
648197db35
C#: Fix dispatch library to handle summarized callables with no runtime target
2021-09-06 13:45:43 +02:00
Tamas Vajk
0d88d18781
C#: Add readme to stub folder
2021-09-06 13:42:36 +02:00
Andrew Eisenberg
bb9911e06f
Merge pull request #6605 from aeisenberg/aeisenberg/pack/consistency
2021-09-06 04:40:58 -07:00
Tamas Vajk
b7f13a7e1f
C#: Change generic method names to include <> and type args/params
2021-09-06 11:48:22 +02:00
Andrew Eisenberg
6a47fcaf1f
Packaging: Normalize all qlpack.yml files for all languages
...
This commit ensures consistency among all of our qlpacks. Here are the
changes:
1. Ensure only modern references are used (codeql-{lang} is converted to
codeql/{lang}-all or codeql/{lang}-queries where appropriate).
2. Use consistent version numbers. All languages are at 0.0.2 except
javascript, which is 0.0.3.
3. Convert all `libraryPathDependencies` to `dependencies` with version
constraints
4. Dependencies from query packs to other packs are always `"*"` since
these dependencies are always from source and we should get the
latest.
5. Dependencies from codeql/{lang}-lib to codeql/{lang}-upgrades must
be strict since there is a tight connection between the libary
and its relevant upgrades.
2021-09-03 11:53:28 -07:00
Tamas Vajk
c02a743835
Revert redundant order by
2021-09-03 16:51:32 +02:00
Tamas Vajk
3560853f36
C#: Fix ordering of stubbed type members, implemented interfaces, and location comments
2021-09-03 09:53:34 +02:00
Tamás Vajk
82f61ca015
Merge pull request #6577 from tamasvajk/fix/cil-modified-pointer
...
C#: Temporarily extract modified pointers as unmodified during CIL ex…
2021-09-02 10:48:51 +02:00
Tom Hvitved
c3ecae503b
Data flow: Sync files
2021-09-01 19:58:47 +02:00
Tom Hvitved
136c8b5192
Data flow: Improve callMayFlowThroughFwd join order
...
Before:
```
[2021-08-25 09:56:29] (1395s) Tuple counts for DataFlowImpl2::Stage3::callMayFlowThroughFwd#ff/2@111fb3:
15495496 ~5% {5} r1 = SCAN DataFlowImpl2::Stage3::fwdFlowOutFromArg#fffff#reorder_0_2_4_1_3 OUTPUT In.3, In.4, In.2 'config', In.0 'call', In.1
1450611958 ~6335% {5} r2 = JOIN r1 WITH DataFlowImpl2::Stage3::fwdFlow#fffff_03412#join_rhs ON FIRST 3 OUTPUT Lhs.3 'call', Lhs.4, Lhs.2 'config', Rhs.3, Rhs.4
7043648 ~20415% {2} r3 = JOIN r2 WITH DataFlowImpl2::Stage3::fwdFlowIsEntered#fffff#reorder_0_3_4_1_2 ON FIRST 5 OUTPUT Lhs.0 'call', Lhs.2 'config'
return r3
```
After:
```
[2021-08-25 10:57:02] (2652s) Tuple counts for DataFlowImpl2::Stage3::callMayFlowThroughFwd#ff/2@d3e27b:
15495496 ~0% {6} r1 = SCAN DataFlowImpl2::Stage3::fwdFlowOutFromArg#fffff#reorder_0_2_4_1_3 OUTPUT In.0 'call', In.1, In.2 'config', In.3, In.4, In.2 'config'
9236888 ~22% {7} r2 = JOIN r1 WITH DataFlowImpl2::Stage3::fwdFlowIsEntered#fffff#reorder_0_3_4_1_2 ON FIRST 3 OUTPUT Lhs.3, Rhs.3, Rhs.4, Lhs.4, Lhs.5, Lhs.0 'call', Lhs.2 'config'
7043648 ~20415% {2} r3 = JOIN r2 WITH DataFlowImpl2::Stage3::fwdFlow#fffff ON FIRST 5 OUTPUT Lhs.5 'call', Lhs.6 'config'
return r3
```
2021-09-01 19:57:29 +02:00
Tamás Vajk
e9ff6e8755
Merge pull request #6578 from tamasvajk/fix/cil-local-decoding
...
C#: Handle non-critical exception in CIL local variable extraction
2021-09-01 12:52:53 +02:00
Tamas Vajk
b267d26ff8
C#: Fix completely broken type argument extraction in NoMetadataHandleType
2021-08-31 14:34:27 +02:00
Tamas Vajk
d6ae19c87d
C#: Handle non-critical exception in CIL local variable extraction
2021-08-31 14:29:53 +02:00