Mathias Vorreiter Pedersen
ad5619ff07
Revert "C++: Don't count write operations as uses."
...
This reverts commit 092beb8b73 .
2021-11-03 10:37:32 +00:00
ihsinme
c175f0aa9d
Update IncorrectChangingWorkingDirectory.ql
2021-11-03 12:25:30 +03:00
Mathias Vorreiter Pedersen
4a2894a707
Merge pull request #7025 from MathiasVP/nomagic-parameterCand
...
Dataflow: Replace a 'noinline' pragma with a 'nomagic' pragma
2021-11-02 20:40:44 +00:00
ihsinme
62b3c3c9a0
Update IncorrectChangingWorkingDirectory.ql
2021-11-02 16:16:17 +03:00
ihsinme
738354b8e7
Update cpp/ql/src/experimental/Security/CWE/CWE-243/IncorrectChangingWorkingDirectory.ql
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2021-11-02 16:13:34 +03:00
Mathias Vorreiter Pedersen
3e6ac74d73
C++: Add 'InheritanceConversionInstruction' to the list of instructions that set 'certain = false' in 'explicitWrite'.
2021-11-02 13:02:46 +00:00
Mathias Vorreiter Pedersen
56cabb8f46
C++: Add comments to some of the disjuncts in 'addressFlow'.
2021-11-02 12:52:11 +00:00
Anders Schack-Mulligen
7d0152f3c0
Merge pull request #6932 from aschackmull/dataflow/flow-features
...
Dataflow: Add support for call context restrictions on sources/sinks.
2021-11-02 13:24:17 +01:00
Mathias Vorreiter Pedersen
6f4107ff23
Dataflow: Replace a 'noinline' pragma with a 'nomagic' pragma.
2021-11-02 11:37:40 +00:00
Mathias Vorreiter Pedersen
092beb8b73
C++: Don't count write operations as uses.
2021-11-02 10:59:34 +00:00
Geoffrey White
c1de4165a9
Update cpp/ql/lib/semmle/code/cpp/commons/NullTermination.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2021-11-02 10:51:35 +00:00
CodeQL CI
d5e2026a26
Merge pull request #6934 from erik-krogh/more-instanceof
...
Approved by MathiasVP, esbena, yoff
2021-11-02 03:46:23 -07:00
CodeQL CI
5d62aa5b29
Merge pull request #6994 from erik-krogh/redundant-cast
...
Approved by RasmusWL, aschackmull, esbena, geoffw0, hvitved, nickrolfe
2021-11-02 03:45:48 -07:00
ihsinme
9b8b916199
Update IncorrectChangingWorkingDirectory.ql
2021-11-02 11:33:29 +03:00
Geoffrey White
dec7f93097
C++: Eliminate mutual recursion.
2021-11-01 17:32:38 +00:00
Geoffrey White
d6a714cf69
C++: Improve comments.
2021-11-01 17:32:37 +00:00
Jonas Jensen
93dfee866a
C++: Add isFromSystemMacroDefinition predicate
2021-11-01 09:17:49 +01:00
ihsinme
3161d112d1
Update IncorrectChangingWorkingDirectory.ql
2021-10-30 13:47:22 +03:00
Mathias Vorreiter Pedersen
d34e731f1d
C++: Add a small QLDoc novel above the IPA type for 'TIRDataFlowNode'.
2021-10-30 11:29:07 +01:00
Mathias Vorreiter Pedersen
d624259eab
C++: Add QLDoc to 'flowOutOfAddressStep'.
2021-10-30 10:46:39 +01:00
Mathias Vorreiter Pedersen
a75f195df3
C++: Several readability fixes:
...
1. Added lots of QLDoc explanation about the role of StoreNodeOperand.
2. Renamed '{StoreNode,ReadNode}.getAPredecessor' to 'getInner' and
'{StoreNode,ReadNode}.getASuccessor' to 'getOuter'.
3. Be more explicit about which type of 'StoreNode' is used in various
places.
2021-10-30 10:24:06 +01:00
Mathias Vorreiter Pedersen
f334201fce
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
...
Co-authored-by: Jonas Jensen <jbj@github.com >
2021-10-30 10:04:17 +01:00
Mathias Vorreiter Pedersen
cb4f10c609
C++: Move the union field check to the IPA branch of 'TFieldContent'.
2021-10-30 10:04:17 +01:00
Mathias Vorreiter Pedersen
8a569da370
C++: Fix comments.
2021-10-29 14:05:34 +01:00
Erik Krogh Kristensen
d36c66cfca
remove redundant inline casts in arguments where the type is inferred by the call target
2021-10-29 14:37:56 +02:00
Anders Schack-Mulligen
3a1836c9f6
Merge pull request #7000 from aschackmull/dataflow/interface-refactor
...
Dataflow: Refactor public references to DataFlowCallable
2021-10-29 12:21:13 +02:00
Anders Schack-Mulligen
5951ae79b9
Dataflow: Add language specific predicates.
2021-10-29 11:11:35 +02:00
Anders Schack-Mulligen
00df6798b1
Dataflow: Sync
2021-10-29 11:00:23 +02:00
Mathias Vorreiter Pedersen
e94b2b6113
Merge pull request #6915 from geoffw0/nullterm2
...
C++: Fix the two null termination queries and re-enable them.
2021-10-29 08:20:08 +01:00
ihsinme
635a668670
Update IncorrectChangingWorkingDirectory.ql
2021-10-29 10:08:41 +03:00
ihsinme
c8a4a8b965
Update InsecureTemporaryFile.ql
2021-10-29 09:44:43 +03:00
Mathias Vorreiter Pedersen
490156d7db
C++: Remove the 'isIndirection' predicate on 'SourceVariable' and move the rootdef of 'getIRVariable' into the two subclasses.
2021-10-28 17:26:28 +01:00
Mathias Vorreiter Pedersen
05900cda87
C++: Rename 'Ssa' to 'SsaInternals' and move definitions from 'SSaImplSpecific' to 'SsaInternals'. Now we can avoid cyclic imports.
2021-10-28 17:10:48 +01:00
Erik Krogh Kristensen
15c90adec5
remove redundant cast where the type is enforced by an equality comparison
2021-10-28 18:08:20 +02:00
Erik Krogh Kristensen
e75448ebb0
remove redundant inline casts
2021-10-28 16:35:53 +02:00
Mathias Vorreiter Pedersen
675e284c0e
C++: A 'LoadInstruction' in a store chain always sets 'certain = false'.
2021-10-28 14:52:57 +01:00
Mathias Vorreiter Pedersen
ee2541c3bc
C++: Fix QLDoc on 'getDestinationAddress'.
2021-10-28 14:12:22 +01:00
Mathias Vorreiter Pedersen
cde80ccf83
Replace 'hasLocationInfo' with 'getLocation'.
2021-10-28 14:09:26 +01:00
Mathias Vorreiter Pedersen
387c96d1e2
Rename 'SourceVariable.getVariable' to 'SourceVariable.getIRVariable' and replace 'Def.getVariable' to 'Def.getSourceVariable'.
2021-10-28 14:00:50 +01:00
Mathias Vorreiter Pedersen
12e0185b0d
C++: Sync identical files.
2021-10-28 12:36:36 +01:00
Mathias Vorreiter Pedersen
2cd23e5ee0
Accept test changes.
2021-10-28 12:36:36 +01:00
Mathias Vorreiter Pedersen
8135dcefdd
Merge branch 'main' into use-shared-ssa-in-ir-dataflow
2021-10-28 12:36:25 +01:00
Mathias Vorreiter Pedersen
521d863429
C++: Autoformat.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
2547a8d746
C++: Fix join orders in 'DataFlowDispatch.qll' and Ssa.qll.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
21a1ee7758
C++: Add annoying case in SSA.qll related to 'NewExpr' and accept test changes.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
3efe60fdd2
C++: Accept test changes.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
5dbaea8b52
C++: Add a special dataflow step from InitializeIndirection instructions.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
b1ea00fa85
C++: Remove the taintflow edges that gives performance problems.
2021-10-28 12:35:01 +01:00
Mathias Vorreiter Pedersen
710d0cfc3d
C++: Since we now no longer have flow from exact memory operands to LoadInstructions, we no longer have flow from PhiInstructions to LoadInstructions. We could allow flow in this particular case, but we might as well use the shared SSA library's phi edges.
2021-10-28 12:35:00 +01:00
Mathias Vorreiter Pedersen
8caff41138
C++: Throw away most of the usage of IR-computed def-use information. Instead, we rely on the shared SSA library's use-use edges.
2021-10-28 12:35:00 +01:00