Michael Nebel
e29770c2b5
C#: Fix missing slash in comments.
2026-04-29 15:27:47 +02:00
Michael Nebel
615ae41e67
C#: Address review comments.
2026-04-28 11:47:13 +02:00
Michael Nebel
ae81f3a00f
C#: Inherited feeds may not get properly computed if a nuget.config file contains a clear. This has been fixed.
2026-04-28 11:47:11 +02:00
Michael Nebel
ed857ad6e0
C#: Make the restore sources project/solution specific.
2026-04-28 11:47:09 +02:00
Michael Nebel
831b4d6ceb
C#: Add NuGet package missing failures to the compilation info.
2026-04-28 11:47:05 +02:00
Michael Nebel
9bd4f65463
C#: Also apply feed exclusions to inherited feeds.
2026-04-28 11:47:03 +02:00
Michael Nebel
5ff4b43732
C#: Address review comment.
2026-04-28 11:47:01 +02:00
Michael Nebel
ca0c2746fc
C#: Address Copilots review comments.
2026-04-28 11:46:59 +02:00
Michael Nebel
6f888f1544
C#: Change the All NuGet feed reachable telemetry.
2026-04-28 11:46:52 +02:00
Michael Nebel
8372a37f74
C#: Only include feeds that we can connect to.
2026-04-28 11:46:50 +02:00
Michael Nebel
c0a1dd0524
C#: Only use the default package source when using nuget.exe if it is reachable.
2026-04-28 11:46:47 +02:00
Michael Nebel
e6df1d8d8a
C#: Handle special case when no feeds are reachable.
2026-04-28 11:46:45 +02:00
Michael Nebel
1ee6d631c6
C#: Rename ExtraArgs to NugetSources.
2026-04-28 11:46:43 +02:00
Michael Nebel
8369c926b1
C#: Simplify and improve the reachability check and improve the logging.
2026-04-28 11:46:40 +02:00
Michael Nebel
1dfe30deaf
C#: For specific listed nuget feeds in a project, still allow their use unless there is a timeout when trying to reach them.
2026-04-28 11:46:38 +02:00
Michael Nebel
21fb44d0ba
C#: Re-add the compilation information on reachable fallback NuGet feed count.
2026-04-28 11:46:36 +02:00
Michael Nebel
b95a8aa378
C#: Address review comments.
2026-04-28 11:46:34 +02:00
Michael Nebel
c53b2f589b
C#: Remove redundant out parameter from CheckSpecifiedFeeds.
2026-04-28 11:46:32 +02:00
Michael Nebel
4dad62c481
C#: Make sure that the feeds that excluded for the feed check (based on an environment variable setting) are still used as sources.
2026-04-28 11:46:29 +02:00
Michael Nebel
365b419b5e
C#: Add private registries to the set of explicit feeds. Always use specific sources for restoring if private registries are used of if nuget feed reachability check is performed.
2026-04-28 11:46:27 +02:00
Michael Nebel
132dc1fa26
C#: Turn checkNugetFeedResponsiveness into a field and remove some explicit this qualifiers.
2026-04-28 11:46:25 +02:00
Michael B. Gale
cce5f06086
Only use reachable feeds when private registries are configured
2026-04-28 11:46:22 +02:00
Michael B. Gale
17c45fcd75
Check reachability of inherited feeds
2026-04-28 11:46:20 +02:00
Michael B. Gale
9898e21ce7
Divide up CheckSpecifiedFeeds
2026-04-28 11:46:18 +02:00
Michael B. Gale
fdbaba896f
Use explicitFeeds directly
2026-04-28 11:46:16 +02:00
Michael B. Gale
8215737db9
Inline CheckFeeds
2026-04-28 11:46:13 +02:00
Michael B. Gale
439e37a198
Use GetReachableNuGetFeeds in CheckSpecifiedFeeds
2026-04-28 11:46:11 +02:00
Michael B. Gale
d22381a943
Refactor GetReachableNuGetFeeds out of GetReachableFallbackNugetFeeds
2026-04-28 11:46:08 +02:00
Michael B. Gale
454d13b485
Remove element check
2026-01-30 14:03:43 +00:00
Michael B. Gale
3e0719609f
Fix missing negation
2026-01-30 13:30:47 +00:00
Michael B. Gale
1b5ed129ac
Log and emit diagnostic if incorrectly named files are found
2026-01-30 13:19:46 +00:00
Michael B. Gale
5ba3b679dd
Move into if statement
2026-01-30 12:18:56 +00:00
Michael B. Gale
76fe3fa502
C#: Make sure allFeeds contains at least explicitFeeds
2026-01-29 21:43:44 +00:00
Michael Nebel
1b84f70d1c
C#: Use NuGet version sorting instead of lexicographic directory name sorting for finding newest package version.
2025-12-04 15:34:26 +01:00
Michael Nebel
e76e7ab26a
C#: Read from dependency directory from extractor option.
2025-11-21 10:39:51 +01:00
Martin Costello
77a6a2d442
Fix user-facing casing of NuGet
...
Fix user-facing strings to use "NuGet" instead of "Nuget" and "dotnet" instead of "Dotnet".
2025-06-02 09:30:16 +01:00
Michael B. Gale
2aee47b257
Merge pull request #18850 from github/mbg/csharp/inject-proxy-urls
...
C#: Automatically use configured private registry feeds
2025-03-27 10:11:05 +00:00
Michael B. Gale
be95d335b7
C#: Obtain all feeds from source directory if there are no nuget.config files anywhere
2025-03-25 11:29:06 +00:00
Michael B. Gale
73ca2eb2c5
C#: Use allFeeds rather than explicitFeeds for RestoreProjects
2025-03-25 10:44:29 +00:00
Michael B. Gale
4d3b0246b5
C#: Do not manually add public feed when private registries are used
2025-03-25 10:14:03 +00:00
Michael B. Gale
d2b88ae5a8
C#: Rename overloaded CheckFeeds method and fix comment
2025-03-25 10:07:08 +00:00
Michael B. Gale
4448369323
C#: Check that private package registry feeds are reachable
2025-03-24 17:27:22 +00:00
Michael B. Gale
92eab47def
C#: Refactor CheckFeeds to have an overloaded variant that accepts a given set of feeds.
2025-03-24 17:15:49 +00:00
Michael B. Gale
d564529f3c
C#: Change RestoreSettings to have general extraArgs parameter
...
This allows the string of package feeds to be constructed once and used repeatedly in the parallel restore loop as well.
2025-03-24 17:08:05 +00:00
Tamas Vajk
2054c869fb
C#: Fix buildless fallback restore logic
...
When dotnet core projects are restored, the dependency manager precisely tracks the referenced package folders. The fallback restore logic ignored the precise usage list and instead considered all subfolders in the restore location to be referenced, even though not all subfolders were added to the dependency list. This meant that packages downloaded in partially successful restores were available on disk, but not added to the dependency list by the normal restore process, and skipped by the fallback restore process. This commit fixes this problem by ensuring that the fallback restore logic doesn't consider all subfolders in the restore location to be referenced, but only those that were added to the dependency list by the normal restore process.
2025-03-18 09:51:39 +01:00
Michael B. Gale
51874b8ef0
Apply suggestions from code review
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2025-03-17 14:24:04 +00:00
Michael B. Gale
95605935fa
C#: Fix .ToList() being called on null
2025-03-14 14:02:38 +00:00
Michael B. Gale
a8dde15a87
C#: Only provide feeds on command line if Dependabot proxy is enabled
2025-03-14 13:47:05 +00:00
Michael B. Gale
0db6a269e4
C#: Propagate explicit feeds to RestoreProjects
2025-03-14 13:39:27 +00:00
Michael Nebel
684c80c31a
C#: Address review comments.
2024-12-10 13:13:11 +01:00
