Tamas Vajk
2054c869fb
C#: Fix buildless fallback restore logic
...
When dotnet core projects are restored, the dependency manager precisely tracks the referenced package folders. The fallback restore logic ignored the precise usage list and instead considered all subfolders in the restore location to be referenced, even though not all subfolders were added to the dependency list. This meant that packages downloaded in partially successful restores were available on disk, but not added to the dependency list by the normal restore process, and skipped by the fallback restore process. This commit fixes this problem by ensuring that the fallback restore logic doesn't consider all subfolders in the restore location to be referenced, but only those that were added to the dependency list by the normal restore process.
2025-03-18 09:51:39 +01:00
Michael B. Gale
51874b8ef0
Apply suggestions from code review
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2025-03-17 14:24:04 +00:00
Michael B. Gale
284f612965
C#: Use StringBuilder for feed arguments in GetRestoreArgs
2025-03-14 14:06:48 +00:00
Michael B. Gale
b6c74fe306
C#: Narrow Exception to JsonException
2025-03-14 14:05:27 +00:00
Michael B. Gale
95605935fa
C#: Fix .ToList() being called on null
2025-03-14 14:02:38 +00:00
Michael B. Gale
a8dde15a87
C#: Only provide feeds on command line if Dependabot proxy is enabled
2025-03-14 13:47:05 +00:00
Michael B. Gale
6b15f77168
C#: Fix test failures
2025-03-14 13:39:28 +00:00
Michael B. Gale
0db6a269e4
C#: Propagate explicit feeds to RestoreProjects
2025-03-14 13:39:27 +00:00
Michael B. Gale
726123c0cb
C#: Allow specifying package feeds for dotnet restore as command line arguments
2025-03-14 13:39:26 +00:00
Michael B. Gale
11efb55aa1
C#: Parse environment variables to obtain list of registry URLs
2025-03-14 13:39:26 +00:00
Michael B. Gale
63d5517d7c
C#: Add list of registries to DependabotProxy
2025-03-14 13:39:25 +00:00
Michael B. Gale
6b2f348c4c
C#: Add CODEQL_PROXY_URLS environment variable
2025-03-14 13:39:23 +00:00
Michael Nebel
fb3ce464be
C#: Address review comments.
2025-03-06 11:48:35 +01:00
Michael Nebel
5c931fa897
C#: Improve comments.
2025-03-05 09:50:52 +01:00
Michael Nebel
d5ee93dbbc
C#: Anonymous types should not be considered unknown.
2025-03-05 09:04:58 +01:00
Michael Nebel
fc5a49ef84
C#: Handle some broken types in BMN.
2025-03-05 09:04:54 +01:00
Michael Nebel
e835d8b168
C#: Change the populate logic context. It looks like a mistake that the only flag set is Standalone.
2025-03-05 09:04:53 +01:00
Michael Nebel
c2b835da40
C#: Re-factor the check whether we are in standalone mode.
2025-03-05 09:04:52 +01:00
Michael Nebel
7e18b3e016
Merge pull request #18533 from michaelnebel/csharp/partialmembers
...
C# 13: Partial properties and indexers.
2025-02-03 13:18:43 +01:00
Michael Nebel
0453ae8dbd
C#: Use property- and indexer implementation location and extract the accessor implementations instead of declarations.
2025-01-27 10:09:42 +01:00
Tom Hvitved
ac4f82cfbb
C#: Verify that downloaded .NET CLIs are executable
2025-01-24 15:14:58 +01:00
Michael Nebel
260ce805d1
C#: Also support implicit inherited ToString synthetic calls.
2025-01-16 16:57:29 +01:00
Michael Nebel
6a406b28d1
C#: Do not insert a synthetic ToString call in interpolation expressions, if the type implements IFormattable.
2025-01-14 17:14:57 +01:00
Michael Nebel
5f539c5515
C#: Make synthetic ToString calls in string interpolation expressions.
2025-01-14 17:13:50 +01:00
Michael Nebel
908a3e3563
C#: Make synthetic ToString calls in binary add expressions.
2025-01-14 17:13:46 +01:00
Michael Nebel
c68b55b957
Merge pull request #18385 from michaelnebel/csharp/allowsrefstruct
...
C# 13: Allows ref struct.
2025-01-13 16:04:03 +01:00
Michael B. Gale
b0f0a24b6a
C#: Override env vars in DotNetCliInvoker if already set
2025-01-10 11:36:02 +00:00
Michael B. Gale
f78c6e0924
C#: Remove incorrect log message from DependabotProxy
2025-01-10 11:35:14 +00:00
Tamas Vajk
c9fab0b071
C#: Change source generated razor file paths to be relative to csproj
2025-01-06 11:10:28 +01:00
Michael Nebel
41dc4a5503
C#: Add extractor support for the allows ref struct general type parameter constraint.
2025-01-03 15:36:00 +01:00
Michael Nebel
958d8f1f01
C#: Add extractor support for the notnull general type parameter constraint.
2025-01-03 15:35:49 +01:00
Michael Nebel
a52a549945
Merge pull request #18246 from michaelnebel/csharp/fixwarnings
...
C#: Fix some new compiler warnings
2024-12-12 15:07:23 +01:00
Michael Nebel
684c80c31a
C#: Address review comments.
2024-12-10 13:13:11 +01:00
Michael Nebel
86c6df5cbd
C#: Log warning when chain or certificate is not provided in the validation.
2024-12-10 10:35:48 +01:00
Michael Nebel
547af6c3c9
C#: Introduce null checks in the NugetPackageRestorer.
2024-12-10 10:31:12 +01:00
Michael Nebel
4275813b87
C#: Make the path tests independent.
2024-12-10 09:58:14 +01:00
Michael Nebel
5624a77176
C#: Use TEST_TEMPDIR when set for test files.
2024-12-09 13:59:59 +01:00
Cornelius Riemenschneider
526dbe5901
Address review, also run semmle-util tests.
2024-12-09 12:19:01 +01:00
Cornelius Riemenschneider
18560cde9d
C#: Shorten test target names to make Windows happy.
2024-12-09 10:54:04 +01:00
Michael Nebel
4e079d34b9
C#: Clean up dependencies Newtonsoft.Json and dont override nowarn.
2024-12-06 15:55:30 +01:00
Michael B. Gale
e16adda74d
Merge pull request #18029 from github/mbg/csharp/set-proxy-cert-file
2024-12-06 14:03:43 +00:00
Michael B. Gale
c8ccfe40a5
C#: Create certificate from string, rather than file
2024-12-06 13:13:41 +00:00
Michael B. Gale
653d68ea94
C#: Explicitly close writer in DependabotProxy
2024-12-06 13:13:15 +00:00
Michael Nebel
9715ffd9a4
Merge pull request #18205 from michaelnebel/csharp/narrowpatterntypes
...
C#: Narrow pattern types
2024-12-06 10:33:13 +01:00
Michael B. Gale
952488c2d8
C#: Fix possible null dereference
2024-12-05 12:32:55 +00:00
Michael B. Gale
7369d043ed
C#: Don't initialise DependabotProxy on Windows or macOS
2024-12-05 12:25:45 +00:00
Michael B. Gale
2e80e09f52
C#: Apply suggestions from code review for DependabotProxy
2024-12-05 12:15:27 +00:00
Michael B. Gale
ee7f0b0f2a
C#: Load Dependabot Proxy certificate in DependabotProxy, and implement IDisposable
2024-12-05 12:15:26 +00:00
Michael B. Gale
ca251fb840
C#: Set up proxy for IsFeedReachable, if configured
2024-12-05 12:15:23 +00:00
Michael B. Gale
984091d4a4
C#: Propagate DependabotProxy instance down from DependencyManager
2024-12-05 12:14:29 +00:00
