Michael Nebel
6ecbb400d7
C#: Turn initialize into a readonly field.
2023-08-14 11:19:42 +02:00
Michael Nebel
d76bb49b6a
C#: Make some FileContent unit tests.
2023-08-14 11:18:19 +02:00
Michael Nebel
a0bad3ce15
C#: Re-factor FileContent to make it unit-testable and make an initializer class.
2023-08-14 11:18:19 +02:00
Michael Nebel
a362ce083d
C#: Some file content regexp tweaking.
2023-08-14 11:18:19 +02:00
Michael Nebel
c95d219c84
C#: Re-factor the processing of all files into a helper class and make sure to only do one pass of the files.
2023-08-14 11:18:19 +02:00
Michael Nebel
db685e5fc4
C#: Tidy up.
2023-08-14 11:18:19 +02:00
Michael Nebel
e24fa4705a
C#: Introduce caching or detecting the newest runtimes and fetching all file names in the source dir.
2023-08-14 11:18:19 +02:00
Michael Nebel
ddb50b8120
C#: Improve regular expressions and fix lowercase issue.
2023-08-14 11:18:19 +02:00
Michael Nebel
ca7fa2e7c8
C#: Use ASP.NET dlls when needed and available.
2023-08-14 11:18:19 +02:00
Michael Nebel
b71c41018c
C#: Re-factor the GetRuntime method.
2023-08-14 11:18:19 +02:00
Michael Nebel
5bc8804242
C#: Introduce method to decide whether we need to include ASP.NET dlls in standalone compilation.
2023-08-14 11:18:19 +02:00
Michael Nebel
88b51e6ad3
C#: Re-factor logic for fetching info from group and remove a redundant continue statement.
2023-08-14 11:18:18 +02:00
Michael Nebel
881d86321e
C#: Introduce regex for framework reference and project sdk and make some minor re-writes.
2023-08-14 11:18:18 +02:00
Michael Nebel
9e03a211a5
C#: Add unit test where path to dotnet frameworks contain whitespaces.
2023-08-14 10:40:00 +02:00
Michael Nebel
1942ea8396
C#: Paths can contain whitespace (this is indeed common on windows).
2023-08-14 10:40:00 +02:00
Michael Nebel
280a27d9ca
C#: Log some more info during dotnet --list-runtimes execution.
2023-08-14 10:40:00 +02:00
Michael Nebel
78c732db97
C#: Re-factor of ProgressMonitor and introduce LogInfo.
2023-08-14 10:40:00 +02:00
Michael Nebel
ef9453e862
C#: Selected runtime location should be logged as information.
2023-08-14 10:40:00 +02:00
Michael Nebel
6bb9e6d122
C#: Address review comments.
2023-08-07 13:40:37 +02:00
Michael Nebel
ab4e643bf8
C#: Turn RuntimeVersion into a record type.
2023-08-01 12:54:55 +02:00
Tamas Vajk
35cc058474
C#: Fix test expectations in RuntimeVersion tests to handle platform dependent behaviour of Path.Combine
2023-07-13 09:50:26 +02:00
Tamas Vajk
65ed244f34
C#: Add missing parameter to interface
2023-07-07 16:10:41 +02:00
Tamás Vajk
9cef290bc3
Merge pull request #13687 from tamasvajk/standalone/nugetconfig
...
C#: Use `nuget.config` file for `dotnet restore` fallback logic
2023-07-07 15:53:07 +02:00
Tamas Vajk
23f3e44fa1
C#: Use nuget.config file for dotnet restore fallback logic
2023-07-07 14:47:07 +02:00
Michael Nebel
e4aaa43c43
C#: Also support alpha, beta, rc candidates.
2023-07-07 14:06:11 +02:00
Michael Nebel
f065ba9aa1
C#: Add unit tests for runtime version fetching.
2023-07-07 13:21:02 +02:00
Michael Nebel
4270425f14
C#: Cater for preview versions.
2023-07-07 13:16:35 +02:00
Michael Nebel
bffdbbcf95
C#: Address review comments.
2023-07-07 13:16:34 +02:00
Michael Nebel
6a87755ff1
C#: Use dotnet --list-runtimes to find runtime locations.
2023-07-06 13:27:22 +02:00
Tamás Vajk
14caaf119c
Merge pull request #13658 from tamasvajk/cs/standalone/restore-impr
...
C#: Improve dotnet restore success rate in standalone extraction
2023-07-06 10:10:05 +02:00
Tamas Vajk
d0b8b683af
Adjust error handling when dotnet --info is called
2023-07-05 14:26:00 +02:00
Tamas Vajk
9b2fd8df9f
Add todo comment
2023-07-04 14:03:04 +02:00
Tamas Vajk
ffc09c44c2
Minor fixes in standalone extraction
2023-07-04 13:54:23 +02:00
Tamas Vajk
ef0e102cd7
Retrieve package IDs from files and restore the not yet restored ones
...
Read all files in the repo and look for `PackageReference` XML elements
to extract the package IDs, then restore the packages that are not yet
restored. This change improves the percentage of found assemblies on the
Powershell repo from 95% to 97% compared to a traced extraction. Also,
it increases the number of assemblied only referenced in the standalone
extraction from 79 to 134.
2023-07-04 13:52:12 +02:00
Tamas Vajk
cd6419503f
Execute dotnet restore on all projects in standalone
...
Previously, we only did this for the solution files in the repository, but
there might be projects that are not added to any solution. This change
improves the percentage of found assemblies on the Powershell repo from
81% to 95%.
2023-07-04 13:52:12 +02:00
Tamas Vajk
728f3bce2d
Refactor dotnet restore command invocation
2023-07-04 13:52:12 +02:00
Tamas Vajk
d2b0c872f5
Code quality improvements
2023-07-04 13:52:12 +02:00
Tamas Vajk
2de356dbfe
C#: Remove the renaming of Directory.Build.props from standalone extraction
2023-06-29 15:06:46 +02:00
Tamas Vajk
cdf1c2639d
C#: Only include CoreLib.dll when UseMscorlib option is set
2023-06-12 11:03:26 +02:00
Tamas Vajk
bf3677df16
C#: Make sure System.Private.CoreLib is added only once as a reference in standalone extraction
2023-06-09 11:29:44 +02:00
Tamás Vajk
ccb622348b
Merge pull request #13382 from tamasvajk/feature/standalone-dll-unsafe
...
C#: Change standalone extraction to allow unsafe code
2023-06-07 14:37:11 +02:00
Tamás Vajk
8fe025eb64
Merge pull request #13384 from tamasvajk/fix/standalone-explicit-interface-error
...
C#: Improve error message for missing explicit interface implementation
2023-06-07 12:19:08 +02:00
Tamas Vajk
0f75449abb
Improve code quality
2023-06-07 10:40:58 +02:00
Tamás Vajk
e8f56f2981
Update csharp/extractor/Semmle.Extraction.CSharp/Entities/Method.cs
...
Co-authored-by: Michael B. Gale <mbg@github.com >
2023-06-06 16:20:48 +02:00
Tamas Vajk
a4dec591c7
C#: Improve error message for missing explicit interface implementation
2023-06-06 15:01:54 +02:00
Tamas Vajk
75bc8756f2
C#: Change standalone extraction to allow unsafe code
2023-06-06 14:43:09 +02:00
Michael Nebel
9aeb2384f3
C#: Improve LINQ expression based on review comments.
2023-06-01 10:20:54 +02:00
Michael Nebel
43d6bf04b5
C#: Make synthetic implicit casts when values are provided using the DefaultParameterValue attribute.
2023-05-31 14:45:19 +02:00
Tamas Vajk
74a585222c
C#: Extract source files generated by source generators
2023-05-26 09:13:41 +02:00
Michael Nebel
2ca543e217
C#: Synthetic DateTime object creation for DateTime defaults via attributes.
2023-05-22 14:16:37 +02:00
