Tom Hvitved
04279531e7
C#: Remove @precision for new date queries
...
Removing the `@precision` annotation until we know how precise these queries
actually are for projects on LGTM.com.
2019-06-27 10:33:27 +02:00
Tom Hvitved
b6cf13510c
C#: Update @name for two queries
2019-06-27 10:22:56 +02:00
semmle-qlci
1c25e17812
Merge pull request #1505 from hvitved/csharp/autoformat
...
Approved by calumgrant
2019-06-27 08:03:58 +01:00
semmle-qlci
f58c7cc79c
Merge pull request #1446 from hvitved/csharp/cached-stages
...
Approved by calumgrant
2019-06-27 08:03:24 +01:00
Calum Grant
76454ed68a
C#: Fix formatting of arrays and NullableTypes
2019-06-26 20:24:56 +01:00
Calum Grant
abf43dabe5
C#: Address review comments. Fix up toStringWithTypes(), and deprecate predicates in TypeParameterConstraints.
2019-06-26 20:24:56 +01:00
Calum Grant
620ecc8128
C#: Address review comments part 1.
2019-06-26 20:24:56 +01:00
Calum Grant
35ecb948fc
C#: Fix qltests.
2019-06-26 20:24:55 +01:00
Calum Grant
abe961f094
C#: Remove disabled and not-applicable nullability annotations since they can be deduced.
2019-06-26 20:24:55 +01:00
Calum Grant
d46848ed10
C#: Make Annotations module private. Update comments.
2019-06-26 20:24:55 +01:00
Calum Grant
b7e8f46172
C#: DB upgrade script.
2019-06-26 20:24:55 +01:00
Calum Grant
f9099653a6
C#: Do not extract type annotations that can be deduced. Put specific_type_parameter_annotation on the side of specific_type_parameter_constraints.
2019-06-26 20:24:55 +01:00
Calum Grant
31655c22f1
C#: Stats update
2019-06-26 20:24:55 +01:00
Calum Grant
4aa1947a23
C#: Implement type annotations for nullability, parameter kinds and method returns.
2019-06-26 20:24:55 +01:00
Tom Hvitved
bd03e7a590
C#: Auto format
2019-06-26 19:32:08 +02:00
Tom Hvitved
ead50999a3
C#: Remove unused EmptyPasswordInConfigurationFile.config
2019-06-26 19:30:04 +02:00
Tom Hvitved
51d093add0
C#: Address review comments
2019-06-25 17:01:48 +02:00
Calum Grant
a3d5d2c8e4
Merge pull request #1345 from denislevin/denisl/cs/MishandlingJapaneseDatesAndLeapYear
...
C#: Japanese Era and Leap Year checks (Likely Bugs)
2019-06-20 10:21:26 +01:00
Calum Grant
3c9c0e943b
Merge pull request #1459 from hvitved/csharp/remove-deprecated
...
C#: Remove deprecated predicates
2019-06-19 17:56:20 +01:00
Calum Grant
07eb0ec5b2
Merge pull request #1462 from hvitved/csharp/controlflowgraph-depr
...
C#: Remove uses of deprecated `ControlFlowGraph` module
2019-06-19 17:55:04 +01:00
Calum Grant
df2a46eb80
Merge pull request #1468 from hvitved/csharp/extractor-error
...
C#: Include extractor message in diagnostic queries
2019-06-19 17:47:11 +01:00
Tom Hvitved
dca27927dc
C#: Remove unused PasswordInConfigurationFile.config
2019-06-19 10:57:14 +02:00
Denis Levin
aab4351efb
A few more changes from code review
2019-06-18 17:49:48 -07:00
Tom Hvitved
5443f74660
C#: Reintroduce deprecated ControlFlowGraph module
2019-06-18 11:44:12 +02:00
Tom Hvitved
70c5e39c5d
C#: Include extractor message in diagnostic queries
2019-06-18 11:01:26 +02:00
Tom Hvitved
a1d7382a67
C#: Update expected test output
2019-06-17 20:07:54 +02:00
Tom Hvitved
5cc11ba232
C#: Update nuget packages
2019-06-17 13:26:11 +02:00
Tom Hvitved
d333ffb57a
C#: Update to netcoreapp2.2
2019-06-17 13:21:00 +02:00
Tom Hvitved
f408a6ddfc
Merge pull request #1404 from calumgrant/cs/dispose-not-called-on-throw
...
C#: Improvement to cs/dispose-not-called-on-throw
2019-06-17 11:25:16 +02:00
Tom Hvitved
e70f17f260
C#: Remove uses of deprecated ControlFlowGraph module
2019-06-17 10:23:23 +02:00
semmle-qlci
03cf8ef94f
Merge pull request #1422 from hvitved/csharp/switch-expr-completion
...
Approved by calumgrant
2019-06-17 08:33:43 +01:00
Tom Hvitved
97d2813666
C#: Refactor last predicate
...
- Split up the `last` predicate into a non-recursive part `lastNonRec` and a recursive
part `last`.
- Almost all syntactic constructs have a very simple `last` definition; a set of
disjuncts with exactly one recursive call -- those are defined in `lastNonRec`.
- `try` statements and (last) `catch` clauses require multiple recursive calls in
the same disjunct, and are therefore handled in the `last` predicate (as before).
- The benefit is that we only need to take care of the join order in the recursive
call (for non-`try`/`catch` statements) in one place (the predicate `lastRec`),
so we can get rid of many `nomagic`'ed `last`-specialisations.
2019-06-17 09:28:56 +02:00
Denis Levin
da2422cb17
Addressed code review comments
2019-06-14 18:25:17 -07:00
Calum Grant
1e7ce8cd31
Merge pull request #1451 from hvitved/csharp/element-preds
...
C#: Move two predicates from `csharp/Element.qll` to `dotnet/Element.qll`
2019-06-14 16:21:28 +01:00
Tom Hvitved
f56c1df732
C#: Remove deprecated predicates
2019-06-14 13:26:24 +02:00
Calum Grant
8354f813f7
Merge pull request #1419 from hvitved/csharp/stubs
...
C#: Improvements to `Stubs.qll`
2019-06-13 14:17:24 +01:00
Tom Hvitved
8c8929a702
C#: Move two predicates from csharp/Element.qll to dotnet/Element.qll
2019-06-13 13:00:18 +02:00
Tom Hvitved
946be967f8
C#: Break up a big cached stage into multiple stages
...
- Add `Caching.qll` for controlling caching across multiple files.
- Move `isUncertainRefCall()` out of cached module in `Assignable.qll` to avoid
collapsing with CFG stage.
- Remove dependency on `AlwaysNullExpr` in `NullValue::getAnExpr()` to avoid
collapsing with CFG stage.
- Avoid caching pre-SSA library as it should only be used during the CFG construction
stage.
2019-06-12 16:05:45 +02:00
Tom Hvitved
8e38511aeb
C#: Address review comments
2019-06-12 13:21:49 +02:00
Calum Grant
02875721df
C#: Address review comment.
2019-06-12 09:50:03 +01:00
Calum Grant
d055c85ff0
C#: Exclude case from cs/dispose-not-called-on-throw where the disposable is disposed by a UsingStmt, even when explicitly disposed.
2019-06-11 15:20:27 +01:00
Calum Grant
b9d2fc3380
C#: DB upgrade script and stats.
2019-06-11 15:04:39 +01:00
Calum Grant
40481fbf9d
C#: Make SuppressNullableWarningExpr a nonNullValue, and add a test.
2019-06-11 12:45:50 +01:00
Calum Grant
d48ce859eb
C#: Implement nullable warning suppression expressions.
2019-06-11 12:12:29 +01:00
Calum Grant
fc0e34100a
Merge pull request #1397 from hvitved/csharp/lgtm-alerts-suite
...
C#: Make `csharp-alerts-lgtm` a stub
2019-06-10 18:24:41 +01:00
Tom Hvitved
17aad4b0a5
C#: Fix CFG for switch expressions in Boolean/nullness contexts
2019-06-07 15:39:33 +02:00
Tom Hvitved
e538d8e9ac
C#: Add CFG tests for switch expression in Boolean/nullness context
2019-06-07 15:39:28 +02:00
Tom Hvitved
7c802ada40
C#: Improvements to Stubs.qll
...
- Handle keywords.
- Handle `const` fields.
- Handle type parameter constraints.
2019-06-07 14:50:33 +02:00
Calum Grant
c88359b9c7
C#: Fix test.
2019-06-05 09:42:48 +01:00
Calum Grant
9678f8eaba
C#: Fix control flow graph for using declaration statements.
2019-06-04 18:10:49 +01:00