Paolo Tranquilli
|
69b87a63b8
|
Go: remove invalid toolchain version diagnostics
This diagnostic was introduced by https://github.com/github/codeql/pull/15979.
However in the meantime the Go team [has backtracked](https://github.com/golang/go/issues/62278#issuecomment-2062002018)
on their decision, which leads to confusing alerts for user (e.g. https://github.com/github/codeql-action/issues/2868).
Even using Go toolchains from 1.21 to 1.22 we weren't immediately able
to reproduce the problem that this diagnostics was meant to guard
against. Therefore it was deemed simpler to just remove it.
_En passant_ the `Makefile` now accepts `rtjo` not being set.
|
2025-04-24 14:41:05 +02:00 |
|
Michael B. Gale
|
fe4ee54b6f
|
Go: Add more logging for go.mod files to workspace discovery
|
2025-02-19 13:25:49 +00:00 |
|
Michael B. Gale
|
b372af51b6
|
Go: Allow FindAllFilesWithName to use predicate functions for dirsToSkip
|
2025-02-19 11:24:53 +00:00 |
|
Owen Mansel-Chan
|
cc459cd80e
|
Update toolchain version regex
Allow release candidate versions.
|
2025-02-11 22:04:19 +00:00 |
|
Michael B. Gale
|
d8d1ae632c
|
Merge branch 'mbg/go/fix/build-scripts-running-more-than-once' into mbg/go/fix/too-many-go-mod-files-initialised
|
2024-06-11 18:31:03 +01:00 |
|
Michael B. Gale
|
0f56e408f8
|
Merge branch 'main' into mbg/go/fix/build-scripts-running-more-than-once
|
2024-06-11 18:29:41 +01:00 |
|
Michael B. Gale
|
864d629a13
|
Go: Prevent go.mod files from being added to every directory with stray source files
|
2024-06-11 18:24:11 +01:00 |
|
Michael B. Gale
|
d4adc373c6
|
Replace if with else if in RequiredGoVersion
|
2024-06-10 15:48:29 +01:00 |
|
Michael B. Gale
|
e7a60b72f1
|
Go: Check dependencies per workspace
|
2024-06-07 16:22:41 +00:00 |
|
Michael B. Gale
|
d344f720aa
|
Go: Add methods to GoModule for the tidy and vendor commands
These ensure that the module path is used automatically
|
2024-06-07 16:22:37 +00:00 |
|
Michael B. Gale
|
504a233299
|
Go: Use Toolchain directives in go.mod files, if available
|
2024-06-07 12:20:43 +00:00 |
|
Michael B. Gale
|
1d6f09c750
|
Go: Refactor go.mod version retrieval into its own method
|
2024-06-07 12:20:42 +00:00 |
|
Michael B. Gale
|
44a16cef6c
|
Go: Use Toolchain directives in go.work files, if available
|
2024-06-07 12:20:41 +00:00 |
|
Michael B. Gale
|
054efa648c
|
Go: Move version constants to shared location
|
2024-05-15 10:03:35 +01:00 |
|
Michael B. Gale
|
a6d2aa3913
|
Go: Use SemVer type in project package
|
2024-05-15 10:03:32 +01:00 |
|
Michael B. Gale
|
00cbfaf40e
|
Go: Allow version suffixes
|
2024-05-01 15:00:45 +01:00 |
|
Michael B. Gale
|
b8cfff6d19
|
Go: Use Parse instead of ParseLax, since we need toolchain directives
|
2024-04-25 14:10:26 +01:00 |
|
Michael B. Gale
|
15a6308c72
|
Go: Refactor condition for EmitInvalidToolchainVersion into separate function
|
2024-04-25 14:04:00 +01:00 |
|
Michael B. Gale
|
55fa245194
|
Go: Revert go version call in LoadGoModules
|
2024-04-02 15:20:56 +01:00 |
|
Michael B. Gale
|
73f71d8ace
|
Merge pull request #15979 from github/mbg/go/deal-with-incorrect-versions
|
2024-03-28 14:16:14 +00:00 |
|
Michael B. Gale
|
c74d6348f9
|
Go: Run go with a valid toolchain version if we have found an invalid one
|
2024-03-20 13:55:37 +00:00 |
|
Michael B. Gale
|
be027e217e
|
Go: Emit diagnostic for invalid toolchain versions
|
2024-03-19 16:26:06 +00:00 |
|
Michael B. Gale
|
ac394dc80c
|
Go: Better check for path prefixes
|
2024-03-05 13:46:33 +00:00 |
|
Michael B. Gale
|
b1e0bc03ab
|
Go: Fix check for whether it is safe to initialise a go.mod file in a given directory
|
2024-03-05 12:48:21 +00:00 |
|
Michael B. Gale
|
9b5bf519a1
|
Update go/extractor/project/project.go
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
|
2024-03-04 12:25:40 +00:00 |
|
Michael B. Gale
|
acf2f761a6
|
Go: Improve log message for InitGoModForLegacyProject
|
2024-03-04 12:14:24 +00:00 |
|
Michael B. Gale
|
1a13a0e4c9
|
Go: Log discovered Go modules in case workspace files can't be read/parsed
|
2024-03-04 12:14:24 +00:00 |
|
Michael B. Gale
|
020eb4aed7
|
Go: Use slices.Concat for bazelPaths
|
2024-03-04 12:14:23 +00:00 |
|
Michael B. Gale
|
6267506a77
|
Go: Postpone go.mod creation until necessary
|
2024-02-14 19:12:36 +00:00 |
|
Michael B. Gale
|
1055e773ef
|
Go: Export InitGoModForLegacyProject
|
2024-02-14 19:12:35 +00:00 |
|
Michael B. Gale
|
4387c73d12
|
Go: Fix missing word in comment for discoverWorkspace
|
2024-02-14 19:12:35 +00:00 |
|
Michael B. Gale
|
6eac48caba
|
Go: Refactor greatest version logic into dedicated function
|
2024-02-14 19:12:34 +00:00 |
|
Michael B. Gale
|
058bf32ad0
|
Go: Initialise Go modules for stray source files outside of existing modules
|
2024-02-14 19:12:34 +00:00 |
|
Michael B. Gale
|
d99ad01efa
|
Go: Add module files which don't belong to a workspace, if there are workspaces
|
2024-02-14 19:12:34 +00:00 |
|
Michael B. Gale
|
925e99cdb2
|
Go: Use GoFilesOutsideDirs to find stray source files
|
2024-02-14 19:12:33 +00:00 |
|
Michael B. Gale
|
3a982de16f
|
Go: Workspaces only support mod=readonly
|
2024-02-14 19:12:32 +00:00 |
|
Michael B. Gale
|
9c3667dbf7
|
Go: Improve go.work file(s) found log message
|
2024-02-14 19:12:32 +00:00 |
|
Michael B. Gale
|
fd54350ba8
|
Go: Fix comment for getBuildRoots
|
2024-02-14 19:12:32 +00:00 |
|
Michael B. Gale
|
f084829154
|
Go: Only fail autobuilder if all projects cannot be extracted
|
2024-02-14 19:12:31 +00:00 |
|
Michael B. Gale
|
0b8a917584
|
Go: Fix crash if WorkspaceFile.Go is nil
|
2024-02-14 19:12:30 +00:00 |
|
Michael B. Gale
|
a961e276c1
|
Go: Initialise filesToRemove to an empty array
|
2024-02-14 19:12:30 +00:00 |
|
Michael B. Gale
|
c96735e17a
|
Go: Remove auto-generated go.mod files when done
|
2024-02-14 19:12:30 +00:00 |
|
Michael B. Gale
|
e79f5905e7
|
Go: Fix checks for dep and glide not working correctly
|
2024-02-14 19:12:29 +00:00 |
|
Michael B. Gale
|
ec902827f6
|
Go: Initialise go.mod for stray source files
|
2024-02-14 19:12:29 +00:00 |
|
Michael B. Gale
|
b9e96e4a27
|
Fixup: closing curly brace
|
2024-02-14 19:12:29 +00:00 |
|
Michael B. Gale
|
21fbb1b051
|
Go: Only initialise module if there are source files
|
2024-02-14 19:12:28 +00:00 |
|
Michael B. Gale
|
f48b1e57d7
|
Go: Check for relative paths warning even if go mod tidy is successful
|
2024-02-14 19:12:28 +00:00 |
|
Michael B. Gale
|
aa5e14f59f
|
Go: Replace BuildInfo with GoWorkspace
|
2024-02-14 19:12:28 +00:00 |
|
Michael B. Gale
|
8b376e7a35
|
Go: Include ModMode in GoWorkspace
|
2024-02-14 19:12:28 +00:00 |
|
Michael B. Gale
|
025fbc874f
|
Go: Move definition of GoVersionInfo
|
2024-02-14 19:12:28 +00:00 |
|