Chris Smowton
99c211955b
Hotfix: Go: exclude method receivers from dead-store-of-field query
2023-05-23 14:31:25 +01:00
Chris Smowton
8b28848c82
Merge pull request #13250 from smowton/smowton/hotfix/golang-field-store-varargs-function
...
Hotfix: Go: count passing to a vararg function as escaping
2023-05-23 12:03:48 +01:00
Chris Smowton
d5d56cde5a
Dead store of field: count passing to a vararg function as escaping
2023-05-23 10:51:21 +01:00
github-actions[bot]
7aa23cf11d
Release preparation for version 2.13.3
2023-05-22 20:47:00 +00:00
Owen Mansel-Chan
1a9bd9ccde
Merge pull request #13135 from owen-mc/go/fix-unit-test
...
Go: fix unit test
2023-05-16 07:50:50 +01:00
Kasper Svendsen
7c5625a4dc
Go: Make implicit this receivers explicit
2023-05-12 12:14:13 +02:00
Chris Smowton
ee64ea59e1
Merge pull request #12901 from porcupineyhairs/goDsn
...
Go: Add query to detect DSN Injection.
2023-05-11 22:45:43 +01:00
Chris Smowton
820673470e
Merge pull request #13119 from porcupineyhairs/goTiming
...
Go : Add query to detect potential timing attacks
2023-05-11 22:38:13 +01:00
Chris Smowton
99f4eef9c5
Fix spelling
2023-05-11 22:12:35 +01:00
Chris Smowton
a10b11e09e
Fix spelling and remove dead code
2023-05-11 22:12:17 +01:00
Chris Smowton
b6c2db6baf
Fix duplicate query ID
2023-05-11 22:10:09 +01:00
Porcupiney Hairs
2c518c1fa6
Include changes from review
2023-05-12 01:59:42 +05:30
Porcupiney Hairs
ae6fda03b7
Include changes from review
2023-05-11 23:56:50 +05:30
Owen Mansel-Chan
77c8357705
Do not obscure exit code with call to grep
...
The output is a bit more verbose, but this is hard to avoid
2023-05-11 18:15:41 +01:00
Owen Mansel-Chan
3981bb1f58
Indent comment in Makefile better
2023-05-11 17:12:27 +01:00
Owen Mansel-Chan
760ba82c7a
Fix unit tests
2023-05-11 16:40:59 +01:00
Owen Mansel-Chan
1beb348d95
Fix outdated message
2023-05-11 14:29:14 +01:00
Owen Mansel-Chan
02a224c28f
--identify-environment should write json to stdout
2023-05-11 14:29:14 +01:00
Owen Mansel-Chan
874a426779
Add identify-environment scripts
2023-05-11 11:51:42 +01:00
Owen Mansel-Chan
b306807046
Merge pull request #13040 from owen-mc/go/identify-environment-change-logic
...
Go: change logic in `go-autobuilder --identify-environment`
2023-05-11 08:22:01 +01:00
Porcupiney Hairs
d536157c1a
Go : Add query to detect potential timing attacks
2023-05-11 09:57:50 +05:30
Owen Mansel-Chan
5ef74c96de
Merge pull request #13105 from owen-mc/go/change-diagnostic-message
...
Go: Update "go/autobuilder/package-not-found" diagnostic message
2023-05-11 05:27:09 +01:00
Owen Mansel-Chan
270ba09ffb
Merge pull request #11732 from owen-mc/go/fix/model-data-flow-through-varargs
...
Go: Allow data flow through varargs parameters
2023-05-11 05:26:40 +01:00
Porcupiney Hairs
ec424d7e51
Go: Add query to detect DSN Injection.
2023-05-11 03:45:29 +05:30
Owen Mansel-Chan
9334cfb22c
Change logic when go mod version above max supported version
2023-05-10 21:56:56 +01:00
Owen Mansel-Chan
9c5fc9714a
Use "Requesting" instead of "Writing environment file"
2023-05-10 21:53:10 +01:00
Owen Mansel-Chan
97ec7a07eb
Address review comments
2023-05-10 15:53:08 +01:00
Owen Mansel-Chan
1c66564ccc
address review comments
2023-05-10 14:05:09 +01:00
Owen Mansel-Chan
8f41ff36fb
Add change note
2023-05-10 13:50:04 +01:00
Owen Mansel-Chan
50d3cffe61
Accept review comments
2023-05-10 13:28:11 +01:00
Owen Mansel-Chan
fcf3cb7ea4
Update "go/autobuilder/package-not-found" message
2023-05-10 12:24:03 +01:00
Owen Mansel-Chan
375be68492
Fix diagnostics
2023-05-10 11:12:48 +01:00
Owen Mansel-Chan
edebebf603
Refactor for clarity
2023-05-10 11:12:47 +01:00
Owen Mansel-Chan
f9d2467eaa
Downgrade package-not-found diagnostic to warning
...
error is reserved for when the build fails.
2023-05-10 09:58:58 +01:00
Owen Mansel-Chan
12f996ff56
Deal better with goModVersion < minGoVersion
2023-05-10 09:45:48 +01:00
Owen Mansel-Chan
32b5df69c3
Add comments explaining version choice logic
2023-05-10 09:26:18 +01:00
Michael Nebel
4ac0396b67
Go/Python/Ruby/Swift: Sync files and make dummy implementation.
2023-05-08 16:18:59 +02:00
Owen Mansel-Chan
d329da673a
Refactor logic for which version to install
...
This does not change the version returned. In the case the the go mod
version is supported and the go env version is below goMinVersion, the
message now talks about go env version being unsupported instead of
it being less than go mod version. This seems more sensible to me.
2023-05-05 15:44:55 +01:00
Owen Mansel-Chan
3f7a230a11
Sometimes install Go version even when one exists
2023-05-05 15:44:54 +01:00
Owen Mansel-Chan
bb3101e649
Merge pull request #13022 from owen-mc/go/identify-environment-fixes
...
Go: `go-autobuilder --identify-environment` fixes
2023-05-04 14:30:31 +01:00
Owen Mansel-Chan
d2cf1a24e0
Merge pull request #13014 from owen-mc/go/misc-go-cleanups
...
Go: Misc go cleanups
2023-05-04 10:34:32 +01:00
Owen Mansel-Chan
011c9272cf
Remove inconsistent line break in message
2023-05-04 10:33:05 +01:00
Owen Mansel-Chan
c21b1a6e3b
Be clear when no Go version in environment file
2023-05-04 10:32:21 +01:00
Owen Mansel-Chan
5d06adb1e6
Only check if go env version is supported if go mod version is supported
...
This is what I meant to implement in the first place.
2023-05-04 10:24:43 +01:00
Kasper Svendsen
a7f5decb2b
Merge branch 'main' into kaspersv/go-enable-warn-on-implicit-this
2023-05-04 07:45:07 +02:00
Owen Mansel-Chan
62653fbec5
Simplify return statements in tryReadGoDirective
...
This makes it easier to reason about what is returned and would have
avoided the bug with variable shadowing.
2023-05-03 16:55:19 +01:00
Owen Mansel-Chan
d30b736eb2
Move check for EmitNewerGoVersionNeeded diagnostic
...
This should only be done when --identify-environment has not been passed
2023-05-03 16:52:48 +01:00
Owen Mansel-Chan
afb692300a
Fix typo in field name
2023-05-03 16:46:44 +01:00
Owen Mansel-Chan
742a6d9264
Fix accidental variable shadowing
2023-05-03 16:32:53 +01:00
Owen Mansel-Chan
347b5f1b1a
Remove unused code
2023-05-03 16:03:17 +01:00
