Owen Mansel-Chan
b169f1bfdf
Factor out code to fix go vendor issues
2023-04-19 12:20:48 +01:00
Owen Mansel-Chan
f872a11b85
Factor out initial ModMode calculation
2023-04-19 12:20:48 +01:00
Owen Mansel-Chan
2d8d9773c4
Factor out depMode calculation
2023-04-19 12:20:47 +01:00
Owen Mansel-Chan
d613bc8a28
Update checks for files or dirs existing
...
The previous way is considered outdated now.
2023-04-19 12:20:47 +01:00
Owen Mansel-Chan
2914480ff6
Avoid platform-specific results
...
These were introduced in https://github.com/github/codeql/pull/12750 but
the relevant tests that should have caught it weren't run.
2023-04-19 11:18:19 +01:00
Alex Ford
924ce250dd
Merge pull request #12847 from github/post-release-prep/codeql-cli-2.13.0
...
Post-release preparation for codeql-cli-2.13.0
2023-04-18 14:40:40 +01:00
Tom Hvitved
f6d000eb20
Merge pull request #12805 from hvitved/remove-queries-xml
...
Remove all `queries.xml` files
2023-04-18 10:52:14 +02:00
github-actions[bot]
648f0e19ec
Post-release preparation for codeql-cli-2.13.0
2023-04-17 15:39:24 +00:00
github-actions[bot]
075d063370
Release preparation for version 2.13.0
2023-04-14 13:31:30 +00:00
Owen Mansel-Chan
8a4ca7fb84
Merge pull request #10026 from pwntester/patch-2
...
Go: Partial URLs should not sanitize against SSRF
2023-04-14 13:52:11 +01:00
Owen Mansel-Chan
352866b52d
Add change note
2023-04-14 12:00:38 +01:00
Owen Mansel-Chan
a42dbc5bab
Fix formatting again
2023-04-14 12:00:38 +01:00
Owen Mansel-Chan
d407a689fa
Fix formatting by deleting spaces no blank line
2023-04-14 12:00:38 +01:00
Owen Mansel-Chan
169bde8671
Fix formatting by deleting blank line
2023-04-14 12:00:38 +01:00
Alvaro Muñoz
8bf4b55309
Partial URLs should not sanitize against SSRF
...
As an example:
```go
urlPath := ctx.Req.URL.Path
hash := urlPath[strings.LastIndex(urlPath, "/")+1:]
req, _ := http.NewRequest("GET", source+hash, nil)
```
2023-04-14 12:00:38 +01:00
Alex Eyers-Taylor
c6a482819a
Bump all qlpacks major versions
2023-04-13 19:15:27 +01:00
Michael Nebel
52bc43b22b
Merge pull request #12595 from michaelnebel/enhanceprovenance
...
Java/C# : Enhance provenance.
2023-04-13 14:27:53 +02:00
Alex Ford
8c46bfd051
Merge pull request #12816 from github/rc/3.9
...
Merge `rc/3.9` into `main`
2023-04-13 12:35:41 +01:00
Tom Hvitved
3cc9dec9c8
Remove all queries.xml files
2023-04-13 11:18:58 +02:00
Michael Nebel
917cf7bfee
Go: Update provenance validation.
2023-04-13 09:21:05 +02:00
Michael Nebel
1d82b09ec1
Sync files.
2023-04-13 09:21:05 +02:00
Chris Smowton
d648b34037
Accept test changes
...
These are caused by nodes being hidden by https://github.com/github/codeql/pull/12783
2023-04-12 15:05:04 +01:00
Chris Smowton
7eefa43f5a
Rename and document viableArgParamSpecific to make clear it is a temporary hook.
2023-04-12 14:33:46 +01:00
Chris Smowton
1706367b34
Document DataFlowCallable
2023-04-12 14:24:21 +01:00
Chris Smowton
9f4b77e851
Accept test changes
2023-04-12 14:19:06 +01:00
Chris Smowton
4d8ca3d759
Add dataflow callback to filter out receiver argument flow to Golang interface dispatch candidates.
...
Other langauges stub the callback.
2023-04-12 14:19:06 +01:00
Chris Smowton
7ffe863ba6
Remove addressed FIXME
...
This was addressed by adding `getAPackageWithSummarizedCallables`
2023-04-12 14:19:06 +01:00
Chris Smowton
985e07d902
pragma[nomagic] hasQualifiedName
...
These are cheap and frequently-used, and magicking them with respect to `interpretPackage` was yielding expensive, unnecessary regex operations.
2023-04-12 14:19:06 +01:00
Chris Smowton
0129167cc4
Convert Beego's MapGet method to MaD
2023-04-12 14:19:06 +01:00
Chris Smowton
b86f0cf268
Sort models
2023-04-12 14:19:06 +01:00
Chris Smowton
12527e406b
Remove unnecessary model
...
This referred to a private type
2023-04-12 14:19:05 +01:00
Chris Smowton
2abffccded
Accept test changes
2023-04-12 14:19:05 +01:00
Chris Smowton
3cea01b6c8
Fix functions with multiple models
...
In some cases multiple return value outputs can be coalesced, and in others we had accidentally conflated two independent flows (e.g. Arg1 -> Arg2 | Arg3 -> Arg4 led to accidentally introducing Arg1 -> Arg4 and Arg3 -> Arg2)
2023-04-12 14:19:05 +01:00
Chris Smowton
4a89dbc498
Revert "Remove unnecessary models"
...
This reverts commit 12eaedc188487275e8cd6bed4a4318fed4d4b752.
We can't do this now, because there is nothing to guarantee an interface has actually been extracted, and therefore whether a model will get applied. Therefore explicitly modelling methods that may be interface implementations where the interface is in a different package may still make a difference to behaviour.
2023-04-12 14:19:05 +01:00
Chris Smowton
3f6ceccbe8
US spelling
2023-04-12 14:19:05 +01:00
Chris Smowton
8c553ec0fc
Autoformat go
2023-04-12 14:19:05 +01:00
Chris Smowton
ac4dcc6c4b
Add ioutil usage to TaintSteps test
...
It appears at present the Go standard library imports the deprecated io/ioutil package internally on some platforms but not others. Therefore I add a test explicitly using it to make the test behave more uniformly.
2023-04-12 14:19:05 +01:00
Chris Smowton
3c48609635
Accept test changes
2023-04-12 14:19:05 +01:00
Chris Smowton
ed56461ed7
Remove unnecessary models
...
These are inherited from Stringer, Reader, Writer and BinaryMarshaler
2023-04-12 14:19:05 +01:00
Chris Smowton
19e8974766
Fix comment
2023-04-12 14:19:05 +01:00
Chris Smowton
140505222f
Update test expectations
2023-04-12 14:19:04 +01:00
Chris Smowton
1a7927d3a1
Fix x/net/html.EscapeString modelling
...
This had never worked due to accidentally extending non-abstract class HtmlEscapeFunction; consequently it was neither a taint propagator in general, nor an HTML escape function. Added tests to ensure it is now behaving as intended.
2023-04-12 14:19:04 +01:00
Chris Smowton
fa4145b5e4
Remove dead code
2023-04-12 14:19:04 +01:00
Chris Smowton
141d6b8d7b
Accept paths test changes
2023-04-12 14:19:04 +01:00
Chris Smowton
8a06ca5a43
Allow $ANYVERSION token in Go package names
2023-04-12 14:19:04 +01:00
Chris Smowton
477341dd3b
Remove unnecessary variable
2023-04-12 14:19:04 +01:00
Chris Smowton
952bc8458f
Use explicit this
2023-04-12 14:19:04 +01:00
Chris Smowton
affe42b079
Use US spelling
2023-04-12 14:19:04 +01:00
Chris Smowton
aaa7f34386
Fix mixing of source and summary models
2023-04-12 14:19:04 +01:00
Chris Smowton
18d00c1116
Autoformat QL
2023-04-12 14:19:03 +01:00