github-actions[bot]
e97878ed63
Post-release preparation for codeql-cli-2.19.1
2024-09-30 19:49:00 +00:00
Chris Smowton
be389b4c19
Go: deduplicate integration tests
2024-09-30 19:54:14 +01:00
github-actions[bot]
455c8c5953
Release preparation for version 2.19.1
2024-09-30 17:59:48 +00:00
Chris Smowton
c9d6c80913
Log when vendor dir extraction is active
2024-09-30 18:44:20 +01:00
Chris Smowton
684aedf6aa
Golang vendor dir extraction: add extractor option
2024-09-30 18:24:49 +01:00
Chris Smowton
ca68aaa0de
Remove test code
2024-09-27 19:07:00 +01:00
Owen Mansel-Chan
796db77104
Add comments noting methods from embedded interfaces are already included
2024-09-27 15:03:09 +01:00
Owen Mansel-Chan
fdff209938
Merge pull request #17505 from owen-mc/go/inheritance-tests
...
Go: Add tests for model inheritance and fix bug in promoted methods
2024-09-26 16:42:25 +01:00
Rasmus Wriedt Larsen
381ea93ec3
Merge pull request #17424 from RasmusWL/active-threat-model-source
...
Go/Java/C#: Rename `ThreatModelFlowSource` to `ActiveThreatModelSource`
2024-09-26 13:08:17 +02:00
Josh Soref
a9e07a88af
Downgrade IncorrectIntegerConversionQuery precision to high
...
`very-high` implies near 0 false positives and we have run into a number and an entire class
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2024-09-24 22:08:00 -04:00
Owen Mansel-Chan
ea4f9cad3c
Mark some test results as SPURIOUS
2024-09-24 22:04:50 +01:00
Owen Mansel-Chan
bcb718ac77
Add change note
2024-09-24 21:39:49 +01:00
Chris Smowton
d673d24ca6
Revise notation to more closely resemble real Go
2024-09-24 17:22:26 +01:00
Chris Smowton
11755482e4
Update test expectation (now signature types pretty-print indicating if they are variadic)
2024-09-24 17:18:10 +01:00
Chris Smowton
40035a0b62
Improve pretty-printer
2024-09-24 17:18:09 +01:00
Chris Smowton
4d3a140dd7
Expose whether functions are variadic in their pp() output
2024-09-24 17:18:08 +01:00
Owen Mansel-Chan
73209638e3
Improve comments in test library
2024-09-24 16:41:10 +01:00
Owen Mansel-Chan
b0caabac86
Also update QL tests
2024-09-24 16:25:55 +01:00
Owen Mansel-Chan
6e428d5083
Fix bug where some methods were inappropriately promoted
2024-09-24 16:25:53 +01:00
Owen Mansel-Chan
0255edf524
Remove tests for sources and sinks
...
This is redundant given that we test for paths, and for a path
we need the source, step and sink methods to be modeled.
2024-09-24 16:25:49 +01:00
Owen Mansel-Chan
afa4b6dd4a
Make paths test an inline expectations test
2024-09-24 16:23:33 +01:00
Owen Mansel-Chan
5490f3a957
Add tests for interface embedding interface
2024-09-24 16:23:31 +01:00
Owen Mansel-Chan
279800ea62
Use shorter naming scheme for types
2024-09-24 16:23:26 +01:00
Tom Hvitved
300fdc344d
Go: Update expected test output
2024-09-24 14:21:42 +02:00
Owen Mansel-Chan
6a67bd52a9
Add tests for MaD inheritance
2024-09-24 13:21:05 +01:00
Chris Smowton
7e8da94d9a
Merge pull request #17216 from smowton/smowton/feature/golang-test-extraction
...
Go: support extracting test code
2024-09-23 16:43:42 +01:00
Chuan-kai Lin
1cd8af54f2
Merge pull request #17190 from github/cklin/diff-informed-java-queries
...
Java: add support for alert location restrictions
2024-09-23 08:39:24 -07:00
Chris Smowton
209f9ec93d
Amend comments per review
2024-09-23 15:20:18 +01:00
Rasmus Wriedt Larsen
63c3a71d95
Merge branch 'main' into active-threat-model-source
2024-09-23 11:18:14 +02:00
Chris Smowton
e528a08794
Autoformat
2024-09-21 22:12:24 +01:00
Chris Smowton
bb44a2fc8c
Populate pkgInfoMapping for test packages if relevant
2024-09-21 13:38:41 +01:00
Anders Schack-Mulligen
3a1e50dcf9
Dataflow: Simplify diff-informed implementation and tweak flag name.
2024-09-20 07:07:10 -07:00
Chris Smowton
bcb84a84e1
Only skip test packages at the file-extraction phase
2024-09-20 12:48:08 +01:00
Chris Smowton
f5ff822681
Convert extract-tests option to an official extractor option
2024-09-20 10:03:54 +01:00
Chris Smowton
94cb99e51d
Adjust test expectations
2024-09-20 10:03:53 +01:00
Chris Smowton
9d79feb4d3
Autoformat go
2024-09-20 10:03:52 +01:00
Chris Smowton
eb6918f88f
Autoformat
2024-09-20 10:03:51 +01:00
Chris Smowton
fd592fa18f
Add tests
2024-09-20 10:03:46 +01:00
Chris Smowton
c3dffc955b
Apply review comments
2024-09-20 09:56:29 +01:00
Chris Smowton
76e6942594
Go: support extracting test code
...
This implements support for test extraction by two mechanisms:
* In autobuild mode, setting `CODEQL_EXTRACTOR_GO_EXTRACT_TESTS` to `true`.
* In manual build mode, tracing a `go test` command (`go test -c` is to be recommended for efficiency).
Go deals with test compilation by creating several extra packages on top of those expected from inspection of the source code (see docs of `packages.Load` for more detail): packages whose IDs include a suffix like `mydomain.com/mypackage [mydomain.com/mypackage.test]`, and packages containing generated test driver code like `mydomain.com/mypackage.test`. There are also additional packages like `mydomain.com/mypackage_tests` which are explicitly present in source code, but not compiled by a normal `go build`.
So far as I can tell, the purpose of the two variants of the package is to resolve dependency cycles (because the tests variant of the package can have more dependencies than the non-tests variant, and non-test code can compile against non-test package variants). Since the test package variants seems to be a superset of the non-tests variant, I employ the simple heuristic of ignoring the variant of each package with the shortest ID. I haven't seen a case where there are three or more variants of a package, so I expect this to always identify the tests variant as the preferred one. If several variants were extracted, and we were to attempt to match Golang's linkage strategy among the different variants, we would need to extend trap-file name and most top-level symbol trap IDs with the package variant they come from; I hope this won't prove necessary.
"Real" `_tests` packages, and wholly synthetic driver code packages, are extracted just like normal.
2024-09-20 09:56:28 +01:00
Tom Hvitved
4baa4ae2aa
Merge pull request #17513 from owen-mc/fix-test-expectations
...
C#/Go: Fix test expectations including double space
2024-09-19 12:17:18 +02:00
Owen Mansel-Chan
ded52ccb8e
Fix test expectations including double space
2024-09-19 11:01:38 +01:00
dependabot[bot]
67fa9738e6
Bump golang.org/x/tools
...
Bumps the extractor-dependencies group in /go/extractor with 1 update: [golang.org/x/tools](https://github.com/golang/tools ).
Updates `golang.org/x/tools` from 0.24.0 to 0.25.0
- [Release notes](https://github.com/golang/tools/releases )
- [Commits](https://github.com/golang/tools/compare/v0.24.0...v0.25.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: extractor-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-19 03:46:50 +00:00
Chris Smowton
0d0c94375d
Adjust test expectations
2024-09-17 17:27:04 +01:00
Chris Smowton
2d5cbfd4c9
Elaborate comments
2024-09-17 17:18:48 +01:00
Chris Smowton
41726924e0
Update expectations
2024-09-17 17:02:47 +01:00
Chris Smowton
a803d3fb26
Add comments explaining tests
2024-09-17 17:02:46 +01:00
Chris Smowton
09015df8a4
Format
2024-09-17 17:02:45 +01:00
Chris Smowton
992b3c74fc
Add data-flow tests for aliasing
2024-09-17 17:02:43 +01:00
github-actions[bot]
79be301984
Post-release preparation for codeql-cli-2.19.0
2024-09-16 14:09:32 +00:00
