Commit Graph

6144 Commits

Author SHA1 Message Date
Asger F
c09e748bca JS: Migrate JQueryMethodCall to new API 2019-10-08 14:05:10 +01:00
Erik Krogh Kristensen
0933235132 whitelist calls to functions that always throw an exception 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
a2993f1849 massively improve performance for detecting one-shot closures 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
0b8ea3c504 remove redundant check in returnsVoid 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
5ce356f509 two small doc fixes from docteam
Co-Authored-By: shati-patel <42641846+shati-patel@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
c6918ef38e changes to documentation and small change in returnsVoid based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
8c7f316a57 add qldoc to benignContext predicate
Co-Authored-By: Esben Sparre Andreasen <42067045+esben-semmle@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
63b3005217 remove punctuation in query name 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
b0b2d02855 small doc update
Co-Authored-By: mc <42146119+mchammer01@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
55f2f62c7a changes based on code review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
49bd553916 change query severity to warning 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
ea3c2fb2fa add fix suggestion to qhelp of js/use-of-returnless-function 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
64bcc10af3 remove redundancy in qhelp 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
666e11a506 apply suggestions from code review
Co-Authored-By: Esben Sparre Andreasen <42067045+esben-semmle@users.noreply.github.com>
2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
1c424310ae revert the last small change to ExprHasNoEffect.qll 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
34d0f72706 small refactor and added docstring based on code review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
92623a3e32 cleanup and refactor of promise case based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
0b48999718 refactored the attribute checks based on code-review 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
1bbe1ecdba the js/use-of-returnless-function query now support multiple callees 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
7025ba36c0 refactor of js/use-of-returnless-function 2019-10-08 11:54:57 +02:00
Erik Krogh Kristensen
00bf82d3c7 small changes to benignContext predicate based on code review 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
dedae5ba1d refactor isExplicitConditional into a library file, and use it from js/use-of-returnless-function 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
bda37b6d6f refactor of benignContext predicate based on code review 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
cdde8aea58 revert changes to js/useless-expression 2019-10-08 11:54:56 +02:00
Erik Krogh Kristensen
bed14244ae add query for detecting uses return-values from functions that does not return a value 2019-10-08 11:53:14 +02:00
Asger F
755f76a308 JS: Mention the ::Range classes 2019-10-07 08:29:42 +01:00
Asger F
34b4eb69db JS: Cache JSDocTypeExpr.resolvedName() 2019-10-07 08:29:42 +01:00
Asger F
c1e9eec267 JS: Modernize jQuery attribute defs 2019-10-07 08:29:42 +01:00
Asger F
a224186fab JS: Migrate AngularJS.JQLiteObject 2019-10-07 08:29:42 +01:00
Asger F
afdcb1e075 JS: Handle jQuery objects from Parameter.getAnInitialUse() 2019-10-07 08:29:42 +01:00
Asger F
fb181c2d14 JS: Use type info and type tracking in jQuery 2019-10-07 08:29:42 +01:00
Erik Krogh Kristensen
14cc352bd9 small documentation change based on review 2019-10-04 15:26:32 +02:00
Erik Krogh Kristensen
144e831515 mention that "function" should not be used when declaring a call signature in an interface 2019-10-04 15:05:11 +02:00
Erik Krogh Kristensen
bf1fd83851 fix typo in predicate name 2019-10-04 15:04:39 +02:00
Erik Krogh Kristensen
b741a65e9b documentation changes based on review
Co-Authored-By: shati-patel <42641846+shati-patel@users.noreply.github.com>
2019-10-04 14:42:16 +02:00
Erik Krogh Kristensen
c8d60c9e2a update @description of js/suspicious-method-name-declaration 2019-10-04 11:40:33 +02:00
Erik Krogh Kristensen
712a337bdd qhelp adjustments based on code-review 2019-10-04 11:06:11 +02:00
Erik Krogh Kristensen
ced5e3ea29 qhelp adjustment from code-review
Co-Authored-By: Esben Sparre Andreasen <42067045+esben-semmle@users.noreply.github.com>
2019-10-04 11:02:15 +02:00
Erik Krogh Kristensen
2b5e3aebb7 change tabs to spaces 2019-10-02 15:03:38 +02:00
Erik Krogh Kristensen
0c46e5c1a8 update description of js/suspicious-method-name-declaration 2019-10-02 15:01:25 +02:00
Erik Krogh Kristensen
c0b7538cf0 made the blacklist for methods named "function" work again 2019-10-02 14:56:41 +02:00
Erik Krogh Kristensen
e5290f3bb0 remove some parentheses 2019-10-02 14:51:47 +02:00
Erik Krogh Kristensen
22aac8e723 ensure that the existence of non-synthetic constructor is checked correctly 2019-10-02 14:49:33 +02:00
Erik Krogh Kristensen
a66e33ea5e add references to TypeScript spec for "new" and "constructor" keywords 2019-10-01 15:56:45 +02:00
Erik Krogh Kristensen
2ad85d16bd refactor a list of negated conjunctions to a disjunction 2019-10-01 15:53:22 +02:00
Erik Krogh Kristensen
6c176fc967 introduce name as a variable, and adjust alert messages 2019-10-01 15:28:57 +02:00
Erik Krogh Kristensen
26a0bfac39 refactor js/suspicious-method-name-declaration to use isSynthetic predicate 2019-10-01 15:06:45 +02:00
Erik Krogh Kristensen
aa1368741b rename suspicious-method-name to suspicious-method-name-declaration 2019-10-01 14:37:07 +02:00
Erik Krogh Kristensen
0320f0f26b add query for detecting suspisous method names in TypeScript 2019-09-30 13:05:50 +02:00
Erik Krogh Kristensen
7fb8f8453d fix for when the concatenation root is in parentheses 2019-09-26 16:35:38 +02:00