Arthur Baars
0d33a77ee3
Fix modelling of Stack.push
...
Stack.push(E) returns its argument, it does not propagate taint from
the stack to the return value.
2020-07-09 16:16:29 +02:00
Remco Vermeulen
b3bb4cbf54
Rename and update qldoc of default safe header splitting source
2020-07-09 16:14:21 +02:00
Anders Schack-Mulligen
879551fc6a
Merge pull request #3936 from aibaars/object-clone
...
Java: model Object.clone
2020-07-09 16:09:01 +02:00
Anders Schack-Mulligen
c8b9b779ae
Merge pull request #3927 from rvermeulen/java-importable-cwe-601
...
Java: Move `UrlRedirectSink` into importable library
2020-07-09 16:03:29 +02:00
Anders Schack-Mulligen
99a4f8fd0b
Merge pull request #3926 from rvermeulen/java-importable-cwe-089
...
Java: Move `QueryInjectionSink` into importable library
2020-07-09 16:00:56 +02:00
Remco Vermeulen
b147be6fea
Restrict SafeHeaderSplittingSource to RemoteFlowSource
2020-07-09 15:13:18 +02:00
Remco Vermeulen
7428a8cd95
Add missing java import
2020-07-09 15:06:26 +02:00
Remco Vermeulen
d3db4fa5b2
Add missing java import
2020-07-09 15:04:16 +02:00
Remco Vermeulen
54d6c8b5f4
Mark ServletUrlRedirectSink private
2020-07-09 15:03:51 +02:00
Remco Vermeulen
782573ed43
Add and format qldocs according to the style guide.
2020-07-09 14:58:53 +02:00
Remco Vermeulen
4ad6357cd7
Add missing Java import
2020-07-09 14:54:46 +02:00
Remco Vermeulen
7435dac3d2
Move source and sink into importable library
2020-07-09 14:53:59 +02:00
Arthur Baars
e183171fea
Java: model Object.clone
2020-07-09 14:50:29 +02:00
intrigus
641c5df79f
Centralize and model additional path creations.
2020-07-09 14:48:47 +02:00
Remco Vermeulen
b66f391c31
Extend source and sink from DataFlow::Node instead of DataFlow::exprNode
2020-07-09 14:39:08 +02:00
Remco Vermeulen
fed506a12f
Rename TrustedSource to SafeHeaderSplittingSource
2020-07-09 14:36:23 +02:00
Remco Vermeulen
1212feab28
Add file-level qldoc
2020-07-09 14:11:59 +02:00
Remco Vermeulen
99228d8bc2
Optimize imports
2020-07-09 14:09:39 +02:00
Remco Vermeulen
ba9f3e2a1e
Join ServletUrlRedirectSink with UrlRedirectSink
2020-07-09 14:08:43 +02:00
Remco Vermeulen
88f4b224c3
Extend UrlRedirectSink from DataFlow::Node
2020-07-09 14:05:54 +02:00
Remco Vermeulen
f8078f1125
Remove superfluous imports
2020-07-09 13:43:10 +02:00
Arthur Baars
d3d58795f1
Java: ContainerFlow add comments
...
Some method variants are captured by a super class. Added some comments
to indicate where this happens to make review of missing methods easier
in the future.
2020-07-09 12:46:57 +02:00
Remco Vermeulen
9a84abf259
Generalize QueryInjectionSink
...
Extends from the more general DataFlow::Node instead of
DataFlow::ExprNode
2020-07-09 12:32:17 +02:00
Arthur Baars
24c6e506aa
Java: ContainerFlow: RValue -> Expr
...
While most flow for a qualifierToArgumentStep goes through a variable use
this is not always the case. Therefore it is best to remove the restriction
to RValue to allow taint steps to use postupdate nodes.
See also: ba86dea657
2020-07-09 12:20:48 +02:00
Remco Vermeulen
c01844a39e
Add file-level qldoc
2020-07-09 10:30:31 +02:00
Remco Vermeulen
42e261ac02
Move SqlInjectionSink and PersistenceQueryInjectionSink
...
Join SqlInjectionSink and PersistenceQueryInjectionSink with
QueryInjectionSink to make its definition more transparent.
2020-07-09 10:21:24 +02:00
Remco Vermeulen
d07d21c9e2
Fix import
2020-07-09 10:20:53 +02:00
Anders Schack-Mulligen
777dc6305c
Merge pull request #3893 from aibaars/set-map-list-copy-of
...
Java: model some new Set,List,Map methods
2020-07-09 10:18:12 +02:00
Arthur Baars
6367eb9ee8
Address review comments
2020-07-08 22:08:27 +02:00
Remco Vermeulen
5f560e0465
Extract HeaderSplittingSink and WhitelistedSource
...
- Extract `HeaderSplittingSink` and `WhitelistedSource` into an
importable library.
- Rename the existing `HeaderSplittingSink` implementation to
`ServletHeaderSplittingSink`.
2020-07-08 17:17:24 +02:00
Remco Vermeulen
170be9ffe8
Move UrlRedirectSink into importable library
...
- The `UrlRedirect` class is renamed to `ServletUrlRedirect`.
- Abstract class `UrlRedirectSink` is defined that can be imported and
used to customise CWE-601 via Customizations.qll
2020-07-08 16:47:51 +02:00
Remco Vermeulen
06517c6f82
Move QueryInjectionSink into importable library
...
This enables defining of new sinks to customise the CWE-089 queries.
2020-07-08 16:24:06 +02:00
Arthur Baars
e8f216c761
Merge remote-tracking branch 'upstream/master' into set-map-list-copy-of
2020-07-08 15:11:13 +02:00
Anders Schack-Mulligen
bf5c5297d3
Merge pull request #3897 from aibaars/util-objects
...
Java: data flow for `java.util.Objects`
2020-07-08 15:07:50 +02:00
Anders Schack-Mulligen
48e4759632
Merge branch 'master' into java/spring-3653-2
2020-07-08 13:06:51 +02:00
Anders Schack-Mulligen
b38839e84e
Merge pull request #3920 from Marcono1234/patch-3
...
Improve VariableAssign.getSource documentation
2020-07-08 10:25:13 +02:00
Anders Schack-Mulligen
c166fee198
Merge pull request #3894 from aibaars/util-arrays
...
Java: model taint for java.util.Arrays
2020-07-08 09:06:40 +02:00
Marcono1234
00a61816c0
Improve VariableAssign.getSource documentation
2020-07-07 22:37:58 +02:00
Arthur Baars
441bf98ce7
Java: add Vector::copyInto, BlockingQueue::drainTo
2020-07-07 20:35:02 +02:00
Arthur Baars
c9ae2c8b2c
Java: ContainerFlow: organize taintPreservingArgumentToQualifier
2020-07-07 20:32:10 +02:00
Arthur Baars
5d73b99fd1
Java: ContainerFlow: organize taintPreservingQualifierToMethod
2020-07-07 19:53:11 +02:00
Arthur Baars
940fec5669
Drop taint tracking for Arrays.{deepToString,toString}
2020-07-07 17:26:49 +02:00
Arthur Baars
583f7f914e
Drop taint tracking for Arrays.{setAll, parallelSetAll, parallelPrefix}
2020-07-07 17:22:30 +02:00
Arthur Baars
9cf6601d02
Java: Data flow for java.util.Objects
2020-07-07 16:58:22 +02:00
Anders Schack-Mulligen
993506d781
Merge pull request #3820 from Marcono1234/patch-2
...
Add missing java.nio.file.Files methods to FileReadWrite.qll
2020-07-07 10:29:17 +02:00
Marcono1234
0a9686709b
Fix wrong method name
2020-07-06 18:52:07 +02:00
Anders Schack-Mulligen
f98460cfd0
Java: Use SpringHttpEntity class.
2020-07-06 16:54:20 +02:00
Anders Schack-Mulligen
ae21de90b6
Java: Misc grammar and formatting.
2020-07-06 16:19:42 +02:00
Anders Schack-Mulligen
b06d1c715a
Java: More qldoc and some formatting.
2020-07-06 16:04:14 +02:00
Marcono1234
6ff8508d01
Java: Clarify documentation for Location predicate results
2020-07-06 15:46:11 +02:00
