Erik Krogh Kristensen
a3c55c2aec
use set literal instead of big disjunction of literals
2021-10-26 12:55:25 +02:00
Surya Prakash Sahu
2871bdb206
Python SignatureOverriddenMethod: Rmv duplicate condition
2021-10-17 18:04:20 +05:30
Mathias Vorreiter Pedersen
bdc54bcda7
Python: Replace 'if p() then q() else none()' with a conjunction.
2021-10-13 12:13:55 +01:00
Rasmus Lerchedahl Petersen
e865a290de
Python: straight port of query
...
The old query uses `pointsTo` to limit the sinks
to methods on lists and dictionaries.
That constraint is omitted here which could hurt performance.
2021-08-24 16:35:11 +02:00
Ian Lynagh
f0bec74ce3
python: Correct the ReturnValueIgnored.qhelp docs
2021-05-26 17:40:57 +01:00
Chris Smowton
455b840712
Fix all dead qhelp links
...
For those documents with no obvious new home I've pointed the links to the Internet Archive.
2021-04-23 15:20:21 +01:00
Rasmus Wriedt Larsen
3fe715abb6
Python: Fix query names that inclde __ (dunder)
...
Without backticks, the text UNDERSCORE UNDERSCORE eq UNDERSCORE UNDERSCORE would
be considered to make things bold in our markdown output, making the query info
look strange.
Example https://codeql.github.com/codeql-query-help/python/py-slots-in-old-style-class/
2021-02-04 15:49:37 +01:00
Taus Brock-Nannestad
f07a7bf8cf
Python: Autoformat everything using qlformat.
...
Will need subsequent PRs fixing up test failures (due to deprecated
methods moving around), but other than that everything should be
straight-forward.
2020-07-07 15:43:52 +02:00
Rasmus Wriedt Larsen
d5895c16c8
Python: Changing signature in overriden method is not an error
...
Rather, fulfiling the Liskov substitution principle is an opinionated
recommendation. Looking at `py/inheritance/incorrect-overridden-signature` and
`py/mixed-tuple-returns`, it seems very appropriate that this should have
`@severity recommendation`, and `@sub-severity high`.
2020-06-22 16:58:52 +02:00
Rasmus Lerchedahl Petersen
1817d2af2b
Make test for wrong bool type pass
2020-05-14 15:56:57 +02:00
Rasmus Lerchedahl Petersen
d9d86e1f56
Make test pass
2020-05-13 12:16:11 +02:00
Rasmus Wriedt Larsen
4da5222255
Python: More safe methods for py/modification-of-default-value
...
Fixes https://github.com/github/codeql/issues/3397
2020-05-05 11:09:05 +02:00
Rebecca Valentine
9cd2171fb8
Merge branch 'master' into python-objectapi-to-valueapi-incorrectlyoverridenmethod
2020-04-22 09:40:33 -07:00
Taus
8402e6a2e1
Merge pull request #3243 from BekaValentine/python-objectapi-to-valueapi-incorrectlyspecifiedoverriddenmethod
...
Python: ObjectAPI to ValueAPI: IncorrectlySpecifiedOverriddenMethod
2020-04-14 18:55:42 +02:00
Taus
3e46604fa5
Merge pull request #3223 from BekaValentine/python-objectapi-to-valueapi-iterreturnsnoniterator
...
Python: ObjectAPI to ValueAPI: IterReturnsNonIterator
2020-04-14 12:55:21 +02:00
Rebecca Valentine
336e48c5c6
Python: ObjectAPI to ValueAPI: IncorrectlySpecifiedOverriddenMethod: Adds preliminary modernization
2020-04-09 14:50:26 -07:00
Rebecca Valentine
be00d71b99
Python: ObjectAPI to ValueAPI: IncorrectlyOverriddenMethod: Adds preliminary modernization
2020-04-09 14:41:22 -07:00
Rebecca Valentine
7a586c97a4
Python: ObjectAPI to ValueAPI: IterReturnsNonIterature: Replaces custom return_type predicate with call to getAnInferredReturnType
2020-04-09 14:30:40 -07:00
Rebecca Valentine
c2443f2342
Python: ObjectAPI to ValueAPI: OverlyComplexDelMethod: Adds preliminary modernization
2020-04-07 21:31:35 -07:00
Rebecca Valentine
0d65db148f
Python: ObjectAPI to ValueAPI: IterReturnsNonIterator: Adds preliminary modernization
2020-04-07 21:14:25 -07:00
Rebecca Valentine
712fb8badc
Python: ObjectAPI to ValueAPI: IterReturnsNonSelf: Autoformats
2020-04-02 09:19:41 -07:00
Rebecca Valentine
cdda80623d
Merge branch 'master' into python-objectapi-to-valueapi-iterreturnsnonself
2020-04-02 09:16:23 -07:00
Taus
d540bf6ce5
Merge pull request #3039 from BekaValentine/python-objectapi-to-valueapi-returnvalueignored
...
Python: ObjectAPI to ValueAPI: ReturnValueIgnored
2020-04-02 11:42:01 +02:00
Rebecca Valentine
cc53b15a5d
Python: ObjectAPI to ValueAPI: ReturnValueIgnored: Reorganizes predicates
2020-04-01 14:41:49 -07:00
Rebecca Valentine
09349f1957
Python: ObjectAPI to ValueAPI: ReturnValueIgnored: Autoformats
2020-04-01 12:54:42 -07:00
Rebecca Valentine
28319ee0f7
Python: ObjectAPI to ValueAPI: SignatureOverriddenMethod: Autoformats
2020-04-01 12:32:21 -07:00
Rebecca Valentine
838e37ca98
Python: ObjectAPI to ValueAPI: ReturnValueIgnore: Moves getAnInferredType to CallableObjectInternal
2020-04-01 08:45:27 -07:00
Rebecca Valentine
97b4077162
Merge branch 'master' into python-objectapi-to-valueapi-signatureoverriddenmethod
2020-04-01 07:42:10 -07:00
Rebecca Valentine
12377badf9
Merge branch 'master' into python-objectapi-to-valueapi-returnvalueignored
2020-04-01 07:37:17 -07:00
Rebecca Valentine
eb4a567a34
Merge branch 'master' into python-objectapi-to-valueapi-signatureoverriddenmethod
2020-03-31 23:36:15 -07:00
Rebecca Valentine
42388b0d97
Python: ObjectAPI to ValueAPI: ReturnValueIgnored: Adds prototype version of getAnInferredReturnType
2020-03-31 22:11:58 -07:00
Taus Brock-Nannestad
87a9f51c78
Python: Autoformat all .ql files.
2020-03-30 11:59:10 +02:00
Rebecca Valentine
160f6cbc15
Python: Adds preliminary modernization
2020-03-10 08:51:20 -07:00
Rebecca Valentine
b36214ae47
Python: Modernizes query and updates expecteds
2020-03-10 08:33:29 -07:00
Rebecca Valentine
6017197870
Python: Autoformats
2020-03-10 08:08:05 -07:00
Rebecca Valentine
4eb3de2aca
Merge branch 'master' into python-objectapi-to-valueapi-signatureoverriddenmethod
2020-03-10 08:06:45 -07:00
Taus
ea5aa57151
Merge pull request #3031 from BekaValentine/python-objectapi-to-valueapi-signaturespecialmethods
...
Python: ObjectAPI to ValueAPI: SignatureSpecialMethods
2020-03-10 14:54:39 +01:00
Rebecca Valentine
7ce905a310
Python: Adds preliminary modernization
2020-03-09 19:29:47 -07:00
Rebecca Valentine
bbeefd5747
Python: Modernizes query
2020-03-09 19:21:31 -07:00
Rebecca Valentine
e8708a083f
Python: Modernizes query and expecteds
2020-03-09 19:13:54 -07:00
Rebecca Valentine
48e67bca51
Python: Modernizes query
2020-03-09 18:57:42 -07:00
Rebecca Valentine
50c91b99da
Swaps correct_args_if_called_as_method globally
2020-02-25 11:01:51 -08:00
Rebecca Valentine
fb0cae76cf
Swaps wrong_args globally
2020-02-25 11:00:39 -08:00
Rebecca Valentine
2c32a859cc
Swaps illegally_named_parameter globally
2020-02-25 10:58:08 -08:00
Rebecca Valentine
cf4b7e1270
Swaps arg_count globally
2020-02-25 10:50:30 -08:00
jack1142
e1644dd68b
Python: Handle __class_getitem__ in py/not-named-self ( #2825 )
...
Fixes #2824
2020-02-13 13:38:36 +01:00
Rebecca Valentine
a8204385c3
Adds fix for __init_subclass__ bug. ( #2390 )
...
* Adds fix for __init_subclass__ bug.
* Adds test case.
* Move test on name.
I think it makes more sense here, alongside the other "special" method names.
2019-11-24 12:18:17 +01:00
Taus Brock-Nannestad
3c47394b7a
Python: Apply auto-format.
2019-11-18 16:28:54 +01:00
Taus Brock-Nannestad
cac261858c
Python: Don't report mutable parameters that are in fact immutable.
...
Fixes #1832 .
In the taint sink, we add an additional check that the given control-flow node
can indeed point to a value that is mutable. This takes care of the guard on the
type.
If and when we get around to adding configurations for all of the taint
analyses, we may want to implement this as a barrier instead, pruning any steps
that go through a type test where the type is not mutable.
2019-11-18 16:18:44 +01:00
Rasmus Wriedt Larsen
5c5eaacc09
Python: Remove cached annotation in py/iter-returns-non-iterator
2019-10-23 10:46:07 +02:00