hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: UnguardedNextInGenerator.ql: Excludes next with default value

Browse Source
This commit is contained in:
Rebecca Valentine
2020-03-16 17:08:06 -07:00
parent 2f3967cf5e
commit ff6e0ce35c
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
python/ql/src/Exceptions/UnguardedNextInGenerator.ql
View File

@@ -28,6 +28,10 @@ predicate call_to_next(CallNode call, ControlFlowNode iter) {
iter = next().getArgumentForCall(call, 0)
}
predicate call_to_next_has_default(CallNode call) {
exists(call.getArg(1))
}
predicate guarded_not_empty_sequence(EssaVariable sequence) {
sequence.getDefinition() instanceof EssaEdgeRefinement
}
@@ -49,6 +53,7 @@ predicate stop_iteration_handled(CallNode call) {
from CallNode call
where call_to_next(call, _) and
not call_to_next_has_default(call) and
not exists(EssaVariable iterator |
call_to_next(call, iterator.getAUse()) and
iter_not_exhausted(iterator)