hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2024-08-29 15:54:04 +02:00
parent 6d346dbedd
commit ff31aa540c
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
shared/dataflow/codeql/dataflow/internal/ContentDataFlowImpl.qll
View File

@@ -51,11 +51,6 @@ module MakeImplContentDataFlow<LocationSig Location, InputSig<Location> Lang> {
*/
default predicate isAdditionalFlowStep(Node node1, Node node2) { none() }
/**
* Holds if taint may propagate from `node1` to `node2` in addition to the normal data-flow steps.
*/
default predicate isAdditionalTaintStep(Node node1, Node node2) { none() }
/** Holds if data flow into `node` is prohibited. */
default predicate isBarrier(Node node) { none() }
@@ -106,11 +101,9 @@ module MakeImplContentDataFlow<LocationSig Location, InputSig<Location> Lang> {
predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) {
storeStep(node1, state1, _, node2, state2) or
readStep(node1, state1, _, node2, state2) or
additionalTaintStep(node1, state1, node2, state2)
additionalStep(node1, state1, node2, state2)
}
predicate isAdditionalFlowStep = ContentConfig::isAdditionalFlowStep/2;
predicate isBarrier = ContentConfig::isBarrier/1;
FlowFeature getAFeature() { result = ContentConfig::getAFeature() }
@@ -234,8 +227,8 @@ module MakeImplContentDataFlow<LocationSig Location, InputSig<Location> Lang> {
)
}
private predicate additionalTaintStep(Node node1, State state1, Node node2, State state2) {
ContentConfig::isAdditionalTaintStep(node1, node2) and
private predicate additionalStep(Node node1, State state1, Node node2, State state2) {
ContentConfig::isAdditionalFlowStep(node1, node2) and
(
state1 instanceof InitState and
state2.(InitState).decode(false)