Address review comments

This commit is contained in:
Tom Hvitved
2021-03-08 18:13:14 +01:00
parent 6e5af1a9f8
commit fe6efde449
28 changed files with 28 additions and 28 deletions

View File

@@ -765,7 +765,7 @@ private module Stage2 {
bindingset[result, ap]
private ApApprox getApprox(Ap ap) { any() }
private Ap getApNil(Node node) { PrevStage::revFlow(node, _) and result instanceof ApNil }
private ApNil getApNil(Node node) { PrevStage::revFlow(node, _) and exists(result) }
bindingset[tc, tail]
private Ap apCons(TypedContent tc, Ap tail) { result = true and exists(tc) and exists(tail) }

View File

@@ -765,7 +765,7 @@ private module Stage2 {
bindingset[result, ap]
private ApApprox getApprox(Ap ap) { any() }
private Ap getApNil(Node node) { PrevStage::revFlow(node, _) and result instanceof ApNil }
private ApNil getApNil(Node node) { PrevStage::revFlow(node, _) and exists(result) }
bindingset[tc, tail]
private Ap apCons(TypedContent tc, Ap tail) { result = true and exists(tc) and exists(tail) }

View File

@@ -765,7 +765,7 @@ private module Stage2 {
bindingset[result, ap]
private ApApprox getApprox(Ap ap) { any() }
private Ap getApNil(Node node) { PrevStage::revFlow(node, _) and result instanceof ApNil }
private ApNil getApNil(Node node) { PrevStage::revFlow(node, _) and exists(result) }
bindingset[tc, tail]
private Ap apCons(TypedContent tc, Ap tail) { result = true and exists(tc) and exists(tail) }

View File

@@ -765,7 +765,7 @@ private module Stage2 {
bindingset[result, ap]
private ApApprox getApprox(Ap ap) { any() }
private Ap getApNil(Node node) { PrevStage::revFlow(node, _) and result instanceof ApNil }
private ApNil getApNil(Node node) { PrevStage::revFlow(node, _) and exists(result) }
bindingset[tc, tail]
private Ap apCons(TypedContent tc, Ap tail) { result = true and exists(tc) and exists(tail) }

View File

@@ -765,7 +765,7 @@ private module Stage2 {
bindingset[result, ap]
private ApApprox getApprox(Ap ap) { any() }
private Ap getApNil(Node node) { PrevStage::revFlow(node, _) and result instanceof ApNil }
private ApNil getApNil(Node node) { PrevStage::revFlow(node, _) and exists(result) }
bindingset[tc, tail]
private Ap apCons(TypedContent tc, Ap tail) { result = true and exists(tc) and exists(tail) }

View File

@@ -755,7 +755,7 @@ pragma[inline]
DataFlowCallable getNodeEnclosingCallable(Node n) {
exists(Node n0 |
pragma[only_bind_into](n0) = n and
result = n0.getEnclosingCallable()
pragma[only_bind_into](result) = n0.getEnclosingCallable()
)
}