mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
CI: fix python version
Turns out this is important for the black formatting tool to work correctly. The formatting won't generally change between python versions (it only depends on `black`'s version), but the formatted code needs to be parseable by the system python version. One script uses ```python def foo[T](x: T) -> T: ``` syntax, which is only supported in Python 3.12 and later. Running `pre-commit` will now require a python 3.12 installation (which is already what we mandate for internal developer environment setup). The error in case of absence of such a version is pretty clear though.
This commit is contained in:
3
.github/workflows/python-tooling.yml
vendored
3
.github/workflows/python-tooling.yml
vendored
@@ -22,6 +22,9 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
- uses: actions/setup-python@v5
|
||||||
|
with:
|
||||||
|
python-version: '3.12'
|
||||||
- uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507
|
- uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507
|
||||||
name: Check that python code is properly formatted
|
name: Check that python code is properly formatted
|
||||||
with:
|
with:
|
||||||
|
|||||||
@@ -1,5 +1,7 @@
|
|||||||
# See https://pre-commit.com for more information
|
# See https://pre-commit.com for more information
|
||||||
# See https://pre-commit.com/hooks.html for more hooks
|
# See https://pre-commit.com/hooks.html for more hooks
|
||||||
|
default_language_version:
|
||||||
|
python: python3.12
|
||||||
repos:
|
repos:
|
||||||
- repo: https://github.com/pre-commit/pre-commit-hooks
|
- repo: https://github.com/pre-commit/pre-commit-hooks
|
||||||
rev: v3.2.0
|
rev: v3.2.0
|
||||||
|
|||||||
@@ -116,9 +116,7 @@ def clone_project(project: Project) -> str:
|
|||||||
return target_dir
|
return target_dir
|
||||||
|
|
||||||
|
|
||||||
def run_in_parallel[
|
def run_in_parallel[T, U](
|
||||||
T, U
|
|
||||||
](
|
|
||||||
func: Callable[[T], U],
|
func: Callable[[T], U],
|
||||||
items: List[T],
|
items: List[T],
|
||||||
*,
|
*,
|
||||||
@@ -516,7 +514,7 @@ if __name__ == "__main__":
|
|||||||
"--dca",
|
"--dca",
|
||||||
type=str,
|
type=str,
|
||||||
help="Name of a DCA run that built all the projects. Can be repeated, with sources taken from all provided runs, "
|
help="Name of a DCA run that built all the projects. Can be repeated, with sources taken from all provided runs, "
|
||||||
"the last provided ones having priority",
|
"the last provided ones having priority",
|
||||||
action="append",
|
action="append",
|
||||||
)
|
)
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
|
|||||||
Reference in New Issue
Block a user