hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: filter out obvious module 'prepend' calls

Browse Source
This commit is contained in:
Asger F
2022-10-02 12:15:58 +02:00
parent 00e52ad109
commit fd9c1e4507
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ruby/ql/lib/codeql/ruby/frameworks/core/Array.qll
View File

@@ -1142,7 +1142,12 @@ module Array {
this = mc.getMethodName() + "(" + mc.getNumberOfArguments() + ")"
}
override MethodCall getACallSimple() { result = mc }
override MethodCall getACallSimple() {
result = mc and
// Filter out obvious 'prepend' calls in a module scope
// Including such calls is mostly harmless but also easy to filter out
not result.getReceiver().(SelfVariableAccess).getCfgScope() instanceof ModuleBase
}
override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {
exists(int num | num = mc.getNumberOfArguments() and preservesValue = true |