hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update OS Check from Review Feedback

Browse Source
This commit is contained in:
Jonathan Leitschuh
2022-02-28 19:43:55 -05:00
parent 9f5022ee95
commit fd63107edf
8 changed files with 164 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql
View File

@@ -104,17 +104,17 @@ private class FileCreateTempFileSink extends FileCreationSink {
}
/**
* A guard that checks what OS the program is running on.
* A guard that checks whether or not the the program is running on the Windows OS.
*/
abstract private class OsBarrierGuard extends DataFlow::BarrierGuard { }
abstract private class WindowsOsBarrierGuard extends DataFlow::BarrierGuard { }
private class IsUnixBarrierGuard extends OsBarrierGuard instanceof IsUnixGuard {
private class IsNotUnixBarrierGuard extends WindowsOsBarrierGuard instanceof IsUnixGuard {
override predicate checks(Expr e, boolean branch) {
this.controls(e.getBasicBlock(), branch.booleanNot())
}
}
private class IsWindowsBarrierGuard extends OsBarrierGuard instanceof IsWindowsGuard {
private class IsWindowsBarrierGuard extends WindowsOsBarrierGuard instanceof IsWindowsGuard {
override predicate checks(Expr e, boolean branch) { this.controls(e.getBasicBlock(), branch) }
}
@@ -147,7 +147,7 @@ private class TempDirSystemGetPropertyToCreateConfig extends TaintTracking::Conf
}
override predicate isSanitizerGuard(DataFlow::BarrierGuard guard) {
guard instanceof OsBarrierGuard
guard instanceof WindowsOsBarrierGuard
}
}