From fcfb7b2b8a97c77ae6d9d7639dd19c8cbeb96154 Mon Sep 17 00:00:00 2001 From: Calum Grant Date: Wed, 22 May 2019 16:14:40 +0100 Subject: [PATCH] C#: Fix error caused by Roslyn upgrade. --- .../Semmle.Extraction.CSharp/Entities/Modifier.cs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Modifier.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Modifier.cs index f9ae8eb9d7a..71b63dbceb5 100644 --- a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Modifier.cs +++ b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Modifier.cs @@ -139,16 +139,9 @@ namespace Semmle.Extraction.CSharp.Entities if (nt.TypeKind == TypeKind.Struct) { - // Sadly, these properties are internal so cannot be accessed directly. - // This seems to be a deficiency in the model. - var readonlyProperty = nt.GetType().GetProperty("IsReadOnly", BindingFlags.NonPublic | BindingFlags.Instance); - - bool isReadOnly = (bool)readonlyProperty.GetValue(nt); - bool isByRefLikeType = nt.IsRefLikeType; - - if (isReadOnly) + if (nt.IsReadOnly) HasModifier(cx, key, "readonly"); - if (isByRefLikeType) + if (nt.IsRefLikeType) HasModifier(cx, key, "ref"); } }