Replaceing query and test files with suggested ones

javascript/ql/src/Electron/EnablingNodeIntegration.ql

@@ -1,28 +1,32 @@
 /**
- * @name Enabling nodeIntegration and nodeIntegrationInWorker in webPreferences
+ * @name Enabling `nodeIntegration` or `nodeIntegrationInWorker` for Electron web content
- * @description Enabling nodeIntegration and nodeIntegrationInWorker could expose your app to remote code execution.
+ * @description Enabling `nodeIntegration` or `nodeIntegrationInWorker` can expose the application to remote code execution.
  * @kind problem
  * @problem.severity warning
- * @precision very-high
+ * @id js/enabling-electron-renderer-node-integration
  * @tags security
  *       frameworks/electron
- * @id js/enabling-electron-renderer-node-integration
  */
 
 import javascript
 
-string checkWebOptions(DataFlow::PropWrite prop, Electron::WebPreferences pref) {
+/**
-	(prop = pref.getAPropertyWrite("nodeIntegration") and 
+ * Gets a warning message for `pref` if one of the `nodeIntegration` features is enabled.
-	 prop.getRhs().mayHaveBooleanValue(true) and
+ */
-	 result = "nodeIntegration property may have been enabled on this object that could result in RCE")
+string getNodeIntegrationWarning(Electron::WebPreferences pref) {
+	exists (string feature |
+		feature = "nodeIntegration" or
+		feature = "nodeIntegrationInWorker" |
+		pref.getAPropertyWrite(feature).getRhs().mayHaveBooleanValue(true) and
+		result = "The `" + feature + "` feature has been enabled."
+	)
 	or
-	(prop = pref.getAPropertyWrite("nodeIntegrationInWorker") and
+	exists (string feature |
-	 prop.getRhs().mayHaveBooleanValue(true) and
+		feature = "nodeIntegration" |
-	 result = "nodeIntegrationInWorker property may have been enabled on this object that could result in RCE")
+		not exists(pref.getAPropertyWrite(feature)) and
-	or
+		result = "The `" + feature + "` feature is enabled by default."
-	(not exists(pref.asExpr().(ObjectExpr).getPropertyByName("nodeIntegration")) and
+	)
-	 result = "nodeIntegration is enabled by default in WebPreferences object that could result in RCE")
 }
 
-from DataFlow::PropWrite property, Electron::WebPreferences preferences 
+from Electron::WebPreferences preferences
-select preferences,checkWebOptions(property, preferences)
+select preferences, getNodeIntegrationWarning(preferences)

javascript/ql/test/query-tests/Electron/NodeIntegration/EnablingNodeIntegration.expected

@@ -1,5 +1,5 @@
-| EnablingNodeIntegration.js:5:28:11:9 | {\\n      ...       } | nodeIntegration property may have been enabled on this object that could result in RCE |
+| EnablingNodeIntegration.js:5:28:11:9 | {\\n      ...       } | The `nodeIntegrationInWorker` feature has been enabled. |
-| EnablingNodeIntegration.js:5:28:11:9 | {\\n      ...       } | nodeIntegrationInWorker property may have been enabled on this object that could result in RCE |
+| EnablingNodeIntegration.js:5:28:11:9 | {\\n      ...       } | The `nodeIntegration` feature has been enabled. |
-| EnablingNodeIntegration.js:15:22:20:9 | {\\n      ...       } | nodeIntegration is enabled by default in WebPreferences object that could result in RCE |
+| EnablingNodeIntegration.js:15:22:20:9 | {\\n      ...       } | The `nodeIntegration` feature is enabled by default. |
-| EnablingNodeIntegration.js:23:13:27:9 | {\\n      ...       } | nodeIntegration is enabled by default in WebPreferences object that could result in RCE |
+| EnablingNodeIntegration.js:23:16:27:9 | { // NO ...       } | The `nodeIntegration` feature is enabled by default. |
-| EnablingNodeIntegration.js:49:71:49:93 | {nodeIn ... : true} | nodeIntegration property may have been enabled on this object that could result in RCE |
+| EnablingNodeIntegration.js:49:74:49:96 | {nodeIn ... : true} | The `nodeIntegration` feature has been enabled. |

javascript/ql/test/query-tests/Electron/NodeIntegration/EnablingNodeIntegration.js

@@ -1,7 +1,7 @@
 const {BrowserWindow} = require('electron')
 
 function test() {
-    var unsafe_1 = {
+    var unsafe_1 = { // NOT OK, both enabled
            webPreferences: {
             nodeIntegration: true,
 			nodeIntegrationInWorker: true,
@@ -11,7 +11,7 @@ function test() {
         }
     };
     
-    var options_1 = {
+    var options_1 = { // NOT OK, `nodeIntegrationInWorker` enabled
 	    webPreferences: {
             plugins: true,
 			nodeIntegrationInWorker: false,
@@ -20,13 +20,13 @@ function test() {
         }
     };
     
-	var pref = {
+    var pref = { // NOT OK, implicitly enabled
             plugins: true,
             webSecurity: true,
             sandbox: true     
         };
 	
-    var options_2 = {
+    var options_2 = {  // NOT OK, implicitly enabled
             webPreferences: pref,
             show: true,
             frame: true,
@@ -34,7 +34,7 @@ function test() {
             minHeight: 300
     };
 
-    var safe_used = {
+    var safe_used = { // NOT OK, explicitly disabled
         webPreferences: {
             nodeIntegration: false,			
             plugins: true,
@@ -46,6 +46,7 @@ function test() {
     var w1 = new BrowserWindow(unsafe_1);
     var w2 = new BrowserWindow(options_1);
     var w3 = new BrowserWindow(safe_used);
-	var w4 = new BrowserWindow({width: 800, height: 600, webPreferences: {nodeIntegration: true}});	
+    var w4 = new BrowserWindow({width: 800, height: 600, webPreferences: {nodeIntegration: true}});	 // NOT OK, `nodeIntegration` enabled
     var w5 = new BrowserWindow(options_2);
+    var w6 = new BrowserWindow(safe_used);
 }

javascript/ql/test/query-tests/Electron/NodeIntegration/EnablingNodeIntegration.qlref

@@ -1 +1 @@
-../../../../src/Electron/EnablingNodeIntegration.ql
+Electron/EnablingNodeIntegration.ql