hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 19:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replaceing query and test files with suggested ones

Browse Source
This commit is contained in:
Behrang Fouladi Azarnaminy
2018-09-11 12:32:56 -07:00
parent befca6cafa
commit fc087ffb71
4 changed files with 35 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
javascript/ql/src/Electron/EnablingNodeIntegration.ql
View File

@@ -1,28 +1,32 @@
/**
* @name Enabling nodeIntegration and nodeIntegrationInWorker in webPreferences
* @description Enabling nodeIntegration and nodeIntegrationInWorker could expose your app to remote code execution.
* @name Enabling `nodeIntegration` or `nodeIntegrationInWorker` for Electron web content
* @description Enabling `nodeIntegration` or `nodeIntegrationInWorker` can expose the application to remote code execution.
* @kind problem
* @problem.severity warning
* @precision very-high
* @id js/enabling-electron-renderer-node-integration
* @tags security
* frameworks/electron
* @id js/enabling-electron-renderer-node-integration
*/
import javascript
string checkWebOptions(DataFlow::PropWrite prop, Electron::WebPreferences pref) {
(prop = pref.getAPropertyWrite("nodeIntegration") and
prop.getRhs().mayHaveBooleanValue(true) and
result = "nodeIntegration property may have been enabled on this object that could result in RCE")
/**
* Gets a warning message for `pref` if one of the `nodeIntegration` features is enabled.
*/
string getNodeIntegrationWarning(Electron::WebPreferences pref) {
exists (string feature |
feature = "nodeIntegration" or
feature = "nodeIntegrationInWorker" |
pref.getAPropertyWrite(feature).getRhs().mayHaveBooleanValue(true) and
result = "The `" + feature + "` feature has been enabled."
)
or
(prop = pref.getAPropertyWrite("nodeIntegrationInWorker") and
prop.getRhs().mayHaveBooleanValue(true) and
result = "nodeIntegrationInWorker property may have been enabled on this object that could result in RCE")
or
(not exists(pref.asExpr().(ObjectExpr).getPropertyByName("nodeIntegration")) and
result = "nodeIntegration is enabled by default in WebPreferences object that could result in RCE")
exists (string feature |
feature = "nodeIntegration" |
not exists(pref.getAPropertyWrite(feature)) and
result = "The `" + feature + "` feature is enabled by default."
)
}
from DataFlow::PropWrite property, Electron::WebPreferences preferences
select preferences,checkWebOptions(property, preferences)
from Electron::WebPreferences preferences
select preferences, getNodeIntegrationWarning(preferences)