diff --git a/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll b/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll index 75b77771e84..154430794d4 100644 --- a/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll +++ b/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll @@ -1,7 +1,5 @@ private import cpp -Function viableImpl(Call call) { result = viableCallable(call) } - /** * Gets a function that might be called by `call`. */ diff --git a/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll index dc035ec8681..a0fd5dc4c50 100644 --- a/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll +++ b/cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll @@ -132,16 +132,6 @@ OutNode getAnOutNode(DataFlowCall call, ReturnKind kind) { */ predicate jumpStep(Node n1, Node n2) { none() } -/** - * Holds if `call` passes an implicit or explicit qualifier, i.e., a - * `this` parameter. - */ -predicate callHasQualifier(Call call) { - call.hasQualifier() - or - call.getTarget() instanceof Destructor -} - private newtype TContent = TFieldContent(Field f) or TCollectionContent() or diff --git a/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll b/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll index cebeda25a6e..f1d8c21595e 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll @@ -3,8 +3,6 @@ private import semmle.code.cpp.ir.IR private import semmle.code.cpp.ir.dataflow.DataFlow private import semmle.code.cpp.ir.dataflow.internal.DataFlowPrivate -Function viableImpl(CallInstruction call) { result = viableCallable(call) } - /** * Gets a function that might be called by `call`. */ diff --git a/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll index b6d3db23c96..83e5d5eb06b 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll @@ -67,16 +67,6 @@ OutNode getAnOutNode(DataFlowCall call, ReturnKind kind) { */ predicate jumpStep(Node n1, Node n2) { none() } -/** - * Holds if `call` passes an implicit or explicit qualifier, i.e., a - * `this` parameter. - */ -predicate callHasQualifier(Call call) { - call.hasQualifier() - or - call.getTarget() instanceof Destructor -} - private newtype TContent = TFieldContent(Field f) or TCollectionContent() or diff --git a/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll b/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll index daf09497dc4..27d80d8df8d 100644 --- a/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll +++ b/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll @@ -120,7 +120,7 @@ predicate jumpStep(Node node1, Node node2) { * Holds if `fa` is an access to an instance field that occurs as the * destination of an assignment of the value `src`. */ -predicate instanceFieldAssign(Expr src, FieldAccess fa) { +private predicate instanceFieldAssign(Expr src, FieldAccess fa) { exists(AssignExpr a | a.getSource() = src and a.getDest() = fa and