hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Improve join ordering further for InterpretedCallable.

Browse Source
This commit is contained in:
Michael Nebel
2022-09-22 19:10:14 +02:00
parent 32816fa68f
commit faf33efeb8
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll
View File

@@ -511,8 +511,17 @@ private predicate callableSpecInfo(Callable c, string namespace, string type, st
}
pragma[nomagic]
private predicate subtypeSpecCandidate(Callable c, UnboundValueOrRefType t) {
elementSpec(_, _, true, c.getName(), _, _, t)
private predicate subtypeSpecCandidate(string name, UnboundValueOrRefType t) {
exists(UnboundValueOrRefType t0 |
elementSpec(_, _, true, name, _, _, t0) and
t = t0.getASubTypeUnbound+()
)
}
pragma[nomagic]
private predicate callableInfo(Callable c, string name, UnboundValueOrRefType decl) {
name = c.getName() and
decl = c.getDeclaringType()
}
private class InterpretedCallable extends Callable {
@@ -522,9 +531,9 @@ private class InterpretedCallable extends Callable {
elementSpec(namespace, type, _, name, _, _)
)
or
exists(UnboundValueOrRefType t |
subtypeSpecCandidate(this, t) and
this.getDeclaringType() = t.getASubTypeUnbound+()
exists(string name, UnboundValueOrRefType t |
callableInfo(this, name, t) and
subtypeSpecCandidate(name, t)
)
}
}