hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: improve alert location of js/angular/unused-dependency

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-12-11 14:16:57 +01:00
parent b5bbf990b0
commit fac638ffab
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/src/AngularJS/UnusedAngularDependency.ql
View File

@@ -11,6 +11,7 @@
import javascript import javascript
import Declarations.UnusedParameter import Declarations.UnusedParameter
import semmle.javascript.RestrictedLocations
predicate isUnusedParameter(Function f, string msg, Parameter parameter) { predicate isUnusedParameter(Function f, string msg, Parameter parameter) {
exists(Variable pv | exists(Variable pv |
@@ -36,4 +37,4 @@ predicate isMissingParameter(AngularJS::InjectableFunction f, string msg, ASTNod
from AngularJS::InjectableFunction f, string message, ASTNode location from AngularJS::InjectableFunction f, string message, ASTNode location
where isUnusedParameter(f.asFunction(), message, location) or isMissingParameter(f, message, location) where isUnusedParameter(f.asFunction(), message, location) or isMissingParameter(f, message, location)
select location, message select (FirstLineOf)location, message

1
javascript/ql/test/query-tests/AngularJS/UnusedAngularDependency/UnusedAngularDependency.expected
View File

@@ -2,3 +2,4 @@
| unused-angular-dependency.js:14:14:14:39 | ["unuse ... n() {}] | This function has 0 parameters, but 1 dependency is injected into it. | | unused-angular-dependency.js:14:14:14:39 | ["unuse ... n() {}] | This function has 0 parameters, but 1 dependency is injected into it. |
| unused-angular-dependency.js:16:14:16:53 | ["used2 ... d2) {}] | This function has 1 parameter, but 2 dependencies are injected into it. | | unused-angular-dependency.js:16:14:16:53 | ["used2 ... d2) {}] | This function has 1 parameter, but 2 dependencies are injected into it. |
| unused-angular-dependency.js:17:14:17:52 | ["unuse ... n() {}] | This function has 0 parameters, but 2 dependencies are injected into it. | | unused-angular-dependency.js:17:14:17:52 | ["unuse ... n() {}] | This function has 0 parameters, but 2 dependencies are injected into it. |
| unused-angular-dependency.js:18:14:18:105 | ["used2 ... }] | This function has 1 parameter, but 2 dependencies are injected into it. |

2
javascript/ql/test/query-tests/AngularJS/UnusedAngularDependency/unused-angular-dependency.js
View File

@@ -15,6 +15,8 @@
.run(f2) .run(f2)
.run(["used2", "unused9", function(used2) {}]) // NOT OK .run(["used2", "unused9", function(used2) {}]) // NOT OK
.run(["unused10", "unused11", function() {}]) // NOT OK .run(["unused10", "unused11", function() {}]) // NOT OK
.run(["used2", "unused12", function(used2) { // NOT OK (alert formatting for multi-line function)
}])
; ;
})(); })();
angular.module('app2') angular.module('app2')