Tag remaining high precision quality queries

Excluded queries that are python 2 specific; as well as the cyclic import queries
2026-04-27 01:35:13 +02:00 · 2025-06-18 11:45:44 +01:00
parent 02f8ec33f2
commit fa5b2ef794
20 changed files with 46 additions and 27 deletions
--- a/python/ql/src/Classes/DefineEqualsWhenAddingAttributes.ql
+++ b/python/ql/src/Classes/DefineEqualsWhenAddingAttributes.ql
@@ -2,7 +2,8 @@
 * @name `__eq__` not overridden when adding attributes
 * @description When adding new attributes to instances of a class, equality for that class needs to be defined.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity warning
 * @sub-severity high
--- a/python/ql/src/Classes/InconsistentMRO.ql
+++ b/python/ql/src/Classes/InconsistentMRO.ql
@@ -2,7 +2,8 @@
 * @name Inconsistent method resolution order
 * @description Class definition will raise a type error at runtime due to inconsistent method resolution order(MRO)
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity error
 * @sub-severity high
--- a/python/ql/src/Exceptions/IllegalExceptionHandlerType.ql
+++ b/python/ql/src/Exceptions/IllegalExceptionHandlerType.ql
@@ -2,9 +2,9 @@
 * @name Non-exception in 'except' clause
 * @description An exception handler specifying a non-exception type will never handle any exception.
 * @kind problem
- * @tags reliability
- *       correctness
- *       types
+ * @tags quality
+ *       reliability
+ *       error-handling
 * @problem.severity error
 * @sub-severity low
 * @precision very-high
--- a/python/ql/src/Expressions/Comparisons/UselessComparisonTest.ql
+++ b/python/ql/src/Expressions/Comparisons/UselessComparisonTest.ql
@@ -2,7 +2,9 @@
 * @name Redundant comparison
 * @description The result of a comparison is implied by a previous comparison.
 * @kind problem
- * @tags useless-code
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 *       external/cwe/cwe-570
 *       external/cwe/cwe-571
--- a/python/ql/src/Expressions/Formatting/MixedExplicitImplicitIn3101Format.ql
+++ b/python/ql/src/Expressions/Formatting/MixedExplicitImplicitIn3101Format.ql
@@ -3,7 +3,8 @@
 * @description Using implicit and explicit numbering in string formatting operations, such as '"{}: {1}".format(a,b)', will raise a ValueError.
 * @kind problem
 * @problem.severity error
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @sub-severity low
 * @precision high
--- a/python/ql/src/Expressions/Formatting/UnusedArgumentIn3101Format.ql
+++ b/python/ql/src/Expressions/Formatting/UnusedArgumentIn3101Format.ql
@@ -2,7 +2,8 @@
 * @name Unused argument in a formatting call
 * @description Including surplus arguments in a formatting call makes code more difficult to read and may indicate an error.
 * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       useless-code
 * @problem.severity warning
 * @sub-severity high
--- a/python/ql/src/Expressions/Formatting/UnusedNamedArgumentIn3101Format.ql
+++ b/python/ql/src/Expressions/Formatting/UnusedNamedArgumentIn3101Format.ql
@@ -2,7 +2,8 @@
 * @name Unused named argument in formatting call
 * @description Including surplus keyword arguments in a formatting call makes code more difficult to read and may indicate an error.
 * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       useless-code
 * @problem.severity warning
 * @sub-severity high
--- a/python/ql/src/Expressions/Formatting/WrongNameInArgumentsFor3101Format.ql
+++ b/python/ql/src/Expressions/Formatting/WrongNameInArgumentsFor3101Format.ql
@@ -4,7 +4,8 @@
 *              where the names of format items in the format string differs from the names of the values to be formatted will raise a KeyError.
 * @kind problem
 * @problem.severity error
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @sub-severity low
 * @precision high
--- a/python/ql/src/Expressions/Formatting/WrongNumberArgumentsFor3101Format.ql
+++ b/python/ql/src/Expressions/Formatting/WrongNumberArgumentsFor3101Format.ql
@@ -3,7 +3,8 @@
 * @description A string formatting operation, such as '"{0}: {1}, {2}".format(a,b)',
 *              where the number of values to be formatted is too few for the format string will raise an IndexError.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity error
 * @sub-severity low
--- a/python/ql/src/Expressions/Regex/BackspaceEscape.ql
+++ b/python/ql/src/Expressions/Regex/BackspaceEscape.ql
@@ -3,7 +3,9 @@
 * @description Using '\b' to escape the backspace character in a regular expression is confusing
 *              since it could be mistaken for a word boundary assertion.
 * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
 * @problem.severity recommendation
 * @sub-severity high
 * @precision very-high
--- a/python/ql/src/Expressions/Regex/DuplicateCharacterInSet.ql
+++ b/python/ql/src/Expressions/Regex/DuplicateCharacterInSet.ql
@@ -2,7 +2,8 @@
 * @name Duplication in regular expression character class
 * @description Duplicate characters in a class have no effect and may indicate an error in the regular expression.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       readability
 * @problem.severity warning
 * @sub-severity low
--- a/python/ql/src/Expressions/Regex/MissingPartSpecialGroup.ql
+++ b/python/ql/src/Expressions/Regex/MissingPartSpecialGroup.ql
@@ -2,7 +2,8 @@
 * @name Missing part of special group in regular expression
 * @description Incomplete special groups are parsed as normal groups and are unlikely to match the intended strings.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity warning
 * @sub-severity high
--- a/python/ql/src/Expressions/Regex/UnmatchableCaret.ql
+++ b/python/ql/src/Expressions/Regex/UnmatchableCaret.ql
@@ -2,7 +2,8 @@
 * @name Unmatchable caret in regular expression
 * @description Regular expressions containing a caret '^' in the middle cannot be matched, whatever the input.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity error
 * @sub-severity low
--- a/python/ql/src/Expressions/Regex/UnmatchableDollar.ql
+++ b/python/ql/src/Expressions/Regex/UnmatchableDollar.ql
@@ -2,7 +2,8 @@
 * @name Unmatchable dollar in regular expression
 * @description Regular expressions containing a dollar '$' in the middle cannot be matched, whatever the input.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 * @problem.severity error
 * @sub-severity low
--- a/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql
+++ b/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql
@@ -3,7 +3,8 @@
 * @description A string formatting operation, such as '"%s: %s, %s" % (a,b)', where the number of conversion specifiers in the
 *              format string differs from the number of values to be formatted will raise a TypeError.
 * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-685
 * @problem.severity error
--- a/python/ql/src/Lexical/CommentedOutCode.ql
+++ b/python/ql/src/Lexical/CommentedOutCode.ql
@@ -2,9 +2,9 @@
 * @name Commented-out code
 * @description Commented-out code makes the remaining code more difficult to read.
 * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       readability
- *       documentation
 * @problem.severity recommendation
 * @sub-severity high
 * @precision high
--- a/python/ql/src/Statements/ShouldUseWithStatement.ql
+++ b/python/ql/src/Statements/ShouldUseWithStatement.ql
@@ -3,9 +3,9 @@
 * @description Using a 'try-finally' block to ensure only that a resource is closed makes code more
 *              difficult to read.
 * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       readability
- *       convention
 * @problem.severity recommendation
 * @sub-severity high
 * @precision very-high
--- a/python/ql/src/Statements/UnusedExceptionObject.ql
+++ b/python/ql/src/Statements/UnusedExceptionObject.ql
@@ -2,8 +2,9 @@
 * @name Unused exception object
 * @description An exception object is created, but is not used.
 * @kind problem
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
 * @problem.severity error
 * @sub-severity low
 * @precision very-high
--- a/python/ql/src/Testing/ImpreciseAssert.ql
+++ b/python/ql/src/Testing/ImpreciseAssert.ql
@@ -2,8 +2,9 @@
 * @name Imprecise assert
 * @description Using 'assertTrue' or 'assertFalse' rather than a more specific assertion can give uninformative failure messages.
 * @kind problem
- * @tags maintainability
- *       testability
+ * @tags quality
+ *       maintainability
+ *       readability
 * @problem.severity recommendation
 * @sub-severity high
 * @precision very-high
--- a/python/ql/src/Variables/UndefinedExport.ql
+++ b/python/ql/src/Variables/UndefinedExport.ql
@@ -3,8 +3,9 @@
 * @description Including an undefined attribute in `__all__` causes an exception when
 *              the module is imported using '*'
 * @kind problem
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 * @problem.severity error
 * @sub-severity low
 * @precision high