hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20438 from MathiasVP/remove-antijoin-in-shared-guards

Browse Source 
Shared: Remove antijoin from `Guards.qll`
This commit is contained in:
Mathias Vorreiter Pedersen
2025-09-16 10:40:45 +01:00
committed by GitHub
parent 0ceb2f3f72 18c96fd7d4
commit fa36d9f84e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shared/controlflow/codeql/controlflow/Guards.qll
View File

@@ -731,13 +731,14 @@ module Make<
private predicate impliesStep1(Guard g1, GuardValue v1, Guard g2, GuardValue v2) { private predicate impliesStep1(Guard g1, GuardValue v1, Guard g2, GuardValue v2) {
baseImpliesStep(g1, v1, g2, v2) baseImpliesStep(g1, v1, g2, v2)
or or
exists(SsaDefinition def, Expr e | exists(SsaDefinition def, Expr e, BasicBlock bb1 |
// If `def = g2 ? v1 : ...` and all other assignments to `def` are different from // If `def = g2 ? v1 : ...` and all other assignments to `def` are different from
// `v1` then a guard proving `def == v1` ensures that `g2` evaluates to `v2`. // `v1` then a guard proving `def == v1` ensures that `g2` evaluates to `v2`.
uniqueValue(def, e, v1) and uniqueValue(def, e, v1) and
guardReadsSsaVar(g1, def) and guardReadsSsaVar(g1, def) and
g2.directlyValueControls(e.getBasicBlock(), v2) and g2.directlyValueControls(e.getBasicBlock(), v2) and
not g2.directlyValueControls(g1.getBasicBlock(), v2) bb1 = g1.getBasicBlock() and
not g2.directlyValueControls(bb1, v2)
) )
or or
exists(int k, boolean upper | exists(int k, boolean upper |