hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-21 06:57:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ensure pattern-case and binding-instanceof are covered in all of type, dispatch and object flow

Browse Source
This commit is contained in:
Chris Smowton
2023-11-09 15:48:24 +00:00
parent 88d9caff8c
commit fa09be0459
3 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/lib/semmle/code/java/dispatch/DispatchFlow.qll
View File

@@ -167,6 +167,20 @@ private module TypeTrackingSteps {
def.(BaseSsaUpdate).getDefiningExpr().(VariableAssign).getSource() = n1.asExpr()
or
def.(BaseSsaImplicitInit).isParameterDefinition(n1.asParameter())
or
exists(PatternCase pc |
pc.getPattern().asBindingPattern() = def.(BaseSsaUpdate).getDefiningExpr() and
(
pc.getSwitch().getExpr() = n1.asExpr()
or
pc.getSwitchExpr().getExpr() = n1.asExpr()
)
)
or
exists(InstanceOfExpr ioe |
ioe.getPattern().asBindingPattern() = def.(BaseSsaUpdate).getDefiningExpr() and
ioe.getExpr() = n1.asExpr()
)
|
v.getAnUltimateDefinition() = def and
v.getAUse() = n2.asExpr()

5
java/ql/lib/semmle/code/java/dispatch/ObjFlow.qll
View File

@@ -89,6 +89,11 @@ private predicate step(Node n1, Node n2) {
pc.getSwitchExpr().getExpr() = n1.asExpr()
)
)
or
exists(InstanceOfExpr ioe |
ioe.getPattern().asBindingPattern() = def.(BaseSsaUpdate).getDefiningExpr() and
ioe.getExpr() = n1.asExpr()
)
|
v.getAnUltimateDefinition() = def and
v.getAUse() = n2.asExpr()