hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ql4Ql: Address review comments and update expected test output.

Browse Source
This commit is contained in:
Michael Nebel
2025-07-03 11:26:11 +02:00
parent b79e2dd0ba
commit f810e17d9e
2 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ql/ql/src/queries/style/MissingQualityMetadata.ql
View File

@@ -34,14 +34,19 @@ where
msg =
"This query file has incorrect top-level categorisation. It should have exactly one top-level category, either `@tags maintainability` or `@tags reliability`."
or
correctTopLevelCategorisation(doc) and
(
doc.getAQueryTag() = "reliability" and
not reliabilitySubCategory(doc) and
maintainabilitySubCategory(doc) and
not doc.getAQueryTag() = "maintainability" and
msg =
"This query file has a sub-category of maintainability but is missing the `@tags maintainability` tag."
"This query file has a sub-category of maintainability but has the `@tags reliability` tag."
or
doc.getAQueryTag() = "maintainability" and
not maintainabilitySubCategory(doc) and
reliabilitySubCategory(doc) and
not doc.getAQueryTag() = "reliability" and
msg =
"This query file has a sub-category of reliability but is missing the `@tags reliability` tag."
"This query file has a sub-category of reliability but has the `@tags maintainability` tag."
)
)
select doc, msg

6
ql/ql/test/queries/style/MissingQualityMetadata/MissingQualityMetadata.expected
View File

@@ -1,6 +1,4 @@
| testcases/BadQualityMaintainabilityWrongToplevel.ql:1:1:11:3 | QueryDoc | This query file has a sub-category of reliability but is missing the `@tags reliability` tag. |
| testcases/BadQualityMaintainabilityWrongToplevel.ql:1:1:11:3 | QueryDoc | This query file has a sub-category of reliability but has the `@tags maintainability` tag. |
| testcases/BadQualityMultipleTopLevel.ql:1:1:11:3 | QueryDoc | This query file has incorrect top-level categorisation. It should have exactly one top-level category, either `@tags maintainability` or `@tags reliability`. |
| testcases/BadQualityNoToplevel.ql:1:1:10:3 | QueryDoc | This query file has incorrect top-level categorisation. It should have exactly one top-level category, either `@tags maintainability` or `@tags reliability`. |
| testcases/BadQualityReliabilityWrongToplevel.ql:1:1:11:3 | QueryDoc | This query file has a sub-category of maintainability but is missing the `@tags maintainability` tag. |
| testcases/GoodQualityMaintainabilityWithCrossSub.ql:1:1:12:3 | QueryDoc | This query file has a sub-category of reliability but is missing the `@tags reliability` tag. |
| testcases/GoodQualityReliabilityWithCrossSub.ql:1:1:12:3 | QueryDoc | This query file has a sub-category of maintainability but is missing the `@tags maintainability` tag. |
| testcases/BadQualityReliabilityWrongToplevel.ql:1:1:11:3 | QueryDoc | This query file has a sub-category of maintainability but has the `@tags reliability` tag. |