avoid reporting empty names in js/exposure-of-private-files

This commit is contained in:
Erik Krogh Kristensen
2020-11-23 14:23:22 +01:00
parent 02d5fbf46b
commit f7f9beeefd
5 changed files with 16 additions and 2 deletions

View File

@@ -80,7 +80,11 @@ Folder getAPackageJSONFolder() { result = any(PackageJSON json).getFile().getPar
DataFlow::Node getALeakingFolder(string description) {
exists(ModuleScope ms | result.asExpr() = ms.getVariable("__dirname").getAnAccess()) and
result.getFile().getParentContainer() = getAPackageJSONFolder() and
description = "the folder " + result.getFile().getParentContainer().getRelativePath()
(
if result.getFile().getParentContainer().getRelativePath().trim() != ""
then description = "the folder " + result.getFile().getParentContainer().getRelativePath()
else description = "a folder"
)
or
result = DataFlow::moduleImport("os").getAMemberCall("homedir") and
description = "the home folder"