hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

avoid reporting empty names in js/exposure-of-private-files

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-11-23 14:23:22 +01:00
parent 02d5fbf46b
commit f7f9beeefd
5 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/Security/CWE-200/PrivateFileExposure.ql
View File

@@ -80,7 +80,11 @@ Folder getAPackageJSONFolder() { result = any(PackageJSON json).getFile().getPar
DataFlow::Node getALeakingFolder(string description) {
exists(ModuleScope ms | result.asExpr() = ms.getVariable("__dirname").getAnAccess()) and
result.getFile().getParentContainer() = getAPackageJSONFolder() and
description = "the folder " + result.getFile().getParentContainer().getRelativePath()
(
if result.getFile().getParentContainer().getRelativePath().trim() != ""
then description = "the folder " + result.getFile().getParentContainer().getRelativePath()
else description = "a folder"
)
or
result = DataFlow::moduleImport("os").getAMemberCall("homedir") and
description = "the home folder"

1
javascript/ql/test/query-tests/Security/CWE-200/PrivateFileExposure.expected
View File

@@ -19,3 +19,4 @@
| private-file-exposure.js:42:1:42:66 | app.use ... dir())) | Serves the home folder, which can contain private information. |
| private-file-exposure.js:43:1:43:46 | app.use ... )("/")) | Serves the root folder, which can contain private information. |
| private-file-exposure.js:51:5:51:88 | app.use ... les'))) | Serves the folder "../node_modules", which can contain private information. |
| subfolder/private-file-exposure-2.js:6:1:6:34 | app.use ... rname)) | Serves the folder query-tests/Security/CWE-200/subfolder, which can contain private information. |

4
javascript/ql/test/query-tests/Security/CWE-200/private-file-exposure.js
View File

@@ -59,4 +59,6 @@ function good() {
app.use("jquery", express.static('./node_modules/jquery/dist')); // OK
app.use("bootstrap", express.static('./node_modules/bootstrap/dist')); // OK
}
}
app.use(express.static(__dirname)) // NOT OK

1
javascript/ql/test/query-tests/Security/CWE-200/subfolder/package.json Normal file
View File

@@ -0,0 +1 @@
{}

6
javascript/ql/test/query-tests/Security/CWE-200/subfolder/private-file-exposure-2.js Normal file
View File

@@ -0,0 +1,6 @@
var express = require('express');
var http = require('http')
var app = express()
var server = http.createServer(app)
// Static files:
app.use(express.static(__dirname))